From owner-freebsd-arch@FreeBSD.ORG Thu May 15 21:19:51 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96DFD37B401; Thu, 15 May 2003 21:19:51 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id C033043FA3; Thu, 15 May 2003 21:19:50 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h4G4JokA052121; Thu, 15 May 2003 22:19:50 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 15 May 2003 22:19:15 -0600 (MDT) Message-Id: <20030515.221915.26535850.imp@bsdimp.com> To: obrien@freebsd.org From: "M. Warner Losh" In-Reply-To: <20030516041506.GA82545@dragon.nuxi.com> References: <20030516031317.GC38966@dragon.nuxi.com> <20030515.220304.68038616.imp@bsdimp.com> <20030516041506.GA82545@dragon.nuxi.com> X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: arch@freebsd.org Subject: Re: Moving the generation of foodevs.h to build time X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2003 04:19:51 -0000 In message: <20030516041506.GA82545@dragon.nuxi.com> "David O'Brien" writes: : On Thu, May 15, 2003 at 10:03:04PM -0600, M. Warner Losh wrote: : > In message: <20030516031317.GC38966@dragon.nuxi.com> : > "David O'Brien" writes: : > : On Tue, May 13, 2003 at 12:18:15AM -0600, M. Warner Losh wrote: : > : > OK. Here's a start at moving it. First, we have to move : > : > devlist2h.awk out of tools back to dev/mii/devlist2h.awk. It : > : > shouldn't be in tool if it only generates MII code, : > : : > : Why shouldn't it be a tool if it only generates MII code? : > : Can't we just rename all the devlist2h.awk's to : > : @/tools/${_dev}-devlist2h.awk? : > : > I can paint this bikeshed either way. tools/devlist2h.awk isn't the : > right name/place for it. I don't care if we do a : > ${_dev}-devlist2h.awk or dev/${_dev}/devlist2h.awk. Arguments can be : > made either way. : : Should we commit this patch (in some form) for 5.1 or after 5.1? I'm not sure that we should rush it into 5.1 at this point. There's nothing really gained by the patch, nor does it really fix any bugs, yet it introduces a risk of breaking some case that works now. Given the problems we've had building the release, I think it would be prudent to wait. Nothing is lost by waiting. Warner