Date: Thu, 17 May 2018 17:41:13 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> Cc: fs@freebsd.org Subject: Re: [Bug 210316] panic after trying to r/w mount msdosfs on write protected media Message-ID: <20180517173539.B1308@besplex.bde.org> In-Reply-To: <20180517163709.F1129@besplex.bde.org> References: <bug-210316-3630@https.bugs.freebsd.org/bugzilla/> <bug-210316-3630-eXVbCR5qFd@https.bugs.freebsd.org/bugzilla/> <20180517163709.F1129@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 May 2018, Bruce Evans wrote: > On Thu, 17 May 2018 a bug that doesn't want replies@freebsd.org wrote: > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210316 >> >> --- Comment #14 from Andriy Gapon <avg@FreeBSD.org> --- >> (In reply to Conrad Meyer from comment #13) >> >> Indeed, if we talk about the general behaviour. >> >> I see that I utterly failed to explain that I was thinking purely in a >> context >> of what msdos does in markvoldirty. > ... > Markvoldirty() was obtained from apple and fixed a bit by me, but is still > very bad, without even this write protection bug. > ... I forgot to mention its main bug. msdosfs doesn't check the dirty flag, so it allows even rw mounts of dirty file systems (and I think it is too dangerous to allow even ro mounts for fs's with FAT). So maintaining the dirty flag is useless for FreeBSD. It is just a courtesy for OS'es that do check the flag. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180517173539.B1308>