Date: Wed, 17 Nov 2004 12:17:31 -0800 From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: scottl@FreeBSD.org Subject: Re: New ACPI PCI Link Routing code Message-ID: <419BB1DB.3090002@root.org> In-Reply-To: <200411170905.34296.jhb@FreeBSD.org> References: <200411111737.00537.jhb@FreeBSD.org> <200411161339.13818.jhb@FreeBSD.org> <419A8CEB.4070305@root.org> <200411170905.34296.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Tuesday 16 November 2004 06:27 pm, Nate Lawson wrote: > >>John Baldwin wrote: >> >>>On Thursday 11 November 2004 05:37 pm, John Baldwin wrote: >>> >>>>I've done some work on the ACPI PCI link code to make it a bit more like >>>>$PIR in that it is link centric and uses actual new-bus devices for each >>>>device link. One benefit of this is that unused links will be disabled >>>>now which might help with interrupt aliasing problems on machines using >>>>APICs. Also, instead of routing IRQs for links via PCI device numbers >>>>using tunables, they are now routed via the link name ala $PIR. Thus, >>>>one uses 'hw.pci.link.LNKA.irq=X' to route LNKA to IRQ X. Also, when >>>>choosing a virgin interrupt, we no longer try to guess at which IRQs >>>>might be used by ISA devices. Instead, we only use known-good IRQs >>>>including IRQs that the BIOS has already used and the SCI if the link is >>>>being routed via ISA IRQs. The patch is at >>>>http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch Please test and >>>>let me know if there are any problems, thanks. >>> >>>I've updated this to the latest current and verified that it compiles ok >>>(since I had at least one report that it didn't patch cleanly and/or >>>compile). I plan to commit this in a couple of days unless I hear some >>>sort of negative feedback. >> >>Oh, please s/style(msmith)/style(9) in some parts you added. > > > Heh, I can do that in the new code, sure. I just ask because acpi_pci_link.c was already closer to style(9) and I'd like all new modules to do that as well. Changes to style(msmith) files should conform to the existing file unless they rewrite it so much that it can be brought into compliance easily. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?419BB1DB.3090002>