From owner-svn-src-head@freebsd.org Thu Jan 14 21:53:23 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57F6CA8398B for ; Thu, 14 Jan 2016 21:53:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x22b.google.com (mail-qg0-x22b.google.com [IPv6:2607:f8b0:400d:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1170E1EB9 for ; Thu, 14 Jan 2016 21:53:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qg0-x22b.google.com with SMTP id b35so364293040qge.0 for ; Thu, 14 Jan 2016 13:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=3hstROI9tobqpg6VjEhUMl7mMi4HEXSAJTVl6qNSgtI=; b=uyhDOnF3m2CsyKWlEwCPGA3QjrkwaUf/E/z098GNQiloiP65I4q98dQK4JNFUbvIaA XEWAJwUvHm6w82E7k0FsuVbM7XoyLKq8ZpUD0bEAb4L3l2u6M9Fe5MjpTwxY8gsQE3XP D3XAIRV00mrjEuGPFjZZIaLt2dq/JK8DXkDFmRmCi9OwrnWumcwlb4yPEYb+3xSfK9/g Czf4OKYi/ChVpQpB7B4FuzsZfKTL7lIEHaUdMM0txfPbckpRMOGQIbf018sxWn2DxFtR mwQwdR2d/UHw5ydu5brbfEIJkCYbZDBSzW24m9tbpFMxdn2bVqWzGoZ15vh1SA6tMG2y VwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3hstROI9tobqpg6VjEhUMl7mMi4HEXSAJTVl6qNSgtI=; b=WrT8ETneNHvhI01jNqMIW85of1p4zb06BpZeh+je6ykS6hs/dUm24OjP5APd8rXpub SZ7cbmyr0IH0f1ZJzVLK3KaQZJDQJjWlPt+MTlnL54xScYFhfXYFKjh5IjQIcs9eHYA9 gIQ3n6s9g2lNt84izcjsqer7ExbbwPSC5SvpZ6qmJZ/IpCwoGcvfrIpQx24KdF0N0CeO VBngqRDO6DfSltDs24d5DdAOvwWSnlwkMayVMzuKO3Kw1fZv7wSOOEQLA3ho6bvFNSB9 vzEiaKtRfQPLO2AQdv+lBBUDZKXvUFWzChSbSKKLd1wOT+Ikm8CCRFYCUWVOGlddq/hp EmJg== X-Gm-Message-State: ALoCoQlOHlHnXPiMavfGfvFrUGkaj6CvylnQNJ0QAjgPOxffXNJ96JLu0RuJwvOoLsNgH8/ibqHu30WA35ygBDDKyle310Wqjg== MIME-Version: 1.0 X-Received: by 10.140.109.247 with SMTP id l110mr8787547qgf.52.1452808402164; Thu, 14 Jan 2016 13:53:22 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.30.166 with HTTP; Thu, 14 Jan 2016 13:53:21 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <5698172E.6040107@FreeBSD.org> References: <201601141853.u0EIrshB007863@repo.freebsd.org> <56980BAE.6070304@freebsd.org> <569812A6.9020101@freebsd.org> <5698172E.6040107@FreeBSD.org> Date: Thu, 14 Jan 2016 14:53:21 -0700 X-Google-Sender-Auth: YdrfWYH9qUtLaec-lh7JcDnOaqU Message-ID: Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader From: Warner Losh To: Pedro Giffuni Cc: Steven Hartland , Nathan Whitehorn , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 21:53:23 -0000 On Thu, Jan 14, 2016 at 2:46 PM, Pedro Giffuni wrote: > > > El 14/01/2016 a las 16:27, Steven Hartland escribi=C3=B3: > >> >> >> On 14/01/2016 20:57, Nathan Whitehorn wrote: >> >>> >>> >>> On 01/14/16 10:53, Steven Hartland wrote: >>> >>>> Author: smh >>>> Date: Thu Jan 14 18:53:54 2016 >>>> New Revision: 294029 >>>> URL: https://svnweb.freebsd.org/changeset/base/294029 >>>> >>>> Log: >>>> Only build EFI components on supported compilers >>>> As the in-tree GCC does not support __attribute__((ms_abi)) EFI >>>> can only >>>> be built with Clang. >>>> The EFI loader and boot1 validated this, but unused libefi was >>>> still built >>>> causing issues under GCC after warnings where enabled by r293724. >>>> Disable building all of EFI when the selected compiler is GCC. >>>> >>> >>> How about with newer-than-4.2 versions of GCC? Surely this *is* >>> supported in newer compilers. Do we need some build infrastructure to h= ow >>> about the compiler version as well as type? >>> -Nathan >>> >> >> If it is then even without this change you wouldn't have have got the EF= I >> loader or boot1, just an unused libefi. >> >> This change ensures that builds with in-tree Clang and GCC build on all >> platforms, even if GCC doesn't build the EFI components. >> >> If someone that uses none in-tree GCC has some time to dedicate to make >> this work that would be great :) >> >> > Specially since the gcc-4.2 compiler will be axed mercilessly before > 11.0-RELEASE. We hope, you mean. Never versions of gcc will be supported where they work, and will be required for some platforms where clang isn't quite there. It looks to be added somewhere around the gcc 4.7 or 4.8 time frame, though I couldn't find it in the release notes. The latest attribute docs have this listed as supported. I suspect that 4.9 or 5.0 will be the earliest version of gcc to be realistically supported with the external toolchain... Warner