From nobody Sun Jul 13 01:25:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bfnnr3vzmz61RXl; Sun, 13 Jul 2025 01:25:36 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bfnnr0RRFz3hsr; Sun, 13 Jul 2025 01:25:35 +0000 (UTC) (envelope-from kib@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 56D1PLUb041310; Sun, 13 Jul 2025 04:25:24 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 56D1PLUb041310 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 56D1PK55041309; Sun, 13 Jul 2025 04:25:20 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Sun, 13 Jul 2025 04:25:20 +0300 From: Konstantin Belousov To: Ahmad Khalifa Cc: jhb@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fb84b9f400d2 - main - kern_descrip.c: only allow complex expression in Static_assert() for clang Message-ID: References: <202507121757.56CHv2Vi075595@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Queue-Id: 4bfnnr0RRFz3hsr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Sun, Jul 13, 2025 at 12:56:51AM +0000, Ahmad Khalifa wrote: > On Sat Jul 12, 2025 at 8:57 PM +0300, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fb84b9f400d2d2bb8e1336fbacc7fbd14d31974b > > > > commit fb84b9f400d2d2bb8e1336fbacc7fbd14d31974b > > Author: Konstantin Belousov > > AuthorDate: 2025-07-11 18:57:32 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2025-07-12 17:56:13 +0000 > > > > kern_descrip.c: only allow complex expression in Static_assert() for clang > > > > gcc cannot compute the assert expression, which is formally not required > > by a C standard. > > > > Reported and reviewed by: jhb > > Sponsored by: The FreeBSD Foundation > > --- > > sys/kern/kern_descrip.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c > > index 93bdd41d1515..c4f5e586b0ed 100644 > > --- a/sys/kern/kern_descrip.c > > +++ b/sys/kern/kern_descrip.c > > @@ -557,8 +557,10 @@ open_to_fde_flags(int open_flags, bool sticky_orb) > > { .f = O_CLOFORK, .t = UF_FOCLOSE }, > > { .f = O_RESOLVE_BENEATH, .t = UF_RESOLVE_BENEATH }, > > }; > > +#ifdef __clang__ > > _Static_assert(open_to_fde_flags_s[nitems(open_to_fde_flags_s) - 1].f == > > O_RESOLVE_BENEATH, "O_RESOLVE_BENEATH must be last, for sticky_orb"); > > +#endif > > > > return (flags_trans(open_to_fde_flags_s, nitems(open_to_fde_flags_s) - > > (sticky_orb ? 0 : 1), open_flags)); > > This doesn't compile on clang14 when cross-building do we still care > about that? > > See https://github.com/freebsd/freebsd-src/actions/runs/16240751228/job/45856816666 Thank you for the report. I do not that we should care much, but in this case it costs nothing to care. I went ahead with bf4d2a45b991.