From owner-svn-src-projects@freebsd.org Sat Feb 20 18:30:09 2016 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56FCCAAF122 for ; Sat, 20 Feb 2016 18:30:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x229.google.com (mail-qg0-x229.google.com [IPv6:2607:f8b0:400d:c04::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 20602F21 for ; Sat, 20 Feb 2016 18:30:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qg0-x229.google.com with SMTP id b35so85149298qge.0 for ; Sat, 20 Feb 2016 10:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=bRatjUQT2v38NmRd1Z8tOFzysgrG4hepFbPgABZPQiE=; b=EltcrS/QZ6SuSErDRJQ/E4eEWzq6M2pYVRc55zdPzF5Bczx7u5YU7r+xlOyYstkF+U lFdyNZoRnDcePoeIjVyKl9Vpp+jiLLavn2fG/x0jJ1g90cyznItml9t/2gOe98eyHUSh l34UrtJ8F7Bm5h7bI0gkoAGyzrNT+xLo0wPhWsN7C/uSIQK8a7aGkvB6WCmWs+HPmTBD UinrD2HLb1uvWUWjm555GoiW8tFYtwYaczn4+juz3fWH1INlVWirKkeEDBuL8tmEN/Gt EfGQZ0Gpmd4ZpvTXcnBc1ygVlf+pp/2kU/qI25osFbu8kEMPT0161ItgMKgoQgbPUa0o u5xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=bRatjUQT2v38NmRd1Z8tOFzysgrG4hepFbPgABZPQiE=; b=l/5gm1cOrrnov3xO495AxHAgY2JgtQXKXmpYLyw+USn33OrTuReL8R8Oc3PCgft+Ez GGj3eEhJVzk3I8S/nbs8Ymx88g/n8ZEJKIca+o7194GjBYa5TqeuO0+6C6mpoyQ0ZJ6j 4e2EaWpa91nOY8KL6Hcu+Y+prjxs1D5JHDZl03p4mriehiGdb3WZ3/GUcLSuATIOe/WE KXv85wqfmeWH+etu2OVOCKwcwJYuNLCQCdGmA9IRetyHaeU6pPPtw+hC8aD7NutwdXOY 2VCIk4Sblt0e7LthTsO5aV2BQBpBmpSzjer0B9ZyYtJwPYhAId301zPqioLBL9K2uWFS 02GA== X-Gm-Message-State: AG10YOQqQN7MwqzG34aDI3Fc7Kdkk+PVDZ112I44dd9mA1zjQNhhOVQBMimHeyRhqEzi412CC7774jZ+kuk6sw== MIME-Version: 1.0 X-Received: by 10.140.43.180 with SMTP id e49mr24164770qga.50.1455993008145; Sat, 20 Feb 2016 10:30:08 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.30.166 with HTTP; Sat, 20 Feb 2016 10:30:08 -0800 (PST) X-Originating-IP: [50.242.69.61] In-Reply-To: <201602191732.u1JHWUCv073014@repo.freebsd.org> References: <201602191732.u1JHWUCv073014@repo.freebsd.org> Date: Sat, 20 Feb 2016 10:30:08 -0800 X-Google-Sender-Auth: LmWwUqWHV0zonbL1jL6uZ-422b0 Message-ID: Subject: Re: svn commit: r295820 - projects/mips64-clang/sys/mips/mips From: Warner Losh To: Sean Bruno Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2016 18:30:09 -0000 On Fri, Feb 19, 2016 at 9:32 AM, Sean Bruno wrote: > Author: sbruno > Date: Fri Feb 19 17:32:30 2016 > New Revision: 295820 > URL: https://svnweb.freebsd.org/changeset/base/295820 > > Log: > clang IAS just doesn't handle $at the same way as binutils. This fixes > errors and will allow a build of GXEMUL to succeed. > > Similar to r295727 > > Modified: > projects/mips64-clang/sys/mips/mips/mpboot.S > > Modified: projects/mips64-clang/sys/mips/mips/mpboot.S > > ============================================================================== > --- projects/mips64-clang/sys/mips/mips/mpboot.S Fri Feb 19 > 17:14:34 2016 (r295819) > +++ projects/mips64-clang/sys/mips/mips/mpboot.S Fri Feb 19 > 17:32:30 2016 (r295820) > @@ -70,20 +70,26 @@ GLOBAL(mpentry) > /* > * Initialize stack and call machine startup > */ > + .set at > PTR_LA sp, _C_LABEL(pcpu_space) > + .set noat > clang IAS is simply wrong. While it doesn't matter so much here, it will in the interrupt handler where it can't use AT. > addiu sp, (PAGE_SIZE * 2) - CALLFRAME_SIZ > sll t0, s0, PAGE_SHIFT + 1 > addu sp, sp, t0 > > /* Zero out old ra and old fp for debugger */ > - sw zero, CALLFRAME_SIZ - 4(sp) > - sw zero, CALLFRAME_SIZ - 8(sp) > + sw zero, ((CALLFRAME_SIZ) - 4)(sp) > + sw zero, ((CALLFRAME_SIZ) - 8)(sp) > clang is wrong here and should be fixed. > + .set at > PTR_LA gp, _C_LABEL(_gp) > + .set noat > > jal platform_init_ap > move a0, s0 > jal smp_init_secondary > move a0, s0 > > + .set at > PANIC("AP startup failed!") > + .set noat > >