From nobody Tue Dec 31 20:13:59 2024 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YN41W1R3Bz5jyH5 for ; Tue, 31 Dec 2024 20:14:07 +0000 (UTC) (envelope-from mirror176@hotmail.com) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2089.outbound.protection.outlook.com [40.92.22.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YN41T2Xnxz4v0K for ; Tue, 31 Dec 2024 20:14:05 +0000 (UTC) (envelope-from mirror176@hotmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=KSsByE3g; spf=pass (mx1.freebsd.org: domain of mirror176@hotmail.com designates 40.92.22.89 as permitted sender) smtp.mailfrom=mirror176@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ksY+PCYpTEZ3AkYj5kBHJwm3SRL3nrneaBuPaPcRgiVTLvfLLltstRPXCkPcgoItWzw29h1xJWzESZcdvvyaJcyqxn2+WwzEmpAvHeYlDwMwyxjlnQL+zw3o+b/niCujxqiET1dEtn7u6AVjMLpgsH5h4Nuke+lc4TKRZ2wujB360qG24F8FCfiJiEOVDzeYEg06OvbAkgUbiJNZ3wI1T4wiu/7tq2moL/NMnxvfeqLNWJosJ2XkuOXVF0XjHFD+kijI4AxUFtwxoumeLrPq9CD4iKpQyZg7/Gr6iq6eQhfV2Vfp4eEIMSYQ+PhdIdG9ARphgto++8PM6aXRemStBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QYTmldcMQFGcbr6ET3uAM+w83vwsNBt+RTtPf9bnmD0=; b=pZ0Fgh0O+ZxOX29h23l+NlrJLFBLjraKJuYI9h7VynNcnlPo2Dily6i9n1ZXoI4p6TE4tS1sA234gV+5RLsnS6SSia/Y5ZK+JtlrKLyH7AzNylwo9BU0Hrmjaw1gp/T/N5y32sb0fbz7SD+nkOg71Jg4FG29F2JWVo11fYBHk/kLeWW7l0z1JIWDCRdRuEVwZsaaJfY1Bjt1Cm9Wmjzry7VJ/MSJiC4dVZfmB7tNMQ4qYTbkfYRb0UwVrsh2qwZ+XIjYENojcEEPucZtvi77Yqldns2zPhBuloES0JhZR+54IzAX5mx8afdqgdsV6Zcgjf6zsYDoOMPtEjCURyeHJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QYTmldcMQFGcbr6ET3uAM+w83vwsNBt+RTtPf9bnmD0=; b=KSsByE3g1FYwiQUQQdniWQFsTqCn11d8k5VcFdr/V/b4BgZaxrwsBF6JDx3OOpsv5Xt3OR7d+UUVhDHTWz4W61wnfK227kK/tZx6NbAtURqkgw9MPgYfiRZfKRCRpZ2BDl2Q2MmKDcqdxo9TJ8b5iRnW5URrAhhYkxA0VJsj9Vq1/5v3EESo38z6RjNJfQLH5k+x6+YBY//UL+6/cFaABQSCUBJ9z1C2QssLSkNON2XW7am6udCQxguyKhEx6h5Bu0Ig7Cm7Gx/SyMhCoHhjSjbVvvE1VxYh4j2yK6MJRW5tXmGeDPeU5NALGEnzf/nsz0suMCmE3wIo7mhIhZ5zgw== Received: from CO1PR11MB4770.namprd11.prod.outlook.com (2603:10b6:303:94::19) by DS0PR11MB7802.namprd11.prod.outlook.com (2603:10b6:8:de::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.11; Tue, 31 Dec 2024 20:14:02 +0000 Received: from CO1PR11MB4770.namprd11.prod.outlook.com ([fe80::bffd:9e35:4afa:a747]) by CO1PR11MB4770.namprd11.prod.outlook.com ([fe80::bffd:9e35:4afa:a747%4]) with mapi id 15.20.8293.020; Tue, 31 Dec 2024 20:14:02 +0000 Message-ID: Date: Tue, 31 Dec 2024 13:13:59 -0700 User-Agent: Mozilla Thunderbird Content-Language: en-US From: "Edward Sanford Sutton, III" Subject: bsdinstall zfsboot: Add an option to edit the ZFS pool creation options To: freebsd-stable@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BLAP220CA0028.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::33) To CO1PR11MB4770.namprd11.prod.outlook.com (2603:10b6:303:94::19) X-Microsoft-Original-Message-ID: <1a729063-42b3-4716-8d29-91e9612e180b@hotmail.com> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-stable@freebsd.org Sender: owner-freebsd-stable@FreeBSD.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4770:EE_|DS0PR11MB7802:EE_ X-MS-Office365-Filtering-Correlation-Id: dc6224eb-cc5f-422a-adbd-08dd29d7aae9 X-Microsoft-Antispam: BCL:0;ARA:14566002|7092599003|461199028|19110799003|6090799003|15080799006|8060799006|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkhVVWhkOXpFdVRuOVFNQjI1Y0R5YzZtbWpFTDJIRk11Z3lKZy9TR2hlam1N?= =?utf-8?B?WHgza3V5VGN6YmFGeWdBbGdhcWVoSGtUOC9UeklHY2IyN1JXaHNLOU8yVkYy?= =?utf-8?B?WHhVWFNQeXZOeXI3cm5KcnpBL3NNTStFNlZMd3hadUM2aktGVnMxY25OeTBr?= =?utf-8?B?R1EvUThyaG9GYmRkdEg3Z1Q4ZEh4U2tPbUpnODFoNnlJL0Vwa2pnNHdGcERu?= =?utf-8?B?SU5jdnJ6NWwwT1FSaGZNbERFZldjSXZWWGxOUi9aa2tQMDJZUTFxWFVqb0xC?= =?utf-8?B?b0FBN0M5dVJQbXkvNkIrMlh3QTRFdzllVGthTkVVWU5tZXFnWkg0Vzl4UGVE?= =?utf-8?B?VjRwbEhWRWw3QnY4bjJLY1dZVEdoRUp2T2QxZU9YZWVZTDduaHZtUHVBM3py?= =?utf-8?B?RS92ZE9RYmNFczFxTUlpbURjVXRHTzEvY3NWSWJkOFlwYmNaM1EwU2pMZTF5?= =?utf-8?B?QTNDRHJWNXYwa1Jady80RDdUQWVUUkhvOHRHSTRCK0NZK0dTNVlkTzM5ZkRO?= =?utf-8?B?b2VYdzNCZDVNbCsyMVN3RkE3RnN3c0tySnpRYTJYUStrb0Z0UXZXdndMc01K?= =?utf-8?B?Nms5QWhucW5Iay80UmUrZHoxZFlxMEkrMlNLOXRKM28wODM2WVFONkRuU244?= =?utf-8?B?Rkt5bkgyUHhWTWNiaWc4TUNWN2JoM20yQmFkK0VMbjFyaEY1cVp0QzhGbVpV?= =?utf-8?B?ekJUNnRmODE3QkVWc1RvTlgyVzYxMjAreWd1cmVuZWFyMTZpQTNadHNPLzUz?= =?utf-8?B?ME1rVElONE5JNCsyZzVkOXUvZFF4UmdVekhTOWFkQTcvY1MyM3JhWUZDZVpD?= =?utf-8?B?Z0djVEJMQXJjQndPOGRhRnlQbFV5ZUx6M3R5ZVhIZ1ZRcWhSWnAvdTlYR012?= =?utf-8?B?WWxTbmhUYWFOcFloSFFVSFF0RzlDQytIbXFmOW9DS1ZYT3h4RW5XR1RjZzRX?= =?utf-8?B?Vk9vYXZ6MXdFTG1iQzl2WWMyUjlJb0JJVFJWWUtoS3RDMW5HNS9KRmwwQkNv?= =?utf-8?B?dnZLYmVLblhFM0h2QUtpM0t0eEd4ZzlDY2VKY0J4SWdoU1ZVZktsU0pSd0Vp?= =?utf-8?B?bXY5NmordWdadldCVjR6YVo4QnMwck55aW5UNUVmVE1qZzUyaHgrSmZvdmZ2?= =?utf-8?B?UXMvL2Z5WmM5WUYyeHZQOFJndkVtb1ZtTDRaNW1hRFFtcVU2NTMydmFtaVdM?= =?utf-8?B?dEQvWkk1a1B5WkhCZEk4WHVXSHBXMzFlWFNwYk9MMUJOTmhWZExqYS96WHZj?= =?utf-8?B?ekxvbnRpUGhKcnIrSDBPdnQvQ1R3aUJUc2paVXRhbkJCdXJnWWtGTHBHWVp4?= =?utf-8?B?YmVWbWs2K2pjRlBRcEdFZW5YeWxBNnhxeG1YdXVGOS93MHpEUnhid0diOVdM?= =?utf-8?B?SE9EYUpaZzJLNW5nNWI1bGRESW84MHhrMFo1TUZCekNZVmpIUU0xZ0RNSTJy?= =?utf-8?B?dWJjRFJvSTRFckZNY29jV2dhbmliOHhTZTNmQnhyaU5Qb0RZQ2FNRjVVaW5P?= =?utf-8?Q?GSoBPg=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzNoYjgzWExPRDRNUzBXaE00ekV1eDhzTDd3VmhTWkUvSjhXOS81NitaU0JD?= =?utf-8?B?ckllczB3Y0dkcnJrU2s2bG9uS0pmK25YdVMxQjBWWEFKVjV4dnh4MHI1WUtj?= =?utf-8?B?RGwyNUhSdFJwS1Z2bTVja1E2enlsVW5kT1FRSU5XMURDbDVXYkxMY09qVmpG?= =?utf-8?B?UUFvTWt3L2tiZ1BxM3ZvaDRVbDNqY0dCVHBuNWh6Ti9vdGxWQkdUTThvdi9j?= =?utf-8?B?L2F0SW5zdCtaZ2ZzenQvQ0MzYkY3U1BadmowV2tNMzZ5dnhpZkpxYTFtcW9m?= =?utf-8?B?dnJ6dWRTMnh3WEc2a3BaR0dYQ0FhdzNhTHNMSkd0YWFnenM5aldlUEd3TXRT?= =?utf-8?B?TGFJS2sxM1pqTTVjaGFlY1FKZktOcFNnUkxXdzBPSm92V0loc1lkUnlza3Jw?= =?utf-8?B?ZDBDcmNublZ0dENaaUNBeHNNR1hkSll4ZEVFSXh1a0xwSXNvREE3YU9QRUE5?= =?utf-8?B?UlF3WG9UNEFDWDErMkZaWnNnVmxHWTUxa1VlSFdmSXdkd3lQNmNjK0JiS1lh?= =?utf-8?B?YW11bXVLME53eUZJSkJoZWNPeUdsQ0RGV3hxbjBpZFp3SVJyMXlLR2VqLzI1?= =?utf-8?B?QjBYaTNrNks2dXd1UG1KUEV2dEJBQ3RodTQvM1ZFNUJNbHV6N1ZvMC9ReGZB?= =?utf-8?B?VUdEYnhrd3dMcmlvV2hLak94Z01DRXNTZWpSNzFxRWk3dldzY2JOMjEzOTFS?= =?utf-8?B?R2ZZVlVLUDlIZkdFdEFCUkRFT05ORXNMYW5tc1Z6T3YzS2Q1K2JoRUM1bkxr?= =?utf-8?B?clZuaE1OUGlTT0RBZzYvWjVsb0EzaW1Xb1BmTTJZWWdUNk5GNEEvSHZET2dK?= =?utf-8?B?ZFdwMVJEOXh0U0FpdUp5QmlIZi95bW1zR3BtYlVoVTloQ0ZOY0lSbFVTT1ly?= =?utf-8?B?Kzdtczk2UlhBWE55V1N2VWFZSVdxdE54SFprRm92YVpCeWFHeE16TTUwUTJX?= =?utf-8?B?aHJPTk40V3FCeGNCM29IZlBaTzRXMTBxdi9DSTlZSllZaDlnTHB4dTNBY1hT?= =?utf-8?B?a2pwLzlVNkxkWDVwMFQvWnpIQzFydjJ4a3VyOVlTekNjWENVWUFyMzJSRGs4?= =?utf-8?B?OUltemh1Yy84WmVPQURuU1VOcGswS0dRVkFZOHpXWDdsQjVpUS9NVEFIQ05F?= =?utf-8?B?UDd0RUtjWjFIemFscm9WZUJlV3FadUFpdFN5cVJRSEZWOStSY0lxY1F2d00r?= =?utf-8?B?VnJKclNHbXVNRk50S3hPNW1jdmNGTUs3bHdBczRZYXF0ZW8zNkV6c3o0c0ln?= =?utf-8?B?OW4xRzE1YTNBYnV0alhzcmJGUjRSdktVV0RnSDMyK2p2eG5xZTcxcW5zWEdy?= =?utf-8?B?TC9nSnBVeTZlekhTQmRwSFNLcUFzY0lLRzlkM0hadFdFUXJzcnNxNUlMaHpz?= =?utf-8?B?M0ttSkp0STVrQ2NGeisxc0VkYjJ3RS82dGd4WlY5YW0yTXY0WUVGZkJnWTZ0?= =?utf-8?B?WGU2YTVobEpxcytraHhleGZ6S1J5cUdabU1jNm1tN0QwNUpUZzNRSjlpK3FL?= =?utf-8?B?cmxFNXh2QzF5N0FKeWtEOFBib2Z3MUpKZ0VCVUdHL3V0SXVObjlhQmV1Tk40?= =?utf-8?B?TlJZeWRuZmJDRkRqdGlJZElPem9DdXRxZmRIVk0vM2g4VGh1UFdaQTZkVXNm?= =?utf-8?Q?6V+bxox2YdWF3Ru1gWCJ5NDzYlMXVS2FsD3gCovlcARs=3D?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-1ce3f.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: dc6224eb-cc5f-422a-adbd-08dd29d7aae9 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4770.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2024 20:14:02.3604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7802 X-Spamd-Result: default: False [-2.46 / 15.00]; FORGED_MUA_THUNDERBIRD_MSGID_UNKNOWN(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector10001:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.970]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; R_SPF_ALLOW(-0.20)[+ip4:40.92.0.0/16]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_FROM(0.00)[hotmail.com]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[hotmail.com:+]; TO_DN_NONE(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.92.22.89:from]; MLMMJ_DEST(0.00)[freebsd-stable@freebsd.org]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; RCVD_IN_DNSWL_NONE(0.00)[40.92.22.89:from] X-Rspamd-Queue-Id: 4YN41T2Xnxz4v0K X-Spamd-Bar: -- Noticed a commit added this to FreeBSD stable. Skimming through the commit and screenshots from the differential revision (haven't tested it personally yet) I see that it describes it as changing options to the ZFS pool but is then followed by changing options for datasets within the pool. There is a difference for options that apply to a pool versus options that apply to a dataset. I thought reading and writing properties is only sometimes interchangeable between pool and dataset with ZFS tools doing what is intended instead of what was asked while other times you just get an error. Can this be clarified for adjusting dataset(s) properties instead of pool properties if that is what is being done? Example screenshots form discussion while it was worked on normally showed compression=lz4 and atime=off which is the default for all but 1 dataset last I reviewed what the installer is doing. I figure altering compression, encryption, (ref)reservation/quota would be more likely to be adjusted and away from defaults when adjustments are made by users. Setting options that apply to all datasets on the one pool is a handy quick override. Further expanding how users are prompted to be able to adjust each dataset individually would be more useful than having to change all datasets to use same override. This then opens up options like a read only dataset that won't be used for storage getting refreservation to force a certain amount of space to remain free; this example is a dataset property that is easy to add after the fact but likely more steps for someone wanting to automate an install with it being done during install but some proerties require being set during creation or have limitations and consequences otherwise. It would be useful if the installer gave us disk selection, likely combined with pool(s) creation but both could be separate configuration screens with one feeding to the next; that opens up options for multiple pool creation during install and with different devices, layouts, and options. Then having control of pool specific layout+options which I presume is quite hard to implement in a way giving full control to the user. After that, a list of all partitions/datasets where selecting them allows changing individual partition/dataset properties would be handy; inheriting the properties to other datasets should be part of the user prompt when adjusting datasets that others depend on. Such an installer layout should make adding geli, labels, etc. start to become easier to provide as additional options or entirely new layers between these for the installer's interface.