From owner-svn-src-all@freebsd.org Thu Nov 26 21:23:25 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 107D8471074; Thu, 26 Nov 2020 21:23:25 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ChrMt4sGZz3PkY; Thu, 26 Nov 2020 21:23:21 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p50806162.dip0.t-ipconnect.de [80.128.97.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C4F6F24EBD; Thu, 26 Nov 2020 21:23:18 +0000 (UTC) (envelope-from se@freebsd.org) To: Cy Schubert Cc: "O. Hartmann" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202011261739.0AQHdpe5012982@repo.freebsd.org> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> <202011262003.0AQK3BTe076596@slippy.cwsent.com> From: Stefan Esser Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests Message-ID: Date: Thu, 26 Nov 2020 22:23:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <202011262003.0AQK3BTe076596@slippy.cwsent.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 21:23:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy Content-Type: multipart/mixed; boundary="m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ"; protected-headers="v1" From: Stefan Esser To: Cy Schubert Cc: "O. Hartmann" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests References: <202011261739.0AQHdpe5012982@repo.freebsd.org> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> <202011262003.0AQK3BTe076596@slippy.cwsent.com> In-Reply-To: <202011262003.0AQK3BTe076596@slippy.cwsent.com> --m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 26.11.20 um 21:03 schrieb Cy Schubert:> But this is still a problem: >=20 > ld: error: undefined symbol: bc_lib_name >>>> referenced by vm.c:752 (/opt/src/svn-current/contrib/bc/src/vm.c:752= ) >>>> lto.tmp:(bc_vm_boot) >=20 > ld: error: undefined symbol: bc_lib >>>> referenced by lex.c:225 (/opt/src/svn-current/contrib/bc/src/lex.c:2= 25) >>>> lto.tmp:(bc_vm_boot) >>>> referenced by lex.c:227 (/opt/src/svn-current/contrib/bc/src/lex.c:2= 27) >>>> lto.tmp:(bc_vm_boot) > cc: error: linker command failed with exit code 1 (use -v to see invoca= tion) > *** [gh-bc.full] Error code 1 I cannot reproduce this issue on my system. The symbols are defined in files generated by gen/strgen.sh and there was a change in the parameters passed to this script, but I had fixed usr.bin/gh-bc/Makefile accordingly (first in the port and then in base). The generated file lib.c should start like this: ----------------------------------------------------------------- // Copyright (c) 2018-2020 Gavin D. Howard and contributors. // Licensed under the 2-clause BSD license. // *** AUTOMATICALLY GENERATED FROM gen/lib.bc. DO NOT MODIFY. *** #if 1 extern const char *bc_lib_name; extern const char bc_lib[]; const char *bc_lib_name =3D "gen/lib.bc"; const char bc_lib[] =3D "scale=3D20\n" ----------------------------------------------------------------- This file is generated by this rule in usr.bin/gh-bc/Makefile: lib.c: lib.bc cd ${BCDIR} && sh gen/strgen.sh gen/lib.bc=20 ${.OBJDIR}/lib.c bc_lib bc_lib_name 1 1 By a script that assigns parameters to variables: input=3D"$1" output=3D"$2" name=3D"$3" label=3D"$4" define=3D"$5" remove_tabs=3D"$6" And label=3D"bc_lib_name" is used to generate lib.c as included above (passed as 4th parameter). I'm rebuilding a clean world, now, but I'd be surprised if it failed after succeeding before readying the commit ... Regards, STefan --m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ-- --maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl/AHMUFAwAAAAAACgkQR+u171r99USD UQf8Dj9o/OUbC355s/FyrADVuwd6pnaMWyaIpUjMp+bQV+xL+7sMcyrjaXlz7/+aEkrAbEGQhxCF cogDTtGf+68HIl2/H4NepMVP2zCodbqeFM10NiLeKCF/cTThMfjwjic/+4u9M00aQlIMujs6uO/L G7CB3iEX7Sj7OCk/QWAi/rCmLGZ9Q+cAIGUO25iD9/Txc08U/NHE3px2Db0G6gt+rH4duTwZG635 4ZnZ+Qzea7on+ypk6bCC2Jz5jBtqWjoVf7zIzmJFbDQ/7nGVmLJYTduF254i94lFNzFMeEifezzn vYEJEpHAYFeRc4ovaHV5khcwfcWFIk3pacARDwcTPQ== =Ht8B -----END PGP SIGNATURE----- --maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy--