Date: Fri, 15 Jun 2018 12:20:59 +0200 From: Michael Gmelin <freebsd@grem.de> To: Mahmoud Al-Qudsi <mqudsi@neosmart.net> Cc: Michael Gmelin <freebsd@grem.de>, Adam Weinberger <adamw@adamw.org>, freebsd-ports@freebsd.org Subject: Re: Removing git dependencies on perl5 and python27 Message-ID: <20180615122059.7cacad99@bsd64.grem.de> In-Reply-To: <CACcTrKezGY6bAKdz%2BJihksD_Lh=0W1w9--DAenuYtQL0Y7fcaQ@mail.gmail.com> References: <CACcTrKebiP4BCK6F6FaCV8wJggstcSxmSGv9d=iFzYdtaLn-sw@mail.gmail.com> <CAP7rwciw%2BhzTcH1qrdTix1HJKci9-PVmzXfyeVk6OYbg7DgGDg@mail.gmail.com> <0DF706C2-DD9D-45DB-968F-8599D88D7622@grem.de> <CACcTrKezGY6bAKdz%2BJihksD_Lh=0W1w9--DAenuYtQL0Y7fcaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hm, seems like you're right, which is good news for me, I always built
it without perl until this commit:
r396048 | garga | 2015-09-04 00:00:03 +0200 (Fri, 04 Sep 2015) | 5 lines
- Update to 2.5.1
- Fix build with NO_PERL set backporting a commit from git repo
(82aec45)
- Add git-submodile, git-am and git-request-pull to the list of commands
that doesn't work without perl
@@ -86,7 +86,7 @@
mv $@+ $@
else # NO_PERL
-$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh
-+$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-am
git-request-pull: % : unimplemented.sh ++$(SCRIPT_PERL_GEN)
git-instaweb git-submodule git-request-pull: % : unimplemented.sh
Seems like it was removed again here:
r416890 | garga | 2016-06-14 16:52:40 +0200 (Tue, 14 Jun 2016) | 4 lines
Update devel/git to 2.9.0
@@ -88,7 +38,7 @@
mv $@+ $@
else # NO_PERL
-$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh
-+$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % :
unimplemented.sh ++$(SCRIPT_PERL_GEN) git-instaweb git-request-pull:
% : unimplemented.sh
Thanks,
Michael
On Fri, 15 Jun 2018 03:10:37 -0500
Mahmoud Al-Qudsi <mqudsi@neosmart.net> wrote:
> On Fri, Jun 15, 2018 at 2:57 AM, Michael Gmelin <freebsd@grem.de>
> wrote:
> > Last time I checked, building git without Perl broke submodules
> > (which is a core feature that should work with a default
> > installation).
>
> I fully agree. Fortunately, (at least at a first glance) that does not
> seem to be the case.
>
> I just built and installed git from source on a clean FreeBSD 12
> install:
>
> ```
> mqudsi@freebsd12:/easyre % mkdir test
> mqudsi@freebsd12:/easyre % cd test
> mqudsi@freebsd12:/easyre/test % git init .
> Initialized empty Git repository in /easyre/test/.git/
> mqudsi@freebsd12:/easyre/test % git submodule add
> https://github.com/neosmart/pkg-graph
> Cloning into '/easyre/test/pkg-graph'...
> remote: Counting objects: 41, done.
> remote: Compressing objects: 100% (27/27), done.
> remote: Total 41 (delta 16), reused 38 (delta 13), pack-reused 0
> Unpacking objects: 100% (41/41), done.
> mqudsi@freebsd12:/easyre/test % perl
> perl: Command not found.
> mqudsi@freebsd12:/easyre/test % perl5
> perl5: Command not found.
> mqudsi@freebsd12:/easyre/test % fd '^perl$' /
> /easyre/git/perl
> /easyre/git/t/t4034/perl
> mqudsi@freebsd12:/easyre/test % git --version
> git version 2.18.0.rc2.dirty
> mqudsi@freebsd12:/easyre/test %
> ```
>
> Mahmoud Al-Qudsi
> NeoSmart Technologies
--
Michael Gmelin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180615122059.7cacad99>