From owner-svn-ports-all@freebsd.org Thu Jun 30 11:19:22 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7006DB852AB; Thu, 30 Jun 2016 11:19:22 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F0D4328FF; Thu, 30 Jun 2016 11:19:21 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id v199so216838596wmv.0; Thu, 30 Jun 2016 04:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2u55C3mkFg7rOzW8hPMQLweTC3C3lrA8Mx/EZAXnElc=; b=roUF4PCI1g8GjuZw5R7jMVBauN4CjayuDFlGQTuN6DVZfIdOd1uS8RMf4OpZuXG0KU rruwHtDmX9IYhc4BysPvjrqMBc4njj1QN+hVEw5yz6obaJJOV0jmKS87Rsh1WOmygwim 5GYqTwnY7H+yxqG3OekKeiET+4zIe3Ope6+AwdlLd2A2sFai4tAvd5ae9MRyk2Z3EDXL BL7XNmDHpaAeweyn5Fms7oi1Yvx9kvUVmTgwSHEBlUz4vZ2AGCgxV7M9cYo0uAr4t0df mhihKXwCz9O7ZuOrCPCMZe08nWSYnc+7UZLg74qCed7rbjcmdN3btnmjdv418XGVgG4J yPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2u55C3mkFg7rOzW8hPMQLweTC3C3lrA8Mx/EZAXnElc=; b=Su5/QrY6gqVkiVW18fnG57wjJzU0y+fizlV2F0sTi0XicB2XsfveGX31YfR94IUgYV yxeRo8+YRjLWtDDRDGhgQODvw5+ZDxriI2ANq1WDnrU4dpszA5G/U4a2lNwzBSiNZ9IS 4xL+jLSzIzYPGqUNfKCRCmuhQsqZGYUxTSS5/MOl60tZ6DIsK168Yac/X44ImeM6tubi OKBB6pC9Jy9Wk3Qzdz88OZwMqKA0aJhh9GpPYQfp0Waak4ZYOfootSCzUh1igUANcVze vIna3DiC0dbW45BVBMqJG9YHKgNIToRp0Ur5HRmqKR9nlt/QIRd0lZE8YqgfQ7apGZFl kxDg== X-Gm-Message-State: ALyK8tLJRjrkDXzvKY9JG5iX4wVCbLrq+NbSPD5/XnT0BDCV+K1yTXgc3htZHiOhlHWjyg== X-Received: by 10.194.7.70 with SMTP id h6mr13211009wja.38.1467285559964; Thu, 30 Jun 2016 04:19:19 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id bh7sm2816709wjb.22.2016.06.30.04.19.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 04:19:19 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 30 Jun 2016 13:19:18 +0200 From: Baptiste Daroussin To: Mathieu Arnold Cc: Bryan Drewery , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417364 - head/Mk/Scripts Message-ID: <20160630111918.nhilkb4xgrgqwlde@ivaldir.etoilebsd.net> References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> <685BD37565065F0C493733CE@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7pl3dz4woquv2nwa" Content-Disposition: inline In-Reply-To: <685BD37565065F0C493733CE@atuin.in.mat.cc> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 11:19:22 -0000 --7pl3dz4woquv2nwa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 30, 2016 at 10:21:03AM +0200, Mathieu Arnold wrote: >=20 >=20 > +--On 30 juin 2016 07:41:09 +0200 Baptiste Daroussin > wrote: > | On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote: > |> On 6/23/2016 4:31 AM, Mathieu Arnold wrote: > |> > Author: mat > |> > Date: Thu Jun 23 11:31:15 2016 > |> > New Revision: 417364 > |> > URL: https://svnweb.freebsd.org/changeset/ports/417364 > |> >=20 > |> > Log: > |> > Extend the symlink checks to warn on absolute targets. > |> > =20 > |> > Sponsored by: Absolight > |> > Differential Revision: https://reviews.freebsd.org/D6930 > |>=20 > |> Why? This seems like noise. > |=20 > | Quite true as it is I overlooked it. > |=20 > | To ease relocatable packages (to prepare sysroot for exemple) symlinks > | that points to file within the same package should be absolute links. > |=20 > | After looking at this patch again I think it should be reverted and > | replaced later by something that will check symlinks on the same plist >=20 > Mmmm, I can add a check to see if the target is in STAGEDIR and only emit > the warning if it is. would definitly help Bapt --7pl3dz4woquv2nwa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXdQA2AAoJEGOJi9zxtz5aY5gP/15DVsc5w2B7MTdfCQy6XonH pK/8RjrXrwt6q25WeMo87inR5+JTKajoKvKvDnin3cqLMgulLtcfh1B3Mygo2nig KD47A8KFCsJk5DipLoVC8tT3l7u0SlOa3xEe8R377QSXm12gW6VqGn32BkpGH8K2 FdHBU6CG32veK2b82KqOTsaJ5ArbBMZVkiNwrCIITtmaFgYqqAkqwh/etpVsroZU U9TkYUcAtyR/O++BxKiM3xfzB4uxnJOeclXaUTeGuV3cLhmGbC1KD3xTOhLw8M0n H/+HX7vGuuvZNVN3DI8WlWotL4cLV9Cy2SM6oNOqqDguTiHW+SPQwBaKbfvmXBjB cm3ET8k+09ykXwDsvWS6YGsblqTTRIQg7QXYDS/bCpksbGSNlpcYIRQKV8dfpFzj 5wG+7ap9FRAwLwrZ13Wic5u/CXYZBviP7J7eWSfgWKKp+5ZCNw3F7WXo7AIWOU1t oszGD17FjWQOO08ufmHwsfYjMb+mUPveMq5/C9/pXhu9k52w8jhg4WjrGzxoE28I pz8iwhTnRM6wgm3NkwckBOmiECvohClyEhT4T7lkiv5YQ6BclKbQfMmnhVR4kwkc QoHaNt+gYgfQVTYytsh7dusZrfJKytAMBKlb3MmOT9MLHoVVukjAMUzHCbyra2Z3 tH/anurkB19p7BaKBwBZ =9y4T -----END PGP SIGNATURE----- --7pl3dz4woquv2nwa--