From owner-svn-src-all@freebsd.org Thu Dec 17 06:13:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D93AA49AD3; Thu, 17 Dec 2015 06:13:51 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x233.google.com (mail-pa0-x233.google.com [IPv6:2607:f8b0:400e:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53B6B12FD; Thu, 17 Dec 2015 06:13:51 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pa0-x233.google.com with SMTP id wq6so36640228pac.1; Wed, 16 Dec 2015 22:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=C6DidgWRS47fxY+b9tR2zAP4pcSHm0QadxePMGuTCeI=; b=HFFNBes5DEmSuxBF1vOoNG8Zo8dEMfTGkHgoZPyl+CCZzbqemlAphvpnHmne/PBe+m 2O064SpKPy/PL1OvXuIL//dAFRVO8HBmUgXNAF/Lu25y4csJDzrYTGaSoLUvN1VDdrUL lp8ohnLukL5vw46mv5uPKMzFcgPXGil+EKOv+J2WBNu8h4TYjesPryW8ciVHmRYq0+ZG EXhryror1aVTUx7WQHVCmTs/7lcNq6SRG+GMLP77guPeTjkPdHNwwb7rdfVayqZKbMUv aerqpM9l0MQ8GZasRFCH2eKW8CmLjxiX13Q4QX4nPKgKwrH0ylfrS8a0gFuC4fX1pCcx WFcw== X-Received: by 10.66.190.66 with SMTP id go2mr70745593pac.114.1450332830731; Wed, 16 Dec 2015 22:13:50 -0800 (PST) Received: from ?IPv6:2001:44b8:31ae:7b01:c825:be55:88ec:f9f1? (2001-44b8-31ae-7b01-c825-be55-88ec-f9f1.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:c825:be55:88ec:f9f1]) by smtp.gmail.com with ESMTPSA id mj1sm12960867pab.34.2015.12.16.22.13.48 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Dec 2015 22:13:50 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r292379 - in head/sys: netinet netinet6 References: <201512162226.tBGMQSvs098886@repo.freebsd.org> <20151217003824.GG42340@FreeBSD.org> To: Gleb Smirnoff , Steven Hartland Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org From: Kubilay Kocak X-Enigmail-Draft-Status: N1110 Message-ID: <56725294.80803@FreeBSD.org> Date: Thu, 17 Dec 2015 17:13:40 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Thunderbird/42.0 MIME-Version: 1.0 In-Reply-To: <20151217003824.GG42340@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 06:13:51 -0000 On 17/12/2015 11:38 AM, Gleb Smirnoff wrote: > I'm sorry that wasn't able to review D4111 in time, but I have > very strong concerns against r292275. And r292379 doesn't > improve situation. I am asking you to back out both patches, > and then we can get together back to the problem. The 156226 > bug was sitting for 2 years in the bugzilla for a reason. It > is a not "low hanging fruit" like koobs@ says. To clarify my comment on the review, I intended to refer to the *value*, and concrete *definition* of the desired feature (ie the problem space), not the triviality of any solution or implementation. I do my best not to presume where I don't have knowledge :) ./koobs