Date: Thu, 16 Sep 2004 04:07:14 -0000 From: Dennis Berger <db@nipsi.de> To: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: if_fxp.c.patch Message-ID: <40D78638.3030901@nipsi.de> In-Reply-To: <200406220143.05302.max@love2party.net> References: <40D760E5.7000903@nipsi.de> <200406220143.05302.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Laier wrote:
>On Tuesday 22 June 2004 00:27, Dennis Berger wrote:
>
>
>>Hi,
>>today I tried the fxp driver patch and run into a kernelpanic if altq is
>>enabled.
>>I guess it's something strange with the locking cause the debugger stops at
>>fxp_start_body();
>>this is exactly the point where a lock is needed, or whatever there
>>happens...
>>
>>pyun discovered similar problems months ago, he fixed it by modifying
>>the LOCK macro.
>>to something like this
>>
>>#define MY_LOCK do { \
>> if(!mtx_owned(&lock) \
>> mtx_lock(&lock); \
>> } while(0)
>>and
>>#define MY_UNLOCK do { \
>> if(mtx_owned(&lock)); \
>> mtx_unlock(&lock); \
>> } while(0)
>>
>>I don't know why he have to check if the lock is held...
>>
>>
>
>Neither do I, but maybe you can provide a complete trace of this panic so we
>can find the real problem instead of fixing the symptoms? Moreover, if there
>is a panic *in* fxp_start_body that means that we fail the mtx_assert (i.e.
>the lock was not properly acquired), above fix will not help it.
>
>
>
stopped at fxp_start_body:+0x256
sorry I can't get my kernel to dump core... I dunno why DDB>panic
doesn't dump core...
and "call boot(0)" doesn't sync my disks either *argl*
I can't write off the whole trace... I need to get my kernel to dump
core. maybe tomorrow more.
>Please provide the complete (function names are enough for a start) trace from
>that panic in order to give me an idea of the panic. Please also tell me what
>kind of queues you have set up.
>
>
>
altq.pf.test
>Thanks.
>
>
>
-db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40D78638.3030901>