From owner-freebsd-ports@freebsd.org Mon Jun 27 22:09:47 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59C2AB85269 for ; Mon, 27 Jun 2016 22:09:47 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2C422C3C; Mon, 27 Jun 2016 22:09:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x235.google.com with SMTP id v199so116855424wmv.0; Mon, 27 Jun 2016 15:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kZH1WCZE/jvulswBYRtUPAvVz0dmNfInfSR5O2pdPMo=; b=kXaya79cFYigtiArUFJJRMipdIxehV6KcxJBQzBUKPryIdJ5UxHH4BrjzeYM9PCoM3 mneUT/edzjhpVwH68Mi3w/IjEv1x02hhcRdouxQ4aBkTXxtlPqa8XnqKDDRsRR2sRATN XmYxqKZHYKj+lyPAytN8BlZC/pD3eT+JejbMN9entpr8VKBw/pudzJV9CXFQzzM+5QUw 9TeFttAhm+hf3bfAhRmMBg2HvFhfwWOVNJtdHkWjvb9dewqs0UuzY/P5T13y94/DbWoJ c0o33e+9LfrVv03XQfVB6uZrO85BAdXwxotPUl8j8DIDoU/9+ga4sSM+zzSIgz/uAj59 Ok/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=kZH1WCZE/jvulswBYRtUPAvVz0dmNfInfSR5O2pdPMo=; b=MsJHgctuZx1/35G/LGab2ECqvLdZP05oqneNPKMXFzYYSaVbETl0M5E8hhwUM1fGLw mszUkdnvWkdd1c27N+duiUGRciSkDdxcBsLs/eSyKELEyCFMGx07UR5X3Y7q2Hjv/QeG zN05uW3MN82r0eTLFuvzpjdQvrBAcV8O57zOsWn/OK7m2VqJ1MMEp10M9D0vTOKuWieg SA1d2CvArusDUxPbuWb5cB2CZwZO16QrsR/xOHfWwnfcV/u6T4HjtD3RJIjAlPh1V6b4 PIy84m9DjhbJZYCMg20Pmoz+k9ls7yILEfdV2or1xyc2nCXmhnapex3nN0bvYkqlWTB1 M80w== X-Gm-Message-State: ALyK8tJ3dLHAv9ukB1+a26TiP6Cnkx9OHcYtq8vUX6XkGhbsWmalMmpazhbrd28MgjYzTg== X-Received: by 10.194.167.39 with SMTP id zl7mr2964951wjb.98.1467065385297; Mon, 27 Jun 2016 15:09:45 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id bh7sm5986910wjb.22.2016.06.27.15.09.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 15:09:44 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 28 Jun 2016 00:09:42 +0200 From: Baptiste Daroussin To: Rodrigo OSORIO Cc: freebsd-ports@freebsd.org Subject: Re: pkg SAT_SOLVER bugs Message-ID: <20160627220942.gy7t3klnswmukz6q@ivaldir.etoilebsd.net> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tgtwzxc5dak6i2b5" Content-Disposition: inline In-Reply-To: <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 22:09:47 -0000 --tgtwzxc5dak6i2b5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 27, 2016 at 11:42:08PM +0200, Rodrigo OSORIO wrote: > On 06/27/16 12:38, Hans Petter Selasky wrote: > > Hi, > >=20 > > I found some bugs in PKG with regard to the SAT_SOLVER environment > > variable. Please find patch attached :-) > >=20 > > Issues fixed: > > 1) No need to use hash table when generating SAT rules for external > > solver. Variables are already in a linear array. Fix encoding and > > decoding of SAT data. > > 2) Endless variable loop caused pkg to crash. > > 3) it->inverse was checked for non-zero, while it should actually be > > checked for -1 only. SAT rules produces were all negative. > >=20 > > How to verify: > >=20 > > make -C /usr/ports/math/picosat all install clean > >=20 > > env SAT_SOLVER=3Dpicosat pkg upgrade > >=20 > > --HPS > >=20 > >=20 > > _______________________________________________ > > freebsd-ports@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > >=20 >=20 > Thanks! this patch saves my day, I was stuck reinstalling a computer in > current, and after few rounds using pkg the solver start complaining and > pretending missing packages was yet installed. >=20 > I apply you patch on top of the last version in ports and the patch work = as > a charm. I'll keep testing it until a new version comes. >=20 > regards, > - rodrigo that is unrelated, what saved you it that building from ports you switched = form 1.8.5 to 1.8.6 his patch is to solve the use of an external SAT solver whic= h I admit I haven't tested for a while. Pkg 1.8.6 is the default binary package for all release but head right now, pending for the next build cycle. Best regards, Bapt --tgtwzxc5dak6i2b5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcaQPAAoJEGOJi9zxtz5a4okQAIezpNF2tRVdWZTbWMlPvYI0 YTPGAryJXCq5ueaxaOlVX/hfHn88hTwuJBs3q1HvKSkvtzOzu1nq4H8zk+NIa2vc CGw4uMwiqFEWwHa1NceRPd896lI+cSQRqY5qWosO1LF+u4104DjaZXUhodbmD6Dm aCE74JWDhiwMINF6EydAA1OQruvgU3HOFzOD8Nq1sQ1jTPn5Rs3GzjlF8uAg0Bqm zO7FRA/tvUOacImJs8p5Ad0Z5eK9yWphNXAmAuR78cyw4WGRHILEzhbsYZnxpLSJ 3BT/5uJVKYUMC0r3Mm9p4dP6xtt+1TOFElbDmvv3evMci1LJVFkr+5PW3HsdVmcP cSIelxqM+OWcpvz1ThBfT3NaXeRuWfW+eMuMRbv9gMn5oso85woqoWomxJ2xpKFg BiU+yu1if7mNCrAseoYizs6t05mvgNqGXi/i2SzvQzVVihr43knRwQQeC/bBPDAS mea5baHCHZq26dwi8ckclFhP18UnNFNYG5oCi5YgGCyLmaFpLK+XTY6L7VRE6m/W ZbF+L5e5AKL/v4zFg9kv3Wk3J4WVU9WY9SLTta9vL9p+1ccNRQkuy8X0y2xiU+g/ ZbLdmBCSpoK8BRbBxTuSwwlELLjVDWBHtDGSkPnkPteTxiRl8sWiEmFebfNmeL2Y 7B8tohIl2cNGIDeAgDb3 =F1uG -----END PGP SIGNATURE----- --tgtwzxc5dak6i2b5--