From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 18 00:05:54 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A3FEA80; Tue, 18 Mar 2014 00:05:54 +0000 (UTC) Received: from mail-oa0-x22b.google.com (mail-oa0-x22b.google.com [IPv6:2607:f8b0:4003:c02::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D915BC6B; Tue, 18 Mar 2014 00:05:53 +0000 (UTC) Received: by mail-oa0-f43.google.com with SMTP id eb12so1199374oac.30 for ; Mon, 17 Mar 2014 17:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=OjU8GaFZtDb7NfbbSxtyJ6ZnP2SS6WtHiwbTQPMFBgY=; b=lVxgpMwkVZlL+00G47PxcFqJ/6HFdMxDy2p+dYnZTZRkrIzEzoxxdnlLDKgT+vfrCT HVrvgJL9dI0zzo97QLH6NS3SqW0KZpntKIyhghTb3UtpJkkOutpefr4Io+knIg/HuB5K 3Kqm38VgvOs6orngtIHN2PdGIP16FNf1inF0DBQBgcjHAxSgaOgYHjy7/L1qf3QrhEe0 3eclBVmKANs7nW1+fy9xWLpxVRgBNFZWlYNefwa8+v65iQqcHPQZ8Oc+QxUHYhDwqExt ahbaP2/4oWrsyYLCkwkYyqkBy0Qr5la/N/nhIbPS5xCWJlADT8aqUg+P3+zYqdgHfSWw NkwQ== MIME-Version: 1.0 X-Received: by 10.182.65.199 with SMTP id z7mr22954556obs.7.1395101153153; Mon, 17 Mar 2014 17:05:53 -0700 (PDT) Received: by 10.182.130.71 with HTTP; Mon, 17 Mar 2014 17:05:52 -0700 (PDT) In-Reply-To: <53269B0E.5020904@FreeBSD.org> References: <53269B0E.5020904@FreeBSD.org> Date: Mon, 17 Mar 2014 20:05:52 -0400 Message-ID: Subject: Re: Definition struct and int From: Joe Nosay To: Kevin Lo Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: FreeBSD Hackers , Adrian Chadd X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2014 00:05:54 -0000 On Mon, Mar 17, 2014 at 2:49 AM, Kevin Lo wrote: > On 2014/03/17 14:07, Joe Nosay wrote: > >> On Sun, Mar 16, 2014 at 1:07 AM, Joe Nosay >> wrote: >> >> >>> >>> On Fri, Mar 14, 2014 at 5:43 PM, Joe Nosay >>> wrote: >>> >>> >>>> >>>> On Thu, Mar 13, 2014 at 9:26 PM, Adrian Chadd >>>> wrote: >>>> >>>> Is this -HEAD, or? >>>>> >>>>> >>>>> -a >>>>> >>>>> >>>>> On 13 March 2014 18:13, Joe Nosay wrote: >>>>> >>>>>> Testing of a patch for using UDP Lite on FreeBSD caused no compilation >>>>>> errors; however, after adding the options of "VIMAGE" and "MROUTING" >>>>>> to >>>>>> conf/kern?GENERIC, make buildkernel stops with: >>>>>> /usr/src/sys/netinet/udp_usrreq.c:1701:18: error: too few arguments >>>>>> to >>>>>> function >>>>>> call, expected 2, have 1 >>>>>> udp_discardcb(up); >>>>>> ~~~~~~~~~~~~~ ^ >>>>>> /usr/src/sys/netinet/udp_usrreq.c:274:1: note: 'udp_discardcb' >>>>>> >>>>> declared here >>>>> >>>>>> void >>>>>> ^ >>>>>> 1 error generated. >>>>>> *** Error code 1 >>>>>> >>>>>> The file in question of >>>>>> /usr/src/sys/netinet/udp_usrreq.c >>>>>> >>>>>> has the value of >>>>>> udp_discardcb(struct udpcb *up, int isudp) >>>>>> >>>>>> that is causing the problem. >>>>>> >>>>>> >>>>>> >>>>>> I believe that the compiler is looking for a value to int isudp but >>>>>> >>>>> that >>>>> >>>>>> value does not exist. >>>>>> _______________________________________________ >>>>>> freebsd-hackers@freebsd.org mailing list >>>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>>>>> To unsubscribe, send any mail to " >>>>>> >>>>> freebsd-hackers-unsubscribe@freebsd.org" >>>>> >>>>> >>>> No, it is 10.0 RELEASE #0 r262601 >>>> >>>> Last time, I had entered too many files. Here are the relative files. >>>> >>>> >>>> There was no problem in compiling as listed earlier. I have not >>>> studied >>>> C enough to solve this problem; however, I can see that int isudp >>>> happens >>>> once while the next closest account is int isudplite. >>>> >>>> >>>> I've just upgraded source to head. I have three patches for UDP Lite. >>> The >>> question is which one(s) should I use. >>> >>> The udp-v.diff only has a reference to udp_discardcb up, while patch >>> udplite and udplite.diff have the struct and int references. >>> >>> >>> Could someone possibly point me towards some online documentation that >> would allow me to learn of a solution to this problem? This would be much >> better because I would be solving and learning. >> >> Included are the three patches mentioned earlier. >> >> Yes, I will be looking at them again. >> >> Apologies for any noise and if I am coming off the wrong way. >> > > Hi Joe, > > As I mentioned, my udp-lite's diff no longer applies cleanly against > -HEAD. I've been busy lately and haven't got time to reply to your > messages. > Give me another day or two to cook up a revised patch for you to test. > Thanks! > > Kevin > Alright.