From owner-p4-projects@FreeBSD.ORG  Sat Jul 15 14:35:11 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2D99216A4E9; Sat, 15 Jul 2006 14:35:11 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 080B816A4E6;
	Sat, 15 Jul 2006 14:35:08 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4FD4243D46;
	Sat, 15 Jul 2006 14:35:08 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.7/8.13.7) with ESMTP id k6FEZ3k0077396
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Sat, 15 Jul 2006 16:35:03 +0200 (CEST)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.7/8.13.3/Submit) id k6FEZ3vH077395;
	Sat, 15 Jul 2006 16:35:03 +0200 (CEST)
Date: Sat, 15 Jul 2006 16:35:03 +0200
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20060715143502.GA77297@stud.fit.vutbr.cz>
References: <200607150905.k6F959IT031112@repoman.freebsd.org>
	<200607151003.28710.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200607151003.28710.jhb@freebsd.org>
User-Agent: Mutt/1.4.2i
X-Scanned-By: MIMEDefang 2.54 on 147.229.10.14
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 101643 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Jul 2006 14:35:11 -0000

On Sat, Jul 15, 2006 at 10:03:28AM -0400, John Baldwin wrote:
> On Saturday 15 July 2006 05:05, Roman Divacky wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=101643
> > 
> > Change 101643 by rdivacky@rdivacky_witten on 2006/07/15 09:04:22
> > 
> > 	Several things at once:
> > 	
> > 	o		Change process_exit and process_exec function handlers prototype
> > 			to include struct image_params arg.
> 
> Why did you add it to process_exit()?  exit() doesn't have an imgp to
> pass, so this doesn't make sense.  If you are doing it so you can use
> the same function for both, then use a wrapper in the exit() case or some
> such.

because most users of process_exec eventhandler use the same function both
for process_exit and process_exec. I didnt know how to solve that otherwise.
in the process_exit case I pass in NULL and I change all the other users to

foo(void *arg, struct proc *p, struct image_params *imgp __unused)

if its not ok tell me how to change that