From owner-freebsd-current Sun Dec 1 15:47:43 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FAEE37B401 for ; Sun, 1 Dec 2002 15:47:42 -0800 (PST) Received: from harrier.mail.pas.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCA4243EBE for ; Sun, 1 Dec 2002 15:47:41 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0208.cvx22-bradley.dialup.earthlink.net ([209.179.198.208] helo=mindspring.com) by harrier.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 18Idnz-0004tS-00; Sun, 01 Dec 2002 15:47:19 -0800 Message-ID: <3DEA9F38.7A1F99C2@mindspring.com> Date: Sun, 01 Dec 2002 15:46:00 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Nate Lawson Cc: Poul-Henning Kamp , Riccardo Torrini , freebsd-current@FreeBSD.ORG Subject: Re: Trivial patch: fdisk doesn't recognize my partitions References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [ ... Partition ID changes ... ] Nate Lawson wrote: > > But as I said, this is rather marginal and I really don't feel > > it should go in unless this xor-0x10 convention is more widespread. > > partition magic does this too. isn't the correct failure mode just to > print the part. id in hex instead of expanding it? Frankly, who cares? You guys still haven't told us, if these partitions are being hidden... WHY ARE WE NOT RESPECTING THE DECISION TO HIDE THE THINGS? A user installed the software doing the hiding on purpose. The software changed the ID hide it, on purpose. Windows ignores these partitions -- on purpose. If you're not going to respect the user's wishes in this, then that's a different kettle of fish... like not respecting the user disabling things in the BIOS, because the probe routines still detect it. If you're going that route, why does FreeBSD care about partition ID at all? All it is is a *hint*; it's not definitive. It's not lika a protocol type encapsulation on a packet. It doesn't matter what the ID says, the rest of the partition table entry demarcates a region of a linear arraw of bytes that contain data. I think looking at the content of that linear array is what should determine what the content is, in the absence of a valid "hint". Specifically, if it has a valid disklabel on the thing, I don't care what partition ID it has on it, I give it to the disklabel handler. If it has a valid FAT32 FS on it, I give it to the FAT32FS. If it has a valid FFS superblock on it, I give it to FFS. Etc.. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message