From owner-svn-src-all@freebsd.org Sat May 5 12:00:56 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 303B0FABDBA; Sat, 5 May 2018 12:00:56 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA1AC7197E; Sat, 5 May 2018 12:00:55 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id C7BDFB8A3; Sat, 5 May 2018 12:00:55 +0000 (UTC) Date: Sat, 5 May 2018 12:00:55 +0000 From: Alexey Dokuchaev To: Bruce Evans Cc: Conrad Meyer , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Brooks Davis , src-committers Subject: Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys Message-ID: <20180505120055.GA81833@FreeBSD.org> References: <201805040400.w4440moH025057@repo.freebsd.org> <20180504155301.GA56280@spindle.one-eyed-alien.net> <20180505090954.X1307@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180505090954.X1307@besplex.bde.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2018 12:00:56 -0000 On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: > ... > Summary: this change wouldn't have passed my review. I have used similar > changes for 15-20 years but never made them production quality since there > are too many variations to consider and testing showed insignificant > improvements except for micro-benchmarks. Perhaps Foundation could sponsor your work to make them production quality Bruce. :-) Seriously though, I'm a bit worried to see these commits happening at the same time correctness of the implementation is still under discussion and disputes. Shall I expect that after my next -CURRENT update things would suddenly stop working? [1] ./danfe [1] https://bugzilla.redhat.com/show_bug.cgi?id=638477