From owner-freebsd-ports@FreeBSD.ORG Mon May 25 08:02:25 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79D05106566B; Mon, 25 May 2009 08:02:25 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: from mail-ew0-f159.google.com (mail-ew0-f159.google.com [209.85.219.159]) by mx1.freebsd.org (Postfix) with ESMTP id AB7398FC19; Mon, 25 May 2009 08:02:24 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: by ewy3 with SMTP id 3so3047847ewy.43 for ; Mon, 25 May 2009 01:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:organization:to:subject :date:user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=zc1u4xEzKiThi3/Zmr1gr6DLhcHpOf760cjo9/kWsVg=; b=AfjnsyVse6y1+icXfgtvbQKwqbFQVGmdswOwvoBb15VfxZ2NPuNIFwnj2Kig0Jlr+E yx6VjcxVwgdusjt4JNvjLx8DY2defa/Ea/qrFqE3zVCaNeDG/4SUXMC3JQ4Twt4JtDRG VU1Dlj0L6OJqoocF1XhCJN9ZLgByk5mHLmSIc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=ZFI1uRWHazWBX6OZZZS8imLOrnFgnEgu0cIDD+eh4WWTlKK+toEhPD0yLrU2tpUBj/ uz0nlW55ynb1ZP2pCKO4pUIc5Mhvjpdq5DWpSbhkl7ChHkXMsbj1NYedcWX5se6YCpRi 7gNqjtT1a7gbemUaWG0JLbtsg5HLDLBKnv9g8= Received: by 10.216.36.80 with SMTP id v58mr1421624wea.193.1243238543795; Mon, 25 May 2009 01:02:23 -0700 (PDT) Received: from ?0.0.0.0? ([196.34.241.123]) by mx.google.com with ESMTPS id 7sm7531366eyg.27.2009.05.25.01.02.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 25 May 2009 01:02:23 -0700 (PDT) From: David Naylor Organization: Private To: "Ion-Mihai Tetcu" Date: Mon, 25 May 2009 10:03:12 +0200 User-Agent: KMail/1.9.10 References: <20090523.182426.193741786.chat95@mac.com> <200905241026.26903.naylor.b.david@gmail.com> <20090524223745.4bbc5420@it.buh.tecnik93.com> In-Reply-To: <20090524223745.4bbc5420@it.buh.tecnik93.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart10027487.IJtn7OL74c"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200905251003.15408.naylor.b.david@gmail.com> Cc: pgollucci@p6m7g8.com, pav@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2009 08:02:25 -0000 --nextPart10027487.IJtn7OL74c Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 24 May 2009 21:37:45 Ion-Mihai Tetcu wrote: > On Sun, 24 May 2009 10:26:23 +0200 > > David Naylor wrote: > > On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote: > > > Hi I tested it yesterday, > > > > > > 1. > > > I need > > > > > > > MAKE_JOBS_SAFE=3D yes > > > > > > in the Makefile. > > > > Yes, you would need that. I believe that will be default. > > > > > 2. with above patch, ooo2 doesn't launch parallele jobs. > > > > I spotted that problem after submitting the patch, if you explicitly > > set MAKE_JOBS_NUMBER to something it will work. > > > > The problem is that ooo2 does (in effect): > > .if (${MAKE_JOBS_NUMBER} > 1) > > # Stuff > > .else > > # Other stuff > > .endif > > and that doesn't work as expected with MAKE_JOBS_NUMBER=3D`sysctl > > kern.smp.cpus` as the command is not resolved. > > w/o patch > editors/openoffice.org-3 openoffice.org-3.1.0 4:53:27 > > with patch: > + MAKE_JOBS_SAFE=3D yes > + MAKE_JOBS_NUMBER=3D 4 > + MAXPROCESSES?=3D ${MAKE_JOBS_NUMBER} > + MAXMODULES?=3D ${MAKE_JOBS_NUMBER} > > editors/openoffice.org-3 openoffice.org-3.1.0 48:51 > > The build is done in > /dev/md0 on /usr/local/tinderbox/7-STABLE-FPT-NPD (ufs, asynchronous, > local, noatime) Wow, that is quite a speedup. Is it even possible (4 * 60 + 53)/4 =3D 73, = and=20 you get 48 (that is 152% scaling efficiency). This would mean a serious=20 performance problem with the ooo3 build script and MAX* =3D1. =20 I'll make a patch tonight (+10 hours) that will fix ooo2 in the default cas= e. =20 You can test ooo2 with patch and MAKE_JOBS_NUMBER preset (not using default= =20 value) and MAKE_JOBS_SAFE=3Dyes. Thanks for testing --nextPart10027487.IJtn7OL74c Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEABECAAYFAkoaUMMACgkQUaaFgP9pFrKO9gCfZO2hddIE/TVXe3nRiDhjmoDC eLEAn3SD6XWh2CCJSUZksLBgyiob+zu+ =G+un -----END PGP SIGNATURE----- --nextPart10027487.IJtn7OL74c--