From owner-dev-commits-src-all@freebsd.org Sun Dec 27 19:09:33 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F9364C3AAE; Sun, 27 Dec 2020 19:09:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D3qx90Yhbz3GM5; Sun, 27 Dec 2020 19:09:32 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf34.google.com with SMTP id 4so4190233qvh.1; Sun, 27 Dec 2020 11:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tcOztCaddb9dlC4Bn9QEV0dqUXPu4j+J8xJ/6Zz2xRA=; b=lgyYZcDGsLHs+nRWEugIgMmS9RoUGxWQtm4bP1Aad+Y3nrlg7KOYkO0rBp1orM+8Lr gFf/RAfm4wrv2urVUkb3mNWGR/GFwwKvdL2USPnxUl2IBsw2GqNjWixMfqDKjnnoUuoe /G7hN4m3SHiBYctbdFe+6BGy25QwSug+FFd6IAcrkzI0xHJU4Djd2nbZCHRLunWaNRpE 8QMB/lH0gejySg60RQe9Q8W+IxelC5sE4oMVB7Nmaui8Fw9hekCkTDftYChkfULK2LzW yWConeCAwJnVUvH1nT5SMemTr0OMN+W3QUDhb6qmmKTJQ11BlR4oTG8BapsavJJLSthF Tj8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=tcOztCaddb9dlC4Bn9QEV0dqUXPu4j+J8xJ/6Zz2xRA=; b=d/n5h7KMny3ASL0orPaZzX1iVI6KRg3JrnQpBFDMYO3GNeqWF0K97JTMJaMTfvOeJG nY+uH5RSvjnAzlXWEvcRvZKr9hGaF/pRiqH6XGWoxvQRcsmDlQI3MOBM+/8A/VZlx8bA LxAWf6RPIirWKacrlCJVm5Vp6cu3P9f+vck5GBByihTZ95IQxnEINiLy5zgVryNBYnM5 QSv/0vKVeAuz0JIEGPJqyjakzgS4Yjj7ultkEdMdHF4LL84mvoCeFpxGA16OsYDrEhkS 9Tqy90snw07pxMC2Yn5OHnOyijWDtoMP/R6oYZWYHwtI+C0tupFvgK8EHRAPgnvIt7xt 4HjQ== X-Gm-Message-State: AOAM5304v5DF8tl35niLXXTg/DB2RdR7cpfsUvxoWbS1SJsoWLZGFuZV Ykg7bHa1gjxhkCDUw+g3RF678dJ+rENO1g== X-Google-Smtp-Source: ABdhPJyHmFhpUr0l0H6UXh85F6rGEQYxVXHXfRYAQe21VB594r1vKbqoGE+4ZmQs5XFeEA/xwCxvGQ== X-Received: by 2002:ad4:4952:: with SMTP id o18mr43802041qvy.27.1609096171854; Sun, 27 Dec 2020 11:09:31 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id q37sm21855879qte.10.2020.12.27.11.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Dec 2020 11:09:31 -0800 (PST) Sender: Mark Johnston Date: Sun, 27 Dec 2020 14:09:29 -0500 From: Mark Johnston To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a1fc1f10c65f - main - Revert "cache: modification and last entry filling support in lockless lookup" Message-ID: References: <202012271904.0BRJ4DWF044873@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202012271904.0BRJ4DWF044873@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4D3qx90Yhbz3GM5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Dec 2020 19:09:33 -0000 On Sun, Dec 27, 2020 at 07:04:13PM +0000, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a1fc1f10c65fe8684d09d2252c19ebb213182b4f > > commit a1fc1f10c65fe8684d09d2252c19ebb213182b4f > Author: Mateusz Guzik > AuthorDate: 2020-12-27 19:02:29 +0000 > Commit: Mateusz Guzik > CommitDate: 2020-12-27 19:02:29 +0000 > > Revert "cache: modification and last entry filling support in lockless lookup" > > This reverts commit 6dbb07ed6872ae7988b9b705e322c94658eba6d1. > > Some ports unreliably fail to build with rmdir getting ENOTEMPTY. I also got this when running the fs/tmpfs/rename_test:dots test panic: Assertion (cnp->cn_flags & ISDOTDOT) != 0 failed at /usr/home/markj/src/freebsd-dev/sys/kern/vfs_cache.c:1663 cpuid = 22 time = 1609095767 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe01aeb764b0 vpanic() at vpanic+0x181/frame 0xfffffe01aeb76500 panic() at panic+0x43/frame 0xfffffe01aeb76560 cache_lookup_dotdot() at cache_lookup_dotdot+0x509/frame 0xfffffe01aeb765d0 vfs_cache_lookup() at vfs_cache_lookup+0x7b/frame 0xfffffe01aeb76620 cache_fplookup_final_modifying() at cache_fplookup_final_modifying+0x1b5/frame 0xfffffe01aeb766a0 cache_fplookup() at cache_fplookup+0x8f2/frame 0xfffffe01aeb767b0 namei() at namei+0x17f/frame 0xfffffe01aeb76870 kern_renameat() at kern_renameat+0x10c/frame 0xfffffe01aeb76ac0 amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe01aeb76bf0 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe01aeb76bf0