Date: Fri, 27 May 2011 11:21:14 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexander Best <arundel@FreeBSD.ORG> Cc: freebsd-hackers@FreeBSD.ORG, freebsd-toolchain@FreeBSD.ORG Subject: Re: [rfc] a few kern.mk and bsd.sys.mk related changes Message-ID: <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> In-Reply-To: <20110527115147.GA73802@freebsd.org> References: <20110527115147.GA73802@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
These look generally good. Just one thing I had a question on: # +# Enable FreeBSD kernel-specific printf format specifiers. Also instruct gcc to +# enable some diagnostics, which make it easier to pinpoint tinderbox failures. +CFLAGS+= -fformat-extensions -fdiagnostics-show-option + Does this put sand in the gears of clang support? Warner On May 27, 2011, at 5:51 AM, Alexander Best wrote: > hi there, > > i would like to hear people's opinion regarding the following patch. it > features the following semantic changes: > > 1) -W is now called -Wextra > 2) move -fformat-extensions and -fdiagnostics-show-option out of CWARNFLAGS, > since they aren't really warnings. this will now let anybody use custom > CWARNFLAGS without having to remember to add -fformat-extensions in order > not to break buildworld. > 3) rearrange "\" characters, as to avoid double spaces > 4) when building kernel modules, -fstack-protector was added to CFLAGS twice. > this should now be solved. > > cheers. > alex > > -- > a13x > <kern.mk-bsy.sys.mk.patch>_______________________________________________ > freebsd-toolchain@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to "freebsd-toolchain-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BF63174-1B29-4A4D-96DD-3ED65ED96EAC>