From owner-svn-ports-all@FreeBSD.ORG Tue Dec 31 10:42:21 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A178840; Tue, 31 Dec 2013 10:42:21 +0000 (UTC) Received: from mail-wg0-x22d.google.com (mail-wg0-x22d.google.com [IPv6:2a00:1450:400c:c00::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DB54316C3; Tue, 31 Dec 2013 10:42:20 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id y10so10969723wgg.12 for ; Tue, 31 Dec 2013 02:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0Axw/4+Ldt2vSa3UgHge5vUABPxEUZyZA9z6QX805xg=; b=ZiZrWlrSSPHQ6DJF2w7PhLJOElO1LqfTKMp+fVr0HEj78kXzHBkkwipQJc9oxpiWbZ k7+9inqxf4hS6uNaBMTD7qVK4f6tbRlwOklpdExjwta1ZxZxk/TyQpvInfpZqhCjUdEq 4MUByghMk5SHZXxLXLsJtFoh7dd7ByDHHgNhOxB0WymFxWksvrinb6qbwuO1MpKOgPUn snR4L+TsTzDOe2cEWOrO0lw/S3rMlLxfJWmdah+ZZ213gqUoSfM3Hz4s0VCQSvM5TmLv nPrPcd6Ekp1KLtqESic5Ah6kp8ZELUIrqMI8TBeSZb4fu2cAb9D2PGyP+ch73p7zBIxq VCNQ== MIME-Version: 1.0 X-Received: by 10.194.219.1 with SMTP id pk1mr49212354wjc.36.1388486539392; Tue, 31 Dec 2013 02:42:19 -0800 (PST) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.194.33.37 with HTTP; Tue, 31 Dec 2013 02:42:19 -0800 (PST) In-Reply-To: <9085f71d-db56-4f8d-9911-461c7a87d47c@email.android.com> References: <201312252329.rBPNTY87062947@svn.freebsd.org> <9085f71d-db56-4f8d-9911-461c7a87d47c@email.android.com> Date: Tue, 31 Dec 2013 11:42:19 +0100 X-Google-Sender-Auth: 2_zZ7Un4SNuSxjdvhSoVLNzRKYs Message-ID: Subject: Re: svn commit: r337464 - in head: audio/alure audio/fpc-openal audio/freealut audio/hs-ALUT audio/hs-OpenAL audio/py-al audio/py-openal deskutils/xneur devel/allegro-devel devel/love devel/love07 deve... From: Antoine Brodin To: Gerald Pfeifer Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2013 10:42:21 -0000 On Tue, Dec 31, 2013 at 11:22 AM, Gerald Pfeifer wrote: > Antoine Brodin wrote: >>Log: >> Convert the tree to USES=openal >> >> Approved by: portmgr (bapt) > >>Modified: head/emulators/wine-devel/Makefile >>============================================================================== >>--- head/emulators/wine-devel/Makefile Wed Dec 25 23:24:54 >>2013 (r337463) >>+++ head/emulators/wine-devel/Makefile Wed Dec 25 23:29:34 >>2013 (r337464) >>@@ -53,6 +53,9 @@ WINEMAKER_DESC= Fully support winemaker >> GECKO_DESC= Bundle Gecko MSI package for Wine >> MONO_DESC= Bundle Mono MSI package for Wine >> >>+# USES needs to be before bsd.port.pre.mk >>+OPENAL_USES= openal >>+ >> PORTDATA= l_intl.nls wine.inf >> >> .include >>@@ -98,7 +101,6 @@ CONFIGURE_ARGS+= --without-xslt >> >> .if ${PORT_OPTIONS:MOPENAL} >> CONFIGURE_ARGS+= --with-openal >>-USE_OPENAL= yes >> .else >> CONFIGURE_ARGS+= --without-openal >> .endif >> >>Modified: head/emulators/wine/Makefile >>============================================================================== >>--- head/emulators/wine/Makefile Wed Dec 25 23:24:54 2013 (r337463) >>+++ head/emulators/wine/Makefile Wed Dec 25 23:29:34 2013 (r337464) >>@@ -58,6 +58,9 @@ WINEMAKER_DESC= Fully support winemaker >> GECKO_DESC= Bundle Gecko MSI package for Wine >> MONO_DESC= Bundle Mono MSI package for Wine >> >>+# USES needs to be before bsd.port.pre.mk >>+OPENAL_USES= openal >>+ >> PORTDATA= fonts/ generic.ppd l_intl.nls wine.inf >> >> PORTSCOUT= limitw:1,even >>@@ -105,7 +108,6 @@ CONFIGURE_ARGS+= --without-xslt >> >> .if ${PORT_OPTIONS:MOPENAL} >> CONFIGURE_ARGS+= --with-openal >>-USE_OPENAL= yes >> PLIST_SUB+= OPENAL="" >> .else >> CONFIGURE_ARGS+= --without-openal > > Per my earlier mail I am pretty hampered accessing FreeBSD code right now, but...is this really right? > Pulling in OpenAL unconditionally for these two ports looks strange to me; definitely not intuitive. Hello, OPENAL_USES= openal means that the ports USES= openal when the OPENAL option is selected. Cheers, Antoine