Date: Sat, 06 Mar 2021 10:07:03 +0100 From: "Kristof Provost" <kp@FreeBSD.org> To: "Mark Johnston" <markj@freebsd.org> Cc: "Ryan Moeller" <freqlabs@freebsd.org>, "Konstantin Belousov" <kostikbel@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c4ba4aa54718 - main - libifconfig: Overhaul ifconfig_media_* interfaces Message-ID: <E6BF3962-D9A7-4CF1-A711-E1A46510B452@FreeBSD.org> In-Reply-To: <YEKKMo3eZzSkGcEh@nuc> References: <202103051123.125BNubR059014@gitrepo.freebsd.org> <YEJ2JRhRgMU1I39f@kib.kiev.ua> <20c6efb4-8b57-ae78-3808-b49b07ac284d@FreeBSD.org> <YEKKMo3eZzSkGcEh@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 Mar 2021, at 20:44, Mark Johnston wrote: > On Fri, Mar 05, 2021 at 02:40:29PM -0500, Ryan Moeller wrote: >> >> On 3/5/21 1:19 PM, Konstantin Belousov wrote: >>> On Fri, Mar 05, 2021 at 11:23:56AM +0000, Ryan Moeller wrote: >>>> The branch main has been updated by freqlabs: >>>> >>>> URL: = >>>> https://cgit.FreeBSD.org/src/commit/?id=3Dc4ba4aa547184ab401204096cd= ad9def4ab37964 >>>> >>>> commit c4ba4aa547184ab401204096cdad9def4ab37964 >>>> Author: Ryan Moeller <freqlabs@FreeBSD.org> >>>> AuthorDate: 2021-03-02 10:29:17 +0000 >>>> Commit: Ryan Moeller <freqlabs@FreeBSD.org> >>>> CommitDate: 2021-03-05 09:15:55 +0000 >>>> >>>> libifconfig: Overhaul ifconfig_media_* interfaces >>>> >>>> Define an ifmedia_t type to use for ifmedia words. >>>> >>>> Add ifconfig_media_lookup_* functions to lookup ifmedia words = >>>> by name. >>>> >>>> Get media options as an array of option names rather than = >>>> formatting it >>>> as a comma-delimited list into a buffer. >>>> >>>> Sprinkle const on static the static description tables for = >>>> peace of >>>> mind. >>>> >>>> Don't need to zero memory allocated by calloc. >>>> >>>> Reviewed by: kp >>>> MFC after: 2 weeks >>>> Differential Revision: https://reviews.freebsd.org/D29029 >>>> --- >>>> lib/libifconfig/Makefile | 2 +- >>>> lib/libifconfig/Symbol.map | 9 +- >>>> lib/libifconfig/libifconfig.h | 69 +++++++- >>>> lib/libifconfig/libifconfig_media.c | 339 = >>>> ++++++++++++++++++++++++------------ >>>> share/examples/libifconfig/status.c | 27 ++- >>>> 5 files changed, 324 insertions(+), 122 deletions(-) >>>> >>>> diff --git a/lib/libifconfig/Makefile b/lib/libifconfig/Makefile >>>> index 73dad36c1dc5..c6f006018427 100644 >>>> --- a/lib/libifconfig/Makefile >>>> +++ b/lib/libifconfig/Makefile >>>> @@ -7,7 +7,7 @@ INTERNALLIB=3D true >>>> LIBADD=3D m >>>> >>>> SHLIBDIR?=3D /lib >>>> -SHLIB_MAJOR=3D 1 >>>> +SHLIB_MAJOR=3D 2 >>>> >>>> VERSION_DEF=3D ${LIBCSRCDIR}/Versions.def >>>> SYMBOL_MAPS=3D ${.CURDIR}/Symbol.map >>> libifconfig is marked as internal, but we provide symbol versioning = >>> for it, >>> and do it in the normal FreeBSD namespace. On one hand, our policy = >>> is to >>> not bump symvered libs and to provide binary compat shims as needed, = >>> on the >>> other, this is internal lib. >>> >>> What is the purpose of maintaining symbol versions for it? >> >> >> I have work in progress that changes libifconfig to a private lib. = >> I'm >> not sure why markj@ added the symbol map, but I've been forced to >> maintain it for my later changes to work. > > I added it because there was some discussion of making it a public > library, and adding a symbol map was a step towards that. If it is = > only > going to be a private library, then there's indeed no reason to = > maintain > it. Historically it=E2=80=99s been the aspiration (passive voice, because whi= le = these have been my hopes I=E2=80=99ve not done any of the work) to make t= his a = public library, so e.g. appliance vendors could have a better way to = configure the system than doing `system(=E2=80=9Cifconfig em0 = 10.0.0.1/24=E2=80=9D);`. Libifconfig is making progress thanks to Ryan=E2=80=99s work, but it=E2=80= =99s not = yet ready for that sort of use. Given that, it makes sense to keep it as an internal library for now, = and breaking the API is fine. I still hope that we=E2=80=99ll get it to t= he = point where it=E2=80=99ll be ready for public consumption (with stable AP= I). So I think the symbol map is mostly aspirational right now. If it=E2=80=99= s a = maintenance burden I guess we can remove it, and re-add it when the time = comes. Best regards, Kristof From owner-dev-commits-src-main@freebsd.org Sat Mar 6 09:43:43 2021 Return-Path: <owner-dev-commits-src-main@freebsd.org> Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D336E55FAA4 for <dev-commits-src-main@mailman.nyi.freebsd.org>; Sat, 6 Mar 2021 09:43:43 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-56.consmr.mail.ne1.yahoo.com (sonic307-56.consmr.mail.ne1.yahoo.com [66.163.190.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dt06R0HmZz3P3D for <dev-commits-src-main@freebsd.org>; Sat, 6 Mar 2021 09:43:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1615023821; bh=oDv7gzsEjcxL4P06xyhlKeqLJIRdnsMz+BGN+z1MZZT=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=MZsbJQwx2tpQm5tExdaCVdLKmwCrbpLnzOLW+Rk0GRlmzEGDHs3truw/uMJ8Vz2bLIVOrCmqSQyuJjzqsRgI2NNVHQzq9oz4asILdVZv+BPhqWr6G4tMrRT6/HVdsvDU8866OrVMQPgdQhfbeKXDUt+DAwdm8ym2IjuSYQsP8CzvfzrGBblph2s4zdWA13/FZ/1s6JB5h3bt9fg3ZIN92RjLJ0PjgKNamlW+EU9X3Vc05unaMEqIayuY7sGqTna7IleEhpOekizhieJOWz1ZBE1AdTQdIEGuY3LDhO5APzvCk3ZJvGBjOT3+DG+xVWs8lbX1YiDReP20bVpGZgZC5w== X-YMail-OSG: Sc0pUNIVM1ntbZCHpl6g0BhwG.BpNHsNHbiA7W90ZnRuM_YNCywFmnnvC9dOZ.0 4975EomPW40ka0tXo0N_CxB3mcvsTL2ci1ljdEoOyA.wR15zm149Kw.g3Js33dfiFPMwHKm98JK1 Tr5zY.NHdz79CrfwPgGwuVQa0z02ftnG4_R34KLOOEthY9WTY2iNh_vTdlZl_.ThBG.mgozZYWfX ofkWDrw0lz8oXHgiHm6Ee2IYaPCmw7ZC.ShQjtfYK7ks_.RD87KYme8c2ThPKf3_UeEz0HJTKk6v VZ2dSV1lvQvQBlTIiouke5QMhk_08lGsZoZKAtbJoSRkixib9oph30wMvHM9XKlS80_cXvnEzNKJ tyZDQdHtM35AVLAwRr3zGDSMnuj5ntIEW6q9YZmVOCHBdb.3aSeITMDyVknHwx9ueQ9vl_BSmwdO nQ.sqYCiEfXUXZuD5n2XdtvYqCFh7dtL9PavdVvu6KpUMPgNGNRwuomyl4InhoFma0Y1MVy.pE4H Isq8GgqVE9KqeYrNRTyj2xNIgZa7HsPHGfCtJLoAv7iBW1tl.fX7hJ2.GrVVfuEU0kPILAfuqWl6 OGcg0CTIKvXJEu1aSCPIhn3dFgLhioxVz4wOS4fIwhQ50xeaIlurAPUFzQEpZJ1nTh4XG0aV_PJK .WWasZRUOJrb1NgRuTOcremujQZVIbhghwjwjRgkFoOXHJOBnJvgSuDbQEYhYSRKfabulZ17eBag I1P9M.B_7_T.TZ4n.7pq0w2WO19Q7JM25TeIFKe97lSHitxRinoXA7RHws8K1bDYdQm6LJUpv.WR 54U1Qm4KcSZWDPhhVwnvpOmiQ4r.EaLJ_nG8ZxyzFGYFsv3Ps5SqieoSiF71iqGxh251XJXXiWsS hpVhkjFWo.b.12girOvD6tfG9TqFbqpqegA9CoEKGJWWrgEndd64OLTY2CV9yi1mRlGoF0u.WzSb xE590eYUS4nZocLwaiskvaW5POMuNf2YoW6d6SqMIKutdbHnPsEliiyQSIwc_.OF4oAtR41zVpRU Tf_uqVZ6IZf1Iah3fpzZIhea0_3BnCxknvYREKSQ88pAn8dAumDVYuPm0J1c7Sme22cBozCeMgM3 T.mv.k.eF49_hj7ii9vMiMJ.77eerq3Jb.ic61OQgJDPFxZL1bo8Y2NkINBzbEStC6.G.WAJVc5u 6i52G4wFga6OnqZDvKOMnH0GyBKUq_4QjERx_E1UyQkzH5yvEm3ozDtreU5V30Z3t6SmXiaOjMX9 Jno4PoG_9LZ80AJm37l0xNI6k4k2w6v.TswCIX9CyYCj8njmXUmzIWQR2Wnvpt.._bTtRGAcvcMb ZstWQrS3iZTpk2VuiDSXjR9tiQmqlGGMUOQHRG5FSfK6ON6prODXAlzYJRcFpj23STjhGGlPNnoC 6eIMY99BtdPY4yPnf6kqtViPUmHj8kwNoC0EdtQ.7o2Hc5R47ZTu4VG4JfFw42f7IaL68mpemSM9 3xgXcuWvnSwAJPH01K.V3bR2eX9o5X2xI28YhaZdru9emQBbgR9bknZX2LE13ASx93uAklzZzZHZ zs0eUjL5Ic1Dllo5iZLykndioMR9owYjXS41EfLbX9.YUTgqRWaefjWVn0_w0Pk_3Rl8fPHCBPpY r2KjayqjHpwVy5TRXAH5qR.IObxhrEoAGk1jGGARRJW7atyb0z8u071sX7SZI0sJQ_vdHeJxVsR8 SEH4hBRsy.sYQfauWcFJtdARJzsKJwtDIYTdbC_fkgeJpNbg_rb1dCY7z1kdY6w0oqH1FsaLZDT0 bwjjBAioUGF01W6Qfcvlt2jZH7tVqTMAz1trezxEkgTI.D3gWV1NS7l_LdtI12VGU5SOi5xJfbYp Z9.lqWDGiMzgEYoObXysRbQa7kfj6UiAkYR8uVqw_Ima0_MzF9aPY5X5KWAiA7dkrubzrpCnr9p. .5m9PTaFbDESJkcHZ1EHQ.u8bPtgj.z1usm5kWwuk7iTiZ1py2x2Bx3LHUhTirn8gWIRUYC5MoFc 475SzN1r2vA11lS1RDx5t2m_Cgg8EA5d9dU1aBYlrkCIICY9eMnJLwrd7daUrXA2tZ_fLtX71L.K cAruG_lOhXbL8chbrB8s1EGPT4s4vxHKhEvmziP.Na6RMZZcLq6O5lF1U7JzPSmEQEgJ2rWa4yWm FxZ.8Q7KybtQXYOqWa2Dzz6F_tUzEbtSrekgF0jGlNrnkAH6YMWIKIJeZHAuGGoCrvkrBZk01SO5 GfeRwjCn.tqf4tzX7A5Pa8GKidN2bDnHY_7FZwdVePYGQMQ8j20RQ2O8bqEjM2b98UVQgkH_cjLo xYKHQhJ5DWYfBH5zoTOqrTkAMcubdmz.N0MEWHAbsHS4q5YLz0h2ZVAvKStstaOHLNojGvgqBeFJ hQWmpIKLhmYBaYKjoAW0_rqXvJbgcjqq2F1NY.KSSXMde6Xko5dGLhfJrH6UASUbX6FvO_NmS8R3 MKoWofUEhTKaSxfteUS_qeouNrQ-- X-Sonic-MF: <marklmi@yahoo.com> Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sat, 6 Mar 2021 09:43:41 +0000 Received: by smtp417.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 5350d91e4caf86c5e1dd2aa690b4d116; Sat, 06 Mar 2021 09:43:38 +0000 (UTC) From: Mark Millard <marklmi@yahoo.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: e77cf2a4ab32 - main - Restore /boot/efi to mtree. Date: Sat, 6 Mar 2021 01:43:36 -0800 References: <656E3D05-11B6-437B-B171-4894811A70CB@yahoo.com> <A63777FD-23F5-4B06-91D6-F1D137E26D2A@yahoo.com> To: "nwhitehorn@freebsd.org" <nwhitehorn@FreeBSD.org>, dev-commits-src-main@freebsd.org In-Reply-To: <A63777FD-23F5-4B06-91D6-F1D137E26D2A@yahoo.com> Message-Id: <BD96BDE6-DD92-4A1F-B8E4-1D83DF4285F8@yahoo.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4Dt06R0HmZz3P3D X-Spamd-Bar: - X-Spamd-Result: default: False [-1.53 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[66.163.190.31:from]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36646, ipnet:66.163.184.0/21, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; NEURAL_SPAM_SHORT(0.97)[0.969]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_ZRD(0.00)[66.163.190.31:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[66.163.190.31:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[66.163.190.31:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>; List-Post: <mailto:dev-commits-src-main@freebsd.org> List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 06 Mar 2021 09:43:43 -0000 On 2021-Mar-6, at 01:01, Mark Millard <marklmi at yahoo.com> wrote: > On 2021-Mar-5, at 22:05, Mark Millard <marklmi at yahoo.com> wrote: >>=20 >> Nathan Whitehorn nwhitehorn at FreeBSD.org wrote on >> Sat Mar 6 02:01:30 UTC 2021 : >>=20 >>> Restore /boot/efi to mtree. >>>=20 >>> Instead of whether /boot/efi exists, which it now always does, = including >>> on systems that don't and can't use EFI, use whether /boot/efi is >>> present in fstab to signal to the installer that it is a valid ESP = and >>> should be configured. This has essentially the same semantics, but = allows >>> /boot/efi to be created unconditionally. >>>=20 >>=20 >> Sounds like the documentation about /etc/fstab content >> should indicate the special/reserved /boot/efi usage >> context, be that comments in initial default files or >> whatever. >>=20 >> I wonder if anyone puts / at the end in an fstab: /boot/efi/=20 >>=20 >=20 > I tried using a trailing / in /etc/fstab and it is > one place were the notational variation is not > equivalent: I had to remove it. >=20 FYI: Reviewing/adjusting my /etc/fstab files I notice that I have examples with things like: /dev/label/Rock64boot /boot/efi msdosfs rw,noatime,noauto = 0 0 #/dev/msdosfs/RPI4EFIFS /boot/efi msdosfs rw,noatime,noauto = 0 0 Some might have a space after the #, shifting the /boot/efi to be at $3 ? Some /etc/fstab files have both types of /boot/efi lines (commented vs. uncommented), associated with root-file-system-media that I move between machines sometimes and toggle what is commented (changing what media ends up referenced). =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E6BF3962-D9A7-4CF1-A711-E1A46510B452>