From owner-freebsd-ports Fri Nov 3 10:10:55 2000 Delivered-To: freebsd-ports@freebsd.org Received: from indigo.external.org (c1118643-c.chmpgn1.il.home.com [24.181.135.89]) by hub.freebsd.org (Postfix) with ESMTP id 0120637B479 for ; Fri, 3 Nov 2000 10:10:49 -0800 (PST) Received: (from jeremy@localhost) by indigo.external.org (8.9.3/8.9.3) id MAA50862; Fri, 3 Nov 2000 12:10:39 -0600 (CST) (envelope-from jeremy) Date: Fri, 3 Nov 2000 12:10:38 -0600 From: Jeremy Shaffner To: roman@xpert.com, ports@freebsd.org Subject: Re: ports/22320: NEW PORT: audio/id3lib Message-ID: <20001103121038.A50430@external.org> References: <200010262235.e9QMZc483382@alchemy.oven.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <200010262235.e9QMZc483382@alchemy.oven.org>; from roman@xpert.com on Fri, Oct 27, 2000 at 12:35:38AM +0200 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Dern, beat me to it. (And to musicbrainz and freeamp as well.) I suggest the following changes to this Port. The configure patch as provided fixes a bug created by the original configure.in which itself has a bug. It was fixed in CVS, but there has not been a new release yet. patch-aa should patch configure.in instead as follows: --- configure.in.orig Wed Oct 25 03:42:00 2000 +++ configure.in Wed Oct 25 03:42:08 2000 @@ -143,7 +143,7 @@ ) AC_LANG_SAVE AC_LANG_CPLUSPLUS -AC_CHECK_HEADER(iostream.h iomanip.h) +AC_CHECK_HEADERS(iostream.h iomanip.h) dnl Check for functions. AC_FUNC_MEMCMP And add USE_AUTOMAKE=YES to the Port's Makefile (implying USE_AUTOCONF) so a new, bugless configure is generated. On Fri, Oct 27, 2000 at 12:35:38AM +0200, roman@xpert.com wrote: > > >Number: 22320 > >Category: ports > >Synopsis: NEW PORT: audio/id3lib, library for manipulating id3 v1/v2 tags > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-ports > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: change-request > >Submitter-Id: current-users > >Arrival-Date: Thu Oct 26 15:40:01 PDT 2000 > >Closed-Date: > >Last-Modified: > >Originator: Roman Shterenzon > >Release: FreeBSD 4.1.1-STABLE i386 > >Organization: > >Environment: > > > >Description: > > Note: This library is needed for the FreeAmp port that follows. > > id3lib is a software library for manipulating ID3v1/v1.1 and ID3v2 tags. > id3lib 3.0.x conforms to all ID3v2 standards up to and including the ID3v2.3.0 > informal standard. > > WWW: http://id3lib.sourceforge.net/ > > > >How-To-Repeat: > > > >Fix: > > # This is a shell archive. Save it in a file, remove anything before > # this line, and then unpack it by entering "sh file". Note, it may > # create directories; files and directories will be owned by you and > # have default permissions. > # > # This archive contains: > # > # id3lib > # id3lib/Makefile > # id3lib/pkg-descr > # id3lib/pkg-comment > # id3lib/pkg-plist > # id3lib/distinfo > # id3lib/files > # id3lib/files/patch-aa > # > echo c - id3lib > mkdir -p id3lib > /dev/null 2>&1 > echo x - id3lib/Makefile > sed 's/^X//' >id3lib/Makefile << 'END-of-id3lib/Makefile' > X# New ports collection makefile for: id3lib > X# Date Created: 26 Oct 2000 > X# Whom: Roman Shterenzon > X# > X# $FreeBSD$ > X# > X > XPORTNAME= id3lib > XPORTVERSION= 3.7.13 > XCATEGORIES= audio > XMASTER_SITES= ${MASTER_SITE_SOURCEFORGE} > XMASTER_SITE_SUBDIR= ${PORTNAME} > X > XMAINTAINER= roman@xpert.com > X > XLIB_DEPENDS= popt.0:${PORTSDIR}/devel/popt > X > XINSTALLS_SHLIB= yes > XGNU_CONFIGURE= yes > XCONFIGURE_ENV= LDFLAGS="-L${PREFIX}/lib" CPPFLAGS="-I${PREFIX}/include" > X > Xpost-extract: > X.for i in zlib popt > X ${RM} -rf ${WRKSRC}/$i > X.endfor > X > X.include > END-of-id3lib/Makefile > echo x - id3lib/pkg-descr > sed 's/^X//' >id3lib/pkg-descr << 'END-of-id3lib/pkg-descr' > Xid3lib is a software library for manipulating ID3v1/v1.1 and ID3v2 tags. > Xid3lib 3.0.x conforms to all ID3v2 standards up to and including the ID3v2.3.0 > Xinformal standard. > X > XWWW: http://id3lib.sourceforge.net/ > X > XRoman Shterenzon > END-of-id3lib/pkg-descr > echo x - id3lib/pkg-comment > sed 's/^X//' >id3lib/pkg-comment << 'END-of-id3lib/pkg-comment' > XLibrary for manipulating ID3v1/v1.1 and ID3v2 tags > END-of-id3lib/pkg-comment > echo x - id3lib/pkg-plist > sed 's/^X//' >id3lib/pkg-plist << 'END-of-id3lib/pkg-plist' > Xbin/id3info > Xbin/id3convert > Xbin/id3tag > Xbin/id3cp > Xinclude/id3/error.h > Xinclude/id3/field.h > Xinclude/id3/flags.h > Xinclude/id3/frame.h > Xinclude/id3/globals.h > Xinclude/id3/header.h > Xinclude/id3/header_frame.h > Xinclude/id3/header_tag.h > Xinclude/id3/misc_support.h > Xinclude/id3/sized_types.h > Xinclude/id3/spec.h > Xinclude/id3/tag.h > Xinclude/id3.h > Xlib/libid3-3.7.so.13 > Xlib/libid3-3.7.so > Xlib/libid3.so > Xlib/libid3.la > Xlib/libid3.a > X@dirrm include/id3 > END-of-id3lib/pkg-plist > echo x - id3lib/distinfo > sed 's/^X//' >id3lib/distinfo << 'END-of-id3lib/distinfo' > XMD5 (id3lib-3.7.13.tar.gz) = 19ab352ac8d522ebcabb85f2445bfced > END-of-id3lib/distinfo > echo c - id3lib/files > mkdir -p id3lib/files > /dev/null 2>&1 > echo x - id3lib/files/patch-aa > sed 's/^X//' >id3lib/files/patch-aa << 'END-of-id3lib/files/patch-aa' > X--- configure.orig Fri Sep 15 03:14:06 2000 > X+++ configure Thu Oct 26 03:26:10 2000 > X@@ -2200,7 +2200,7 @@ > X > X fi > X > X-for ac_hdr in zlib.h wchar.h sys/param.h popt.h > X+for ac_hdr in zlib.h sys/param.h popt.h > X do > X ac_safe=`echo "$ac_hdr" | sed 'y%./+-%__p_%'` > X echo $ac_n "checking for $ac_hdr""... $ac_c" 1>&6 > X@@ -2296,16 +2296,18 @@ > X ac_link='${CXX-g++} -o conftest${ac_exeext} $CXXFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS 1>&5' > X cross_compiling=$ac_cv_prog_cxx_cross > X > X-ac_safe=`echo "iostream.h iomanip.h" | sed 'y%./+-%__p_%'` > X-echo $ac_n "checking for iostream.h iomanip.h""... $ac_c" 1>&6 > X-echo "configure:2302: checking for iostream.h iomanip.h" >&5 > X+for ac_hdr in iostream.h iomanip.h > X+do > X+ac_safe=`echo "$ac_hdr" | sed 'y%./+-%__p_%'` > X+echo $ac_n "checking for $ac_hdr""... $ac_c" 1>&6 > X+echo "configure:2302: checking for $ac_hdr" >&5 > X if eval "test \"`echo '$''{'ac_cv_header_$ac_safe'+set}'`\" = set"; then > X echo $ac_n "(cached) $ac_c" 1>&6 > X else > X cat > conftest.$ac_ext < X #line 2307 "configure" > X #include "confdefs.h" > X-#include > X+#include <$ac_hdr> > X EOF > X ac_try="$ac_cpp conftest.$ac_ext >/dev/null 2>conftest.out" > X { (eval echo configure:2312: \"$ac_try\") 1>&5; (eval $ac_try) 2>&5; } > X@@ -2328,7 +2330,7 @@ > X else > X echo "$ac_t""no" 1>&6 > X fi > X- > X+done > X > X echo $ac_n "checking for 8-bit clean memcmp""... $ac_c" 1>&6 > X echo "configure:2335: checking for 8-bit clean memcmp" >&5 > END-of-id3lib/files/patch-aa > exit > > > >Release-Note: > >Audit-Trail: > >Unformatted: > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-ports" in the body of the message -- --------------------------------------------------------------------- Jeremy Shaffner | This space for rent. jeremy@external.org | $ grep happiness life http://www.external.org/~jeremy/pgp.key | FreeBSD: The Power to Serve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message