From owner-cvs-ports@FreeBSD.ORG Sat Feb 21 11:29:48 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2329616A4CF; Sat, 21 Feb 2004 11:29:48 -0800 (PST) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 10EC843D1F; Sat, 21 Feb 2004 11:29:48 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (6bb088a6f7d64b56f83d3971f5352298@adsl-63-207-60-37.dsl.lsan03.pacbell.net [63.207.60.37]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i1LJTlwK024899; Sat, 21 Feb 2004 11:29:47 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id D774166CAF; Sat, 21 Feb 2004 11:29:46 -0800 (PST) Date: Sat, 21 Feb 2004 11:29:46 -0800 From: Kris Kennaway To: Martin Blapp Message-ID: <20040221192946.GA50771@xor.obsecurity.org> References: <200402211024.i1LAOY5b040766@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <200402211024.i1LAOY5b040766@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/editors/openoffice-1.1/files patch-config_office X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2004 19:29:48 -0000 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 21, 2004 at 02:24:34AM -0800, Martin Blapp wrote: > mbr 2004/02/21 02:24:34 PST >=20 > FreeBSD ports repository >=20 > Modified files: > editors/openoffice-1.1/files patch-config_office=20 > Log: > Adjust PTHREAD_CFLAGS and THREAD_CFLAGS for ports and standalone > builds. Use the correct values according to bsd.port.mk. ITYM "Current default values". Why can't you just pass in the actual variables to the build instead of copying the default assignments from bsd.port.mk? This does not allow people to override the thread library at compile-time, and does not allow for future change. Kris --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAN7GqWry0BWjoQKURAot4AJsEP8TVmQO/UDNTwgaLA4iBAPGn/QCfdhZb yQotitBhDKNASrf5uzp5H3A= =cYRh -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--