Date: Mon, 6 Apr 2015 10:40:57 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: d@delphij.net Cc: freebsd-net@freebsd.org, re <re@freebsd.org> Subject: Re: Bring "netstat -R" to stable10 Message-ID: <20150406174057.GC96049@strugglingcoder.info> In-Reply-To: <5522B5FD.5040308@delphij.net> References: <20150402205307.GA72165@strugglingcoder.info> <20150406162015.GB96049@strugglingcoder.info> <5522B5FD.5040308@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 04/06/15 at 09:36P, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On 04/06/15 09:20, hiren panchasara wrote: > > On 04/02/15 at 01:53P, hiren panchasara wrote: > >> I want to use netstat -R on stable10 and following 2 commits are > >> needed to be MFC'd for that: > >> https://svnweb.freebsd.org/base?view=revision&revision=266418 > >> https://svnweb.freebsd.org/base?view=revision&revision=266448 > >> > >> r266418 adds a field to 'struct inpcb' but it uses a spare field > >> so I _think_ it's MFCable and doesn't break KBI/KPI? > >> > >> Can someone please comment if that's not the case? > > > > I'll go commit this today. > > I think you should have asked re@ or this may get otherwise unnoticed... My bad. That didn't occur to me. > > I was kinda surprised with the fact that the spare fields are defined > as 'uint' and not something like 'u_int32_t' because the former is > less defined. We should probably use u_int32_t instead for the spare > fields to avoid the ambiguity. Yeah, that'd be a separate change. > > However, because all platforms that FreeBSD currently supports have > 32-bit int (doing a quick grep of __UINT_MAX), I think the change does > not break KBI. The added field does not break KPI. Ok, I'll commit to 10 as is. Appreciate you chiming in. Cheers, Hiren [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVIsUoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/loOUH/2RDPcEujem9m/QSzneGlDvL aDWYCU62gzU1Q0XfYN3oISwERDAuoDN4nhNWpNzO+ltUvEUebWDMv/eLEq/BA+3X 2s6thrNrynIHNTkIc8JthwELVsl9e5K+4DzOR6QSG1F7gaAksKDZq5ayxH9Eqsh6 ZrxzzSO+JO4GuX9oK3Gr8uR3TlnfFlhBEbdZOHZz5EOt11ttQhs8Vd/hddXq9wsE KGDbf8vIVup+1ziOFD3qparMYeC1IqBd2lHmM8RvUMN7DhZiwGbwnbZxD0l2rqsV YN0KafFHSfpxhORBwLJxpxUbhJWZZKkuS6Zx7wcV57HkBpMVrJ4pnaKrr7MXXTM= =Kv4Q -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150406174057.GC96049>