From owner-freebsd-net@FreeBSD.ORG Mon Apr 6 17:40:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D50B1BD4; Mon, 6 Apr 2015 17:40:59 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE77A9EA; Mon, 6 Apr 2015 17:40:59 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id 8E9D610C96C; Mon, 6 Apr 2015 10:40:57 -0700 (PDT) Date: Mon, 6 Apr 2015 10:40:57 -0700 From: hiren panchasara To: d@delphij.net Subject: Re: Bring "netstat -R" to stable10 Message-ID: <20150406174057.GC96049@strugglingcoder.info> References: <20150402205307.GA72165@strugglingcoder.info> <20150406162015.GB96049@strugglingcoder.info> <5522B5FD.5040308@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V4b9U9vrdWczvw78" Content-Disposition: inline In-Reply-To: <5522B5FD.5040308@delphij.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-net@freebsd.org, re X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2015 17:40:59 -0000 --V4b9U9vrdWczvw78 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/06/15 at 09:36P, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 >=20 > On 04/06/15 09:20, hiren panchasara wrote: > > On 04/02/15 at 01:53P, hiren panchasara wrote: > >> I want to use netstat -R on stable10 and following 2 commits are > >> needed to be MFC'd for that:=20 > >> https://svnweb.freebsd.org/base?view=3Drevision&revision=3D266418=20 > >> https://svnweb.freebsd.org/base?view=3Drevision&revision=3D266448 > >>=20 > >> r266418 adds a field to 'struct inpcb' but it uses a spare field > >> so I _think_ it's MFCable and doesn't break KBI/KPI? > >>=20 > >> Can someone please comment if that's not the case? > >=20 > > I'll go commit this today. >=20 > I think you should have asked re@ or this may get otherwise unnoticed... My bad. That didn't occur to me. >=20 > I was kinda surprised with the fact that the spare fields are defined > as 'uint' and not something like 'u_int32_t' because the former is > less defined. We should probably use u_int32_t instead for the spare > fields to avoid the ambiguity. Yeah, that'd be a separate change.=20 >=20 > However, because all platforms that FreeBSD currently supports have > 32-bit int (doing a quick grep of __UINT_MAX), I think the change does > not break KBI. The added field does not break KPI. Ok, I'll commit to 10 as is. Appreciate you chiming in. Cheers, Hiren --V4b9U9vrdWczvw78 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVIsUoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/loOUH/2RDPcEujem9m/QSzneGlDvL aDWYCU62gzU1Q0XfYN3oISwERDAuoDN4nhNWpNzO+ltUvEUebWDMv/eLEq/BA+3X 2s6thrNrynIHNTkIc8JthwELVsl9e5K+4DzOR6QSG1F7gaAksKDZq5ayxH9Eqsh6 ZrxzzSO+JO4GuX9oK3Gr8uR3TlnfFlhBEbdZOHZz5EOt11ttQhs8Vd/hddXq9wsE KGDbf8vIVup+1ziOFD3qparMYeC1IqBd2lHmM8RvUMN7DhZiwGbwnbZxD0l2rqsV YN0KafFHSfpxhORBwLJxpxUbhJWZZKkuS6Zx7wcV57HkBpMVrJ4pnaKrr7MXXTM= =Kv4Q -----END PGP SIGNATURE----- --V4b9U9vrdWczvw78--