From owner-freebsd-ports@freebsd.org Thu May 17 22:54:37 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB957EE2A90 for ; Thu, 17 May 2018 22:54:36 +0000 (UTC) (envelope-from john@saltant.com) Received: from twaddle.saltant.net (twaddle.saltant.net [72.78.188.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5D8C47A64D; Thu, 17 May 2018 22:54:36 +0000 (UTC) (envelope-from john@saltant.com) Received: from statler.priv.n.saltant.net (unknown [IPv6:2001:470:8d6f:0:e846:d746:756a:3b9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by twaddle.saltant.net (Postfix) with ESMTPSA id 24617111EC; Thu, 17 May 2018 18:54:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=saltant.com; s=twaddle; t=1526597670; bh=Nx28v+CVxSxXFZR3DtUJfgBbuwxCJ9reXYoIL8/GEkw=; h=Subject:To:References:From:Date:In-Reply-To; b=rTyBOGASGRFPXX4aeA3pOobAFPpEisG5oN0GCcxXFtoEuPkYX/OI/uvjwhhNqzMTA dcs1lqwAUSarE6cB1s/OXEMU8oTYasuyN9BQ2zKHSkZUB7hzHMk7uMP89PAftGo7Td r77jAu9dnUlOZ7VX8Dgmgw5/6XA+dxRHPLn6lWZ7JSlNU6mOE9OoWB299JQRnrUSjr ZoXpANbHt5t58yqCdNj3miJBzevJDp0JFGx3NnR0owJv8FGVQJzvhQdvM8dKpEfuCE 3m/h9gFUsOvjv0FoVZKwzJCaIFw1idh1JwcOOSBVHlwwKU1XVdSdv8icZo1GBPl52B CAGQwoEHh3R1A== Subject: Re: Practice of "Sponsored by" in commit messages To: Julian Elischer , FreeBSD Ports References: <9260b48c-cdeb-e144-b4af-8ea43f730303@freebsd.org> From: "John W. O'Brien" Autocrypt: addr=john@saltant.com; prefer-encrypt=mutual; keydata= xsFNBFpcMG0BEACeAEQ0ZTUEH+6B8XIBid2H8g1yY+niHxVphqz8JwnQtYX+bS+Kl3vr783F HH81DEbfPtYgHY53NF9FjSzCyj13lXVnEGQOdxXzZVKsN1nyuXCN2hDOFH7Yc5yQ8h85T4Hv sqPIGIXOztu4MX14iUAcTgLhfibNQBeKDeNI+BBeaE9lPuNVeiM+xsI4JYcjmDbjFzAHRpBo ull0koUFh6RZAKE7u17yLej1pTIQQVjQpWdK37BAq4hdkLwjGDY8mDGo3ZwGdNibxIAxv/wi KU6u2DfUg8+kLHIhOqk/+kFQ/uK5YA1azsyD5eIbNAs4W7LglA6SkiGBglTwkP0VCrkPdD14 6sx3U7uFgexDWbVuhLIkcPQ0SRmnjgUKHgk7px/jMvAPKSKoL0JQNdP/+pnO9CDLGmoHx9gE 5kVr5dQK8c/WauEfimAdE9qLuN6vb0Iei73q3e3OOHAUusR5wC5SwXt4iilbaK4r04NKXyfb SB3+qWST07F9cmMscfEStSBhpez3awB+1jz8gr40tkEGsFZGvD2KKAgZdKpoxv6IrZepclWz HpqHF01SRFORYMsd1d83XlEu/S1/Z9YJ87RoCdZuYCkjnoRPtpTi9d+JD/u3ZiQFwLUz/Ne3 VqiGKvY66EGcO3tvANMg6GWD9sqlnBDp9Lls0ChEY3dgDYd6DQARAQABzSJKb2huIFcuIE8n QnJpZW4gPGpvaG5Ac2FsdGFudC5jb20+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAFiEENPkbBr3zmPAVSH2HM8TWS4ldvzsFAlpcMTMFCQX2qcYACgkQM8TWS4ldvztT xQ//eHb1mgd40Z0fN2GnJti6/9uJ771IO6slFQ02GZcXZI+FIQo8Yd1dHe0e0Codu78qvJNr ggUtqdxH6SVp7K1AWHeLH5S0PF6iG5B+YUux080wEv/Mr8PPMgAD8gS3wiPDDgB/kUXO52bn DC3Fc0dUrFE/JAOByVEEDL5nLF6SQNpAtIUnaAIIuhKxi0d40LMcLUwuJ6jExynw8Iu7OVtu Y1PRAH5ESt6wYZq8ro8ukh4rMOxiWtT1yNEgHgnq3N4jKErVo87YJijHSSj80IKxUiKb/T6K tGTEBTKiSUV3OFj0ZoPxcbUmhIg2sBCNHaUCiI0KabqN1NyK2glKtcK6NpWy3JIHvtr3+VL1 /tvQTwlVUIacmsuxkGzm5vJPs/i2RtwsJXEXPmIRNgJ1EwZgpg5VqqEUDlmSyRLb48QcDrdv utKLA1MKLib1fD+0XmxZTbCMlFMlvJjAoBlVq60mvB/Jnv1TTnZ2eN6DKMWoxHKmPICh5F1q esmT/aJRIUoCiAgcChi4Ol4XmW3dM7ypjKCGHzyr6emCky5pjqSQZyFzg0RN5UjUQBISAGmJ E8hCFZIy7tf8meqIDbtkONh+JShN6u3t02JrnzSOQjZCh5WQW9Pnu7unJlIsYB10aZ6rvuAK YjghT8QLG8QVgJj/U9oeVG1Ag60fmLZdOFjRGmnOwU0EWlwwbQEQANebvidw1D5SKSmG3Ut8 p9vngBi5HjYe4FSYcfz0NgYa893RiScQ6yjOwuEf/fEoBgvpVnhcbu0JsaYvDNNzFGzPQcj0 CFhkr5s7REWNLGmmFCxCaGieTxIQdYsLxwn72mops8bsrL0a++8NDE+l7X4K3EUyp9GP7pIq 4l9jeIJ/RnX3yySRlXxcM3P+DV9ltXsnQ9pC/qEVVyK18C1zoiskhxmAY9cv9TJOaANHtA7R 7+hM5TyppIz7kqiwiCf6XfVFqKH0I0srdamb0KTnAZpmyx7iNKYl60PdIfEwkwck8fcGwOSA lwE9CLkHLwKMjx/gF3xRag5xjOdP/Out0cQ/pXv8DWnKblWbiGZheB4xUqhOT9Cj/8u/tKtC 51C9wID26hsrhtSAMJPUwQoo/SwLNEd1JpkqUP1njOdlV8FmM1EozHLPSvwlTm6oWwubkkY6 QkUHqXuO+2VdNhyDfx23fQhd0UPhQ0ceDRnjaSB9ycWqpktBP5iNQajYbx5Ktt8fC2Y+Ztjo u1KY7wJSUzqh7uZgR1TqIOVZp7bdPLBGHW5eNEf0Awq17utGe6d9i4hPmeNqELUz71hjmABm bIQJ+VgqYcQ0T/PrjwhzHv5g3jn67/ftW91nlTNpbhwm8suIdPA1hF6vgnZ3B4+JsevnevLG yU6YCb0OOKleP6pZABEBAAHCwXwEGAEIACYCGwwWIQQ0+RsGvfOY8BVIfYczxNZLiV2/OwUC WlwxTQUJBBV2YAAKCRAzxNZLiV2/O2PnD/wMKz/rzYbf0SaTvgae4jqryrcWRta56dcnVe7W KPuUu4Q/WBGhXKeCfPrlr399bILxZGw5TXuGMjS8gEoMd81PEMcWaMpgg3F569Cxd9GN6AZd LXXrZa0aM7dvZkz98ymILEnqHMpF74sLvZY2PrsOwo2gKXNqhtCJ2ph8OUKhG+NHvAomjMu9 lPQMkXJ4HRV0OljawqAe4y+IFu2K4abWwZw1mdniTCb5al8V2umzf26QL0DgeFp3banlfjYW Dn5cRuDBQqIoR/6cQaKdFKTJYiTVK3p3WRWiJQniYi39S8CR646w+zVi7ax1shSB0r0lxIFo CZu285HcMd7HsHH+T2ZI45ilayUoyoZvxPPlwhiRzyYZ6qqAAXKDihhda7uNApUqLwoSn5FW njmx6KdlVPF9ycCdf+in5k6nVlHWG15ogF/Y96K+/Q1Iuod9rzWqT4bz9a5olY8r++QE3V1b H3z803wXEUAJg+WGTkYXFNw7w6RhSSEhBRzupDoCROSkRhe3vQGy5FLG+BMV9n9nevhj5sBx CM1BbNBdB5H/2RcXh0wSb6zjewgs3UAbBvCQOdMAMo8XpYM5SLBqtaY7oalBElTxtFnwSNJm hMbahYE/wHbkmMqalrzGyQxbSUdrmE64CIX8xmv47fnjRoTZMzKim/02MRH+Ss1M+rLzpw== Organization: Saltant Solutions Message-ID: Date: Thu, 17 May 2018 18:54:29 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <9260b48c-cdeb-e144-b4af-8ea43f730303@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fm7ZTi3jCSEAcaPD8qPEO9PHwXpo79EsQ" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 22:54:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fm7ZTi3jCSEAcaPD8qPEO9PHwXpo79EsQ Content-Type: multipart/mixed; boundary="yKfu3Xblqz21O3ZWfffs3T02U3HIMNtzT"; protected-headers="v1" From: "John W. O'Brien" To: Julian Elischer , FreeBSD Ports Message-ID: Subject: Re: Practice of "Sponsored by" in commit messages References: <9260b48c-cdeb-e144-b4af-8ea43f730303@freebsd.org> In-Reply-To: <9260b48c-cdeb-e144-b4af-8ea43f730303@freebsd.org> --yKfu3Xblqz21O3ZWfffs3T02U3HIMNtzT Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018/05/14 20:25, Julian Elischer wrote: > On 15/5/18 7:40 am, John W. O'Brien wrote: >> Hello FreeBSD Ports, >> >> The Committer's Guide section on Commit Log Messages [0], doesn't cove= r >> the use of the "Sponsored by" key word. As a non-committer contributor= , >> it only recently occurred to me to wonder what work that credit is >> intended to represent, and whether some light definition would be >> helpful to reduce ambiguity. >> >> When a committer credits a sponsor of theirs, from which the contribut= or >> received no sponsorship, the portrayal feels a little awkward. Does th= is >> strike the list as a problem, and if so, how ought it be solved? >> >> To make this concrete, allow me to illustrate the situation. >> >> Alice, working on her own time, prepares and contributes a patch. Bob,= >> who works for Acme Corp, reviews and commits the patch on company time= =2E >> The commit message includes "Sponsored by: Acme Corp". Alice eagerly >> awaits her check from Acme Corp. Should the commit message have read >> "Sponsored by: Acme Corp (Bob)"? >=20 > Probably not for just a review, unless it was pretty in depth and took > many hours. It sounds like my example didn't make the point I intended. I was trying to highlight the fact that the unqualified credit in the example makes it seem like Alice's efforts were funded by the sponsor when they weren't. If Alice's efforts were trivial while Bob's were substantial, maybe that's no big deal. If the reverse is true, then I think there is a problem, which is why I propose qualifying the credit. Ambiguous: Sponsored by: Acme Corp Qualified: Sponsored by: Acme Corp (Bob) To be clear, a committer who "just" reviews and commits a contributed patch should definitely be able to credit their employer at their discretion. > However we want to give some sort of acknowledgement > to companies that do allow their work to be incorporated, and who allow= > their employees to do some FreeBSD work as part of their duties. > It also makes their name familiar to the readers of the commit emails > and often results in others seeking work there etc. > =C2=A0"Sponsored by:"=C2=A0 generally means "some (maybe small) part of= this work > was developed > by someone being paid". It does not specify how much, and it is > generally left to the committer > to decide if it was meaningful.=C2=A0=C2=A0 In some cases it is deliber= ately NOT > entered despite > the developer being paid. (e.g. when a company is in stealth mode, or > when some political > issue is relevant and people don't want to draw attention). I agree that the practice should not aim to quantify the relative contributions, and that the decision to credit a sponsor should be left to each participant. >> This could be extensible to multiple sponsorships. If, instead, Alice >> prepares the patch having received a grant to do so from Best Sys Dev,= >> the commit message could state "Sponsored by: Acme Corp (Bob), Best Sy= s >> Dev (Alice)". >> >> [0] >> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/= article.html#commit-log-message >> >> >> PS: I realize that this issue transcends ports, but it's not clear whe= re >> I should send this instead, and this list seems like it would have a >> reasonably high concentration of people with a stake in the discussion= =2E >> >=20 --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --yKfu3Xblqz21O3ZWfffs3T02U3HIMNtzT-- --fm7ZTi3jCSEAcaPD8qPEO9PHwXpo79EsQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr+CCUACgkQWPtK56pP /m7W1Qf/cg+u6omZX6MhT+ctQHUiTL0FAmPrjWE888+hsHvx0IEClyVw54gY0MHE cSK9q4NKiR5CYTf8PbIb/PfzTxxi1woKyw7UeamEKocgu1HxGemliRUCDGisBVeX kwhoYjmnmrG4QBZOrPKDQO8t5Gs/lcr1gAU5D0dLznHRmiyUOwKwW//zh4i7zmgX mUBMoJ7Lic1siOi1Y7hpMYT9xoG7A5tEdP/V0L2cvks+Nt7eNVpDyohfWBhIv1oy LDZ0xMoMvY6QauLTrHBdfDCU+WZdS4yWJF0+e5vt1uJ5vPi5on0soVd/Xy52uUtf X+tb2dm2pvK4rfAzyw4pyi8lK8g8JA== =fC0Y -----END PGP SIGNATURE----- --fm7ZTi3jCSEAcaPD8qPEO9PHwXpo79EsQ--