From owner-svn-src-all@freebsd.org Fri Feb 28 21:27:46 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 00EA7246497 for ; Fri, 28 Feb 2020 21:27:46 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48TjLS4hxWz4V2G for ; Fri, 28 Feb 2020 21:27:44 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1582925262; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=upWXW9CDrcirzhbkmn3qGaDLlG0T5zisrKHpBD1rJCdyVdhmBXh/hlrQhlKe18enY6s9nZhMC5QLf 3Y62EiYp+G/wME63zAjCzdabFVyNxTKfjOVb4xwUPIuN87NcYDLVU3aL3P+TtVaagSez2aeL1TAMZZ YI/v1StqOhdbVJv1vCKEyHTh7IgPh85tXz6i8T5Xlrt0ENivqK7eJ7Ai9ySoMDW95vfO9kO5B2jPDo 47p4XLAXWPHkC11UGryeKzInA0VVrS8IqMToHf5JH0bYXPo6OJCSmeYV/dPwaDqtXvPsS88xW5b2uP W2y3yfqOzfVKGuI5O23Ou1qN2foWFdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=KfgiQEND/EweslOj1jsp542JhbfGNdtTx75vwYxkImA=; b=G7EKnySh0g4IVmVkASFR453roi3gLnN8yPma0W7ZfuGSde+N8MMRdrcBSuMTeW0Gq5vshxxmIUJ9r VI4V21o0JIpUbitxfSmp90lQgftwKzQNcrL0EgGcpTk5J8iEGkoQXSpkSBYcL49kV2FpDzsav6v2fm hBe8ll7Ct1XqRfJFRIad4quxxIyDN58SaMw8XwV4Le7wcdKAnx8CVW9/47iSyfcUueBlk+kf4c79li 1eCqVKD+NYAbU/N3to1gjA0j8mQaP5qj2CbO3K0+OQhz3+cFg0mnqEZm4/VwZ+H2rHukFKPrkE6cX0 rhGeoGdkegz4CnQbNwFx2Xpl+nldBpg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=KfgiQEND/EweslOj1jsp542JhbfGNdtTx75vwYxkImA=; b=SRoyCOdnJ06Z4eEjcLE6Mne1IQj4rNpKrOD93zO1qt76SMjLksRsVUOMo5bF5Cq+peukzNQWjcYGj oBr4lI5DPdLgYeYncG3CIL1Fg341eNabj4Ng44TWFn5FT+hriEWT/NvxFYjqxUEL8sYK3jy/1UX85X ZHD/tbIp81bcqz7NKc3zSYwe8J4Ur7csOQs91204T0OiZsy/2feVmbZZFxkq6o5dF1SAE8kahBzy8m u62fis9pPTmn9/AsA6mEkb0x9Y8oJ6VeN3cb8kLZVxlnkvRmk2xUaKzAGfJu0blMx0MNJpZFKWjTmO Hniih41v2GlvS3GmboUJiwYPcdUddkg== X-MHO-RoutePath: aGlwcGll X-MHO-User: 2649c1c5-5a71-11ea-9eb3-25e2dfa9fa8d X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 2649c1c5-5a71-11ea-9eb3-25e2dfa9fa8d; Fri, 28 Feb 2020 21:27:41 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 01SLReKk001612; Fri, 28 Feb 2020 14:27:40 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r358416 - head/sys/sys From: Ian Lepore To: Brooks Davis , Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 28 Feb 2020 14:27:40 -0700 In-Reply-To: <20200228211601.GC48231@spindle.one-eyed-alien.net> References: <202002280102.01S1223Q036983@repo.freebsd.org> <20200228211601.GC48231@spindle.one-eyed-alien.net> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48TjLS4hxWz4V2G X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.969,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US]; NEURAL_HAM_LONG(-0.99)[-0.994,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 21:27:46 -0000 On Fri, 2020-02-28 at 21:16 +0000, Brooks Davis wrote: > On Fri, Feb 28, 2020 at 01:02:02AM +0000, Warner Losh wrote: > > Author: imp > > Date: Fri Feb 28 01:02:01 2020 > > New Revision: 358416 > > URL: https://svnweb.freebsd.org/changeset/base/358416 > > > > Log: > > Remove duplicated ATA_CHECK_POWER_MODE > > > > Modified: > > head/sys/sys/ata.h > > > > Modified: head/sys/sys/ata.h > > =================================================================== > > =========== > > --- head/sys/sys/ata.h Fri Feb 28 00:42:27 2020 (r358415) > > +++ head/sys/sys/ata.h Fri Feb 28 01:02:01 2020 (r358416) > > @@ -507,7 +507,6 @@ struct ata_params { > > #define ATA_SF_DIS_SRVIRQ 0xde /* disable service > > interrupt */ > > #define ATA_SF_LPSAERC 0x62 /* Long Phys Sect > > Align ErrRep*/ > > #define ATA_SF_DSN 0x63 /* Device Stats > > Notification */ > > -#define ATA_CHECK_POWER_MODE 0xe5 /* Check > > Power Mode */ > > #define ATA_SECURITY_SET_PASSWORD 0xf1 /* set drive > > password */ > > #define ATA_SECURITY_UNLOCK 0xf2 /* unlock drive > > using passwd */ > > #define ATA_SECURITY_ERASE_PREPARE 0xf3 /* prepare to > > erase drive */ > > > > I know that's not that you were working on, but that's a remarkable > collection of whitespace decisions in the remaining lines. > > -- Brooks It's not as bad when you open the file in an editor. The indentation is consistent and sensible, but it contains a mix of spaces and tabs so it looks pretty bad in an email diff. -- Ian