Date: Fri, 28 Feb 2020 14:27:40 -0700 From: Ian Lepore <ian@freebsd.org> To: Brooks Davis <brooks@freebsd.org>, Warner Losh <imp@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358416 - head/sys/sys Message-ID: <a264825224b4361e7c16b2d43bbc582bc2e885fe.camel@freebsd.org> In-Reply-To: <20200228211601.GC48231@spindle.one-eyed-alien.net> References: <202002280102.01S1223Q036983@repo.freebsd.org> <20200228211601.GC48231@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2020-02-28 at 21:16 +0000, Brooks Davis wrote: > On Fri, Feb 28, 2020 at 01:02:02AM +0000, Warner Losh wrote: > > Author: imp > > Date: Fri Feb 28 01:02:01 2020 > > New Revision: 358416 > > URL: https://svnweb.freebsd.org/changeset/base/358416 > > > > Log: > > Remove duplicated ATA_CHECK_POWER_MODE > > > > Modified: > > head/sys/sys/ata.h > > > > Modified: head/sys/sys/ata.h > > =================================================================== > > =========== > > --- head/sys/sys/ata.h Fri Feb 28 00:42:27 2020 (r358415) > > +++ head/sys/sys/ata.h Fri Feb 28 01:02:01 2020 (r358416) > > @@ -507,7 +507,6 @@ struct ata_params { > > #define ATA_SF_DIS_SRVIRQ 0xde /* disable service > > interrupt */ > > #define ATA_SF_LPSAERC 0x62 /* Long Phys Sect > > Align ErrRep*/ > > #define ATA_SF_DSN 0x63 /* Device Stats > > Notification */ > > -#define ATA_CHECK_POWER_MODE 0xe5 /* Check > > Power Mode */ > > #define ATA_SECURITY_SET_PASSWORD 0xf1 /* set drive > > password */ > > #define ATA_SECURITY_UNLOCK 0xf2 /* unlock drive > > using passwd */ > > #define ATA_SECURITY_ERASE_PREPARE 0xf3 /* prepare to > > erase drive */ > > > > I know that's not that you were working on, but that's a remarkable > collection of whitespace decisions in the remaining lines. > > -- Brooks It's not as bad when you open the file in an editor. The indentation is consistent and sensible, but it contains a mix of spaces and tabs so it looks pretty bad in an email diff. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a264825224b4361e7c16b2d43bbc582bc2e885fe.camel>