From owner-freebsd-hackers@FreeBSD.ORG  Wed May 26 18:58:25 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 55A1C1065674;
	Wed, 26 May 2010 18:58:25 +0000 (UTC)
	(envelope-from seanbru@yahoo-inc.com)
Received: from mrout2.yahoo.com (mrout2.yahoo.com [216.145.54.172])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BB538FC1D;
	Wed, 26 May 2010 18:58:24 +0000 (UTC)
Received: from [127.0.0.1] (proxy8.corp.yahoo.com [216.145.48.13])
	by mrout2.yahoo.com (8.13.6/8.13.6/y.out) with ESMTP id o4QIwAhx008986; 
	Wed, 26 May 2010 11:58:10 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; s=serpent; d=yahoo-inc.com; c=nofws; q=dns;
	h=subject:from:to:cc:in-reply-to:references:content-type:date:
	message-id:mime-version:x-mailer:content-transfer-encoding;
	b=Xas408tEB/xuAYCHIPxn3unFnuy2FJoqpmirqCw/1I1GHgG2pkz4NpecjuQBPJs3
From: Sean Bruno <seanbru@yahoo-inc.com>
To: Garrett Cooper <yanefbsd@gmail.com>
In-Reply-To: <AANLkTikfzFFNSg0ZqYmsmobpkCxcRsS0rx9HYJ_bCvWK@mail.gmail.com>
References: <1274739973.31299.23.camel@localhost.localdomain>
	<4BFBD838.40208@dataix.net> <4BFC1660.1000405@dataix.net>
	<AANLkTimkvxtzMWuvfOLWy5SKQH9kTUow0F2I5nJtGL48@mail.gmail.com>
	<AANLkTikfzFFNSg0ZqYmsmobpkCxcRsS0rx9HYJ_bCvWK@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 26 May 2010 11:58:10 -0700
Message-ID: <1274900290.2481.135.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) 
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Wed, 26 May 2010 19:06:25 +0000
Cc: "sbruno@freebsd.org" <sbruno@freebsd.org>,
	freebsd-hackers <freebsd-hackers@freebsd.org>
Subject: Re: Exposing Zone Sleeps
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2010 18:58:25 -0000

On Wed, 2010-05-26 at 11:52 -0700, Garrett Cooper wrote:


> >>
> >> This patch instead pardon the early.post but there was a problem with
> >> the last patch that I attached for stable/8 r208530 with arguments 10 &
> >> 11 to function sysctl_vm_zone where it wanted a long unsigned integer
> >> rather than u_int64_t.
> >>
> >> This patch satisfies that. Whether its correct is left to the reader but
> >> compiles cleanly & runs smoothly.
> >
> > I know this seems trivial, but could you change:
> >
> > +       printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
> > +           "LIMIT", "USED", "FREE", "REQ", "FAIL", "SLEEP");
> >
> > to
> >
> > +       printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
> > +           "LIMIT", "USED", "FREE", "REQS", "FAIL", "SLEEP");
> >
> > that way the plural nature of requests is more straightforward and understood.
> >
> > Also, do all of the fields _really_ need to have a field width? Seems
> > like overkill to me...
> 
> Oh, and the field width for the last item is wrong; SLEEP will be
> truncated to SLEE.
> Thanks,
> -Garrett

I hate this type of column implementation.  Any ideas on a more useful
implementation?

also, I'm missing an email in this thread somehow.  I didn't see the
second version of the REL-8 patch.

Sean