From owner-cvs-all Sun Oct 20 11:30:36 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56A6037B401; Sun, 20 Oct 2002 11:30:35 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8401843E77; Sun, 20 Oct 2002 11:30:34 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g9KIUTpk075353; Sun, 20 Oct 2002 12:30:29 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 20 Oct 2002 12:30:17 -0600 (MDT) Message-Id: <20021020.123017.75895671.imp@bsdimp.com> To: phk@critter.freebsd.dk Cc: dillon@apollo.backplane.com, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: [src] cvs commit: src/sys/i386/pci pci_bus.c From: "M. Warner Losh" In-Reply-To: <53727.1035138112@critter.freebsd.dk> References: <20021020.122029.53328411.imp@bsdimp.com> <53727.1035138112@critter.freebsd.dk> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <53727.1035138112@critter.freebsd.dk> Poul-Henning Kamp writes: : In message <20021020.122029.53328411.imp@bsdimp.com>, "M. Warner Losh" writes: : : >I susepct the right fix is: : > : > if (id == 0xffffffff) : > continue; : : The question is if we want to have a : #define PCI_NOTHING 0xffffffff : somewhere... We'd need it for each width. The PCI standard defines that no hardware decoding the address is to return 0xff for each of the bytes read. PCI_NOTHING_32 PCI_NOTHING_16 and PCI_NOTHING_8 seems a little silly to me. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message