From owner-freebsd-net@FreeBSD.ORG  Wed Aug 19 18:46:06 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B1C01106568C
	for <freebsd-net@freebsd.org>; Wed, 19 Aug 2009 18:46:06 +0000 (UTC)
	(envelope-from manishv@lineratesystems.com)
Received: from mail-vw0-f180.google.com (mail-vw0-f180.google.com
	[209.85.212.180])
	by mx1.freebsd.org (Postfix) with ESMTP id 700438FC51
	for <freebsd-net@freebsd.org>; Wed, 19 Aug 2009 18:46:06 +0000 (UTC)
Received: by vws10 with SMTP id 10so3941702vws.7
	for <freebsd-net@freebsd.org>; Wed, 19 Aug 2009 11:46:05 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.58.208 with SMTP id i16mr9469031vch.20.1250707562441; Wed, 
	19 Aug 2009 11:46:02 -0700 (PDT)
In-Reply-To: <822688.18516.qm@web63903.mail.re1.yahoo.com>
References: <5bc218350908181535o7c5275dfn2f6647454cfac804@mail.gmail.com>
	<822688.18516.qm@web63903.mail.re1.yahoo.com>
Date: Wed, 19 Aug 2009 12:46:02 -0600
Message-ID: <5bc218350908191146j2a22f8dcrdecb0b67eedce5c2@mail.gmail.com>
From: Manish Vachharajani <manishv@lineratesystems.com>
To: Barney Cordoba <barney_cordoba@yahoo.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-net@freebsd.org
Subject: Re: Dropped vs. missed packets in the ixgbe driver
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2009 18:46:06 -0000

Agreed, the errors are reported but missed packets are not.  The
question is, is the correct fix to just add stats.mpc[0] to if_ierrors
in that line or to add it to if_iqdrops.  The fix is easy once we
agree on what the correct behavior is.

Manish

> Barney wrote:
>
> if you look in ixgbe_update_stats_counters at the bottom:
>
> =A0 =A0 =A0 =A0ifp->if_ierrors =3D missed_rx + adapter->stats.crcerrs +
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0adapter->stats.rlec;
>
> the errors are added in.
>
> BC

--=20
Manish Vachharajani
Founder
LineRate Systems
manishv@lineratesystems.com
(609)635-9531 M