From nobody Fri Sep 5 20:43:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cJSxQ6bBYz66NJf for ; Fri, 05 Sep 2025 20:43:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cJSxQ40vCz3c1x for ; Fri, 05 Sep 2025 20:43:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-323267b98a4so2379305a91.1 for ; Fri, 05 Sep 2025 13:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1757105028; x=1757709828; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZOBm/kXH0KWypAUGmiGn2vB1tpcQXtCkjo6jFIxe7Mk=; b=f4hMiMaP4ByIdW2h+Sp5pYpt/H19/mI6Ww9rqT1ipCeYEAXlB9nYkGOVl+wPaaIxzs 1/iG7vXcudTtswKdUiUBjj2bSRA3l1prFOag8xZXdwEWV51/HcRZXMolARXV4z4e/K2N 73fTrmNgyvQxYi94xNe6fYWS1qhoLlYWpdb6oxojJqezYpiDlPZaPhzIQeil0oOwLKeE 7u+HKqNOrLJqtI1cSJ2p3eDRM7oEyOSo4kMihWDC9uhjqV79khV7p+Xk8j+qoMSjpSjA Dv3QnuoDnfZnHdwIii8PZdl/oFC/yuDMSTyuY5HjIVgY/q5ZU3L/YFrF3kiqAY+eapYJ 0PnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757105028; x=1757709828; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZOBm/kXH0KWypAUGmiGn2vB1tpcQXtCkjo6jFIxe7Mk=; b=viZq6mNDXuwA2zLz86xjk7DLgvb7+H9F2ztnhuHOaP25JZiZgIG9e/GeHN3gxubcvH 04lz4n9u42K+InnMNQAhm4Z1BXzQyfzwHekb2qlPMQ9yjMOJwtXlObJAEIAzsIRbBV82 fa1amDl6gJaANHmPvfW/sNYjpKRFRbwEWrWI/ptNBMrjLqkgxePDGHm4DsfGNjJlBbm3 25Oae/JP5VzIv9xRDdbCXmTGkWiyYrT01/LZnPFe5wsXqCj2lgPKRKV2n9ZwUDG+Ag7W GWo4ydPJ1AbeoTdSciR8mjy9PfkEmB8YrHYzBvFIu1cmkj0QtAwJimfG/JX5nguNJ04W 8gJQ== X-Forwarded-Encrypted: i=1; AJvYcCX6k2mF9C4PEtkDYUQip2CFk7ydW8K+H6hMYCAhSBS/P/rKHw8YTJD0Z4VuBwU6ZShp+tXOrwKk0Q/9mhHaiPulNRXdjw==@freebsd.org X-Gm-Message-State: AOJu0YznPf4o2HmdJLEjWXBjDAsIZNn/pj3RvafR9hIVvDlrm296dFRK 8rZaf2kLcYzTLmOKpjUPNgSeUHWEbFyhT5tI+E1BzLzM1amjFM7CEKdiegwQz//2CTkIFZd+mLm b1XTqviYi+A1MTkOBcZjKT1pzooyLVWErbPlf+JaWPg== X-Gm-Gg: ASbGnctx7+CXDxPdx1/ZTAdVfASsT+b9i+QMZrKcBLjBAX5a9yNAJEpSvugvvjATnYu /qeaGhJYtskAatvzewpnXLvB14/41FycSQoBAoK5tFPvvoIRJhMXd+bqb+69cKKDhnvFV042ILP 0CEZS7mX2d1527qg2sjWwk5Ev8BBTv74C07CtN9zVMt9CZOMig5ZSCFa/t0lkr0eK00EcMvpMDH XPu6tbEKvwirj9rKmWyDSCI+ra9qJMqR9HKp9rIog3boDTacIOaPSkBytU/xeJCiShDq+yw X-Google-Smtp-Source: AGHT+IFQ/JLhAiMZsW7YL4QFuNsisKkk2uPIv+3/3ETLEj+EN1lLb9eKI4X/UlsIMHSVyHIesBCmdwtb4DjFgeeFYy4= X-Received: by 2002:a17:90b:33cf:b0:32b:9774:d33d with SMTP id 98e67ed59e1d1-32d43f6658cmr238200a91.20.1757105028160; Fri, 05 Sep 2025 13:43:48 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509051842.585IgIXp096270@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 5 Sep 2025 14:43:36 -0600 X-Gm-Features: Ac12FXyvNd2YftT-4UnO58qjfCAt6wQSaj7LepK2SxFudRecbKByYbHZ-QWOrIg Message-ID: Subject: Re: git: 3ed0cdf7de79 - main - Update vmimage.subr To: Jessica Clarke Cc: Warner Losh , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000099eef063e13e57b" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cJSxQ40vCz3c1x --000000000000099eef063e13e57b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 5, 2025, 1:40=E2=80=AFPM Jessica Clarke wr= ote: > On 5 Sep 2025, at 19:42, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D3ed0cdf7de79fc0f50f57e75cdb9ae1= 78ab0e74c > > > > commit 3ed0cdf7de79fc0f50f57e75cdb9ae178ab0e74c > > Author: Unicorn9x > > AuthorDate: 2025-09-01 11:30:48 +0000 > > Commit: Warner Losh > > CommitDate: 2025-09-05 18:42:21 +0000 > > > > Update vmimage.subr > > > > This "noatime" tweak, reduced the OPNsense constant 50kb - 80kb disk > writes that wear down the SSD / NVME. > > > > Signed-off-by: Unicorn9x > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1834 > > --- > > release/tools/vmimage.subr | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr > > index 156987e33457..20ffe3b2dac7 100644 > > --- a/release/tools/vmimage.subr > > +++ b/release/tools/vmimage.subr > > @@ -82,7 +82,7 @@ vm_install_base() { > > echo '# Custom /etc/fstab for FreeBSD VM images' \ > > > ${DESTDIR}/etc/fstab > > if [ "${VMFS}" !=3D zfs ]; then > > - echo "/dev/${ROOTLABEL}/rootfs / ${VMFS} rw 1 1"= \ > > + echo "/dev/${ROOTLABEL}/rootfs / ${VMFS} rw,noatime 1 > 1" \ > > Do we really want to be disabling atime for every UFS VM image we > produce? With ZFS we can do that because /var/mail is separate, but > AFAIK there is no separate /var/mail in the UFS images? > I think we do. /var/mail is used by a relatively small group of users. People that need the mail reader features of /var/mail can enable atime. It's the lesser evil. Warner Jessica > > > >> ${DESTDIR}/etc/fstab > > fi > > if [ -z "${NOSWAP}" ]; then > > --000000000000099eef063e13e57b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Sep 5, 2025, 1:40=E2=80= =AFPM Jessica Clarke <jrtc27@freeb= sd.org> wrote:
On 5 Sep 2025= , at 19:42, Warner Losh <imp@freebsd.org> wrote:
>
> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D3ed0cdf7de79fc0f50f57e75cdb9ae= 178ab0e74c
>
> commit 3ed0cdf7de79fc0f50f57e75cdb9ae178ab0e74c
> Author:=C2=A0 =C2=A0 =C2=A0Unicorn9x <unicorn9x@yahoo.com.vn>
> AuthorDate: 2025-09-01 11:30:48 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-09-05 18:42:21 +0000
>
>=C2=A0 =C2=A0 Update vmimage.subr
>
>=C2=A0 =C2=A0 This "noatime" tweak, reduced the OPNsense cons= tant 50kb - 80kb disk writes that wear down the SSD / NVME.
>
>=C2=A0 =C2=A0 Signed-off-by: Unicorn9x
>=C2=A0 =C2=A0 Reviewed by: imp
>=C2=A0 =C2=A0 Pull Request: https://g= ithub.com/freebsd/freebsd-src/pull/1834
> ---
> release/tools/vmimage.subr | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr > index 156987e33457..20ffe3b2dac7 100644
> --- a/release/tools/vmimage.subr
> +++ b/release/tools/vmimage.subr
> @@ -82,7 +82,7 @@ vm_install_base() {
> echo '# Custom /etc/fstab for FreeBSD VM images' \
> > ${DESTDIR}/etc/fstab
> if [ "${VMFS}" !=3D zfs ]; then
> - echo "/dev/${ROOTLABEL}/rootfs=C2=A0 =C2=A0/=C2=A0 =C2=A0 =C2= =A0 =C2=A0${VMFS}=C2=A0 =C2=A0rw=C2=A0 =C2=A0 =C2=A0 1=C2=A0 =C2=A0 =C2=A0 = =C2=A01" \
> + echo "/dev/${ROOTLABEL}/rootfs=C2=A0 =C2=A0/=C2=A0 =C2=A0 =C2= =A0 =C2=A0${VMFS}=C2=A0 =C2=A0rw,noatime=C2=A0 =C2=A0 =C2=A0 1=C2=A0 =C2=A0= =C2=A0 =C2=A01" \

Do we really want to be disabling atime for every UFS VM image we
produce? With ZFS we can do that because /var/mail is separate, but
AFAIK there is no separate /var/mail in the UFS images?

I think we do. /var/= mail is used by a relatively small group of users. People that need the mai= l reader features of /var/mail can enable atime. It's the lesser evil.<= /div>

Warner

Jessica

> >> ${DESTDIR}/etc/fstab
> fi
> if [ -z "${NOSWAP}" ]; then

--000000000000099eef063e13e57b--