From owner-svn-src-all@freebsd.org Wed Sep 23 16:57:10 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 216D13FEF39; Wed, 23 Sep 2020 16:57:10 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BxPVF26vCz3c1f; Wed, 23 Sep 2020 16:57:09 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x32b.google.com with SMTP id w2so757827wmi.1; Wed, 23 Sep 2020 09:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G4SnFdv+sxIPHPyCFWF4H/HuneYMYs5iG0isrOk0TDQ=; b=ETiTC+plkn+SU8x5hyblc6d5HqgJXi7dA6xugIXm0JHNBeGwP7+LDLeAS23+FmHbRk +F9EMYEKNJdP3S75sRtMBTlzobPAI+P+AAjLoW6q6++ivbEqMWX6R8mTtS/1l8i++2xk P1PTQyd1DAUI4aPNO8Heii49DghgHuOYYkuY8vyu80not9SJ9EoN8ohp+ow7oU3wwKCR SSSBeiJOdlNn6i+5/UNbDRqHYHvzvK2HMcWZgpG4gLj+vuZtv6JSw3xMB/R5NqFLxpFS A7shFmWZWy/J4pcYldmyjZEF0Dy7Z8/04iFivC6iaAXeK7siPxz63F/aZUoqNKe5Z9Hs NZaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G4SnFdv+sxIPHPyCFWF4H/HuneYMYs5iG0isrOk0TDQ=; b=rgIXM2pFGXz7zRtunIthWzN3j1Ck+ft02NnKDIg/4I4fJ3QKSWgypQljKadjUmHv8K DJRQreB+JKxH6uiKYE6Enb9DNK20SyjFJr2ppCPbAnT3BPCmzA/eboM1CCZ+pR0xmSOl pYeI75LlnWM5o532lGt6u9zO/bVtb6AT4kyKhqSm6hIGyCKzvsaqlByOeQQY4ewBgcsP MmO2hSxoAHzYeASyEXPDLO+0YNz39CtrDNyHxXuzfESMIn9c+i0B3do23GO6GQrvkG4b TL9ljdzFNRc7/s+Ax0zasxdC+UHwpoL3FF4UbcgxdTDV4gqGcBu4ssbx2V+TFR0i2FGk DLLQ== X-Gm-Message-State: AOAM532BNnmeYL8bs4PfBV1W+wFEz8SbNlMLqVI4UNKQhKcZhhoMrjp7 cjqDvzoG9EIM5mot9Adt8VRPHS1CTd5LGAbpFbQ= X-Google-Smtp-Source: ABdhPJx3bSmhdW47uB0Xjbl/PrbN8UM1vZwLf74E4A9UavRDEvN4M3RNLCyfMg8yH8oaY/+eTsb8ka1pGHzf65Ls3ts= X-Received: by 2002:a7b:ce0d:: with SMTP id m13mr493844wmc.83.1600880227689; Wed, 23 Sep 2020 09:57:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6000:187:0:0:0:0 with HTTP; Wed, 23 Sep 2020 09:57:06 -0700 (PDT) In-Reply-To: <20200923164429.GI2570@kib.kiev.ua> References: <202009231046.08NAk7oW012157@repo.freebsd.org> <20200923164429.GI2570@kib.kiev.ua> From: Mateusz Guzik Date: Wed, 23 Sep 2020 18:57:06 +0200 Message-ID: Subject: Re: svn commit: r366071 - in head/sys: contrib/openzfs/module/os/freebsd/zfs kern sys To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BxPVF26vCz3c1f X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ETiTC+pl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.04)[-1.036]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.03)[-1.027]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::32b:from]; NEURAL_HAM_SHORT(-0.42)[-0.417]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 16:57:10 -0000 On 9/23/20, Konstantin Belousov wrote: > On Wed, Sep 23, 2020 at 10:46:07AM +0000, Mateusz Guzik wrote: >> Author: mjg >> Date: Wed Sep 23 10:46:07 2020 >> New Revision: 366071 >> URL: https://svnweb.freebsd.org/changeset/base/366071 >> >> Log: >> cache: drop the force flag from purgevfs >> >> The optional scan is wasteful, thus it is removed altogether from >> unmount. >> >> Callers which always want it anyway remain unaffected. >> > Is there any checker for debugging kernels, that no cache entries are > left after unmount ? > It is provided indirectly. It is asserted no vnodes are associated with the mount point by the end of unmount, dooming purges entries from the namecache and it is an invariant that doomed vnodes don't gain new entries. -- Mateusz Guzik