From nobody Wed Jun 24 16:33:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glnYy4tMrz6jSmn for ; Wed, 24 Jun 2026 16:33:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glnYy3513z3KVf for ; Wed, 24 Jun 2026 16:33:42 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-691c5776f95so2166135a12.3 for ; Wed, 24 Jun 2026 09:33:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782318821; cv=none; d=google.com; s=arc-20240605; b=ZHZV+OYeAPvy5GdECTm1gElY6hf8391R30DZQ+Ny4I7QZuJbNkQzV1qPD8uSlHPjFF d2qrKY5Ore71cEGjPXea4Q9cFRwIcrIYhSCc2bC4DiRKcOwG11JEHupuCZ7R1XIJ9PBc ryn+rHRQ+fhgVssiqmw/LHCkbAqlE7bpoA8eHFh2+Zo3y49XkiyBnjamIBSPoLmrU04z YE/ZRuh4pplCqfgkH/8av/r69yZfPR7pfVvB+rnuup1sBvpZFEb0+pZfm4q5v4agz7Y8 K3R0TuApM8R9pwHfJqzyGLbP1exOqBKkheA7nCbXQQ4FCRkvS3EqHOrG5wifVAfEH4H1 dFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=o+7OfFR+Nvwa2S+y/NTXo2vPieyMCglWaiKanrBiK78=; fh=jHMTq6KkOUlnbapnXNrhLP2LvXbFpSJ1jNWZ6YG4ciQ=; b=CrCddTt/zIL4DoIs06fuhd4XbA4rRpA/3Asm94K1Op6jrrBeu0LrOKNEqXtmpj556Z MvW4sJkVeYag6GJS02vHcWag43BiqNG4xbqDjSeQc71xuoBSwICIOYg4TtjXw6D3gtSW LLxSmii1IPnkAmlrUpRCs8bjNZvVmF7o0QfHzoulRrO703R4+0NedN6ZTkdUDFX8gBuj bOuW11PJvg9m6hmWXzQBx/L68bl5qLo23nU31nwUETG3E8uy6Rf8/OF13Dv9Zcd62eWH DTJ+mVvltrlMZNfL9iVoPt0dVFRdHHqCSYWh2Zv2uO5Dfmwx2YGeLc6szp2CwzMSbO/n 97mQ==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782318821; x=1782923621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o+7OfFR+Nvwa2S+y/NTXo2vPieyMCglWaiKanrBiK78=; b=CoJAvh//1JtcdZqUEXQ83WkNYmf6mlT15DlquTD1KNFDRcnz8pAvCdZ7qQK6DwtDYI GtC4mPrazBrkUuFSIpI7NslMepbhlvSyQDzmiA71ZgoyoHvRz+kdH0VqMS3l2j16WJRR e6ql3XljO9/ICuC5vTdltAWoyBdFuEcVurctUxMKTHAP5ekwaCiVGlecH8mDPmMGQ/wA 0st84FR7yzw9jsNhx0UXl6B5EbMptLNkeu1ECLHx3z97sznCTFaeTN0H2qu5Pdi7Zeci SPd79St1+BQ5NZcXLJ8aoJVBwN9OOZhMQPr2+z+1eowB+LCNm6FxtwXcTjsJzeTCvmBn cUUQ== X-Forwarded-Encrypted: i=1; AHgh+RpkVcA1jvKdRlpGr86fTe/t4uPW97oyxFmKEg5UzgOphXLuMe1t/znUPd5emoF3/Lxszmj1SYhsKjJ0Jz/bvuyGOOBU@freebsd.org X-Gm-Message-State: AOJu0YxdjcN7f0eZfAN2Aa4/y1mYcm0SGssRJ7Sf6T2xEVsu66hHtenV zYBGO7NLky7lp0mqO6wpu6H3oQ9pKzPiBasbaGo3NJuvLcniEpZR59PuCTbggnnmolMNhjnYxFT uly1xc6rEIBTirEOPp/vc8e65YErKbJM= X-Gm-Gg: AfdE7cl//n1Poe7ULzCgRrLzPCote3/R51YQS9ztYDjeCbl5wv59KN7diTVfuzzj2Mf QahWLdpbCNcCL1Mfx7zmTj6kGZQXJthOOP8NdVerRZgafizGVynTMGOdruk4qW8EgqkOVUwu1gr OIlz11pjTTrM3FEXj5N2ldU5kA/GA/6l+NrQmm4/A3vhK/xKD86UEXUNlrPByevsyTOTr65H/0k HS854UbJmphvVwn61odSYmxRn+vGStpdy++pkytMJoLOQHZIryeRlgQyM9cRGnSakAh34pEhlWo HKhY1wnxdOWuRnmqMJI9ruqxakUtKAjfbGUB+afMq4XspgSxbKhQ/8W4Gg== X-Received: by 2002:a05:6402:3818:b0:692:500f:f91 with SMTP id 4fb4d7f45d1cf-697dba70272mr4621877a12.10.1782318820455; Wed, 24 Jun 2026 09:33:40 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> In-Reply-To: <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> From: Alan Somers Date: Wed, 24 Jun 2026 10:33:28 -0600 X-Gm-Features: AVVi8CfzdUH_vgPxFhy4UwqWDwEL0eFichMtbdkAmRHiBLnrquOqucPlFpQqyEk Message-ID: Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally To: Bryan Drewery Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4glnYy3513z3KVf X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Wed, Jun 24, 2026 at 10:04=E2=80=AFAM Bryan Drewery wrote: > > On 6/23/26 7:54 AM, Alan Somers wrote: > > The branch main has been updated by asomers: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3De03ed9daeb49fffa1d16b8d0= 0240c65e92650d01 > > > > commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 > > Author: Jitendra Bhati > > AuthorDate: 2026-06-12 17:07:55 +0000 > > Commit: Alan Somers > > CommitDate: 2026-06-23 14:53:56 +0000 > > > > fts: refactor to use fd-relative operations internally > > > > Replace all _open() calls with _openat() in __fts_open(), fts_read= (), > > and fts_children(). > > > > Add fts_dirfd to FTSENT. Callers can use > > openat(ent->fts_dirfd, ent->fts_name, ...) to access files > > safely without relying on fts_accpath, which enables: > > > > 1. Capsicum capability mode where path-based operations fail > > 2. Security-sensitive programs that avoid TOCTOU races > > > > Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in > > fts_ufslinks() when fts_dirfd is valid, falling back to statfs() f= or > > root-level entries where fts_dirfd is -1 > > > > This is a preparatory change for fts_openat() which will allow > > callers to provide a pre-opened directory fd, enabling fts(3) > > traversal inside Capsicum capability mode. > > > > Sponsored by: Google LLC (GSoC 2026) > > Reviewed by: asomers, jillest > > MFC after: 2 weeks > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 > Someone on IRC reported they bisected a Poudriere breakage to this commit= . Really? I'd be interested to see that log. Also, Jitendra is already working on the fix.