From owner-freebsd-net Sat Jul 29 17:30:19 2000 Delivered-To: freebsd-net@freebsd.org Received: from falla.videotron.net (falla.videotron.net [205.151.222.106]) by hub.freebsd.org (Postfix) with ESMTP id 75C9D37B52D for ; Sat, 29 Jul 2000 17:30:08 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from jehovah ([24.201.62.138]) by falla.videotron.net (Sun Internet Mail Server sims.3.5.1999.12.14.10.29.p8) with SMTP id <0FYH002DCIN0X6@falla.videotron.net> for net@FreeBSD.ORG; Sat, 29 Jul 2000 20:28:12 -0400 (EDT) Date: Sat, 29 Jul 2000 20:28:34 -0400 From: Bosko Milekic Subject: Re: Mbuf stuff. To: Bosko Milekic , David Malone Cc: Alfred Perlstein , net@FreeBSD.ORG Message-id: <001b01bff9bd$66266270$8a3ec918@jehovah> MIME-version: 1.0 X-Mailer: Microsoft Outlook Express 5.00.2919.6700 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 7bit X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 References: <200007292314.aa22039@salmon.maths.tcd.ie> X-Priority: 3 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > It says: "No braces are used for control statements with zero or only a > single statement unless that statement is more than a single line in > which case they are permitted." Okay. In that case, Alfred, please remove the braces? :-) > > Not really necessary, because it always is called at splimp(), and > > it's not the exported macro. The "exported" version of the macro wraps > > _MEXTFREE at MBUFLOCK(), and it's called MEXTFREE(). > > _MEXT_DEALLOC_CNT is also internal, but has an XXX somment saying > it should be called at splimp(), which it always is. I just thought > it would be more consistant to have a comment for both. Well, you're right, as _MEXT_DEALLOC_CNT() isn't exportable at all, the comment should just be removed, or added in both cases. > > Thank you very much for bringing all this stuff up! > > Glad to be useful ;-) > > Do you want to make a new version of the patch available, or should > Alfred make the changes as he commits? Well, the changes aren't big at all so I think that it would be simpler for Alfred to add them in the patch rather than me roll over a new set of diffs. Also, my repo is further de-sync'd right now as I've been making some other changes as well. > David. Cheers, Bosko. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message