From owner-cvs-all Thu Feb 13 14:27:28 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BB9037B401; Thu, 13 Feb 2003 14:27:26 -0800 (PST) Received: from haystack.lclark.edu (lclark.edu [149.175.1.2]) by mx1.FreeBSD.org (Postfix) with SMTP id 1154543FAF; Thu, 13 Feb 2003 14:27:21 -0800 (PST) (envelope-from eta@lclark.edu) Received: from [149.175.30.191] ([149.175.30.191]) by haystack.lclark.edu (SAVSMTP 3.0.0.44) with SMTP id M2003021314264932029 ; Thu, 13 Feb 2003 14:26:49 -0800 Subject: Re: cvs commit: src/sys/modules Makefile From: Eric Anholt To: Peter Wemm Cc: Dag-Erling Smorgrav , Marcel Moolenaar , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20030213221729.DD3D32A8C1@canning.wemm.org> References: <20030213221729.DD3D32A8C1@canning.wemm.org> Content-Type: text/plain Organization: Message-Id: <1045175342.11981.1.camel@leguin> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 13 Feb 2003 14:29:02 -0800 Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 2003-02-13 at 14:17, Peter Wemm wrote: > The lines in agpreg.h were what Eric added after the fact. This is an > i386-only chipset. It shouldn't have been in the sparc64, ia64, and alpha > builds. It certainly shouldn't be in powerpc whenever we start doing > builds for that. > > And IMHO, we certainly shouldn't be building/installing/releasing something > that we *know* hard locks the machine (Drew's report on agp_amd.c locking > up the UP1000). He said that he tried that when agp_amd first came out. agp_amd was broken on that chipset for all architectures for some time. I am working on a patch to only build the appropriate stuff for each arch. -- Eric Anholt eta@lclark.edu http://people.freebsd.org/~anholt/ anholt@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message