From owner-svn-src-all@freebsd.org Sat Nov 7 18:00:33 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1CAFA28A4D; Sat, 7 Nov 2015 18:00:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-yk0-f178.google.com (mail-yk0-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 869851E55; Sat, 7 Nov 2015 18:00:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by ykdv3 with SMTP id v3so126024738ykd.0; Sat, 07 Nov 2015 10:00:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=d5y7snafzM4ALC+w+4u+G2vZAdV00Hpw3rzfhdX+Xb0=; b=mQ+c7w22ELad001W2d3rfKjgkUIejXpWWd0T7+/sFrPc0mlm5lneLXqEvVmVkpDPMt Icr2SvBluR7WPNKtLCT7LDXMjDqcM2qlvtQDBrYGZib9rpk8pWdJh6YJaZdd02dNKK8L fTsySNrH6UQm+KiCS9Nhd3eFk5qdbm002q20UUB1TX56m9cQQ2cMHK8k5zMVzSAYhU2v LtbEMnkUdAQtEODxBVCuDd5CcEL6Q0OO2EZ1hojeyVeke/38ceZxHaoa5ds18bofc57e iTnlvM6Nz6gImn/j8PtVR8nBvb/RG0iHGpEi8xk2NyahETB4oE9AEdgwhxQLl5cIlTGd T2SQ== X-Received: by 10.129.106.193 with SMTP id f184mr17941120ywc.157.1446917768516; Sat, 07 Nov 2015 09:36:08 -0800 (PST) Received: from mail-yk0-f182.google.com (mail-yk0-f182.google.com. [209.85.160.182]) by smtp.gmail.com with ESMTPSA id e68sm4428804ywd.34.2015.11.07.09.36.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 09:36:08 -0800 (PST) Received: by ykba4 with SMTP id a4so215193279ykb.3; Sat, 07 Nov 2015 09:36:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.129.88.87 with SMTP id m84mr15503483ywb.73.1446917768129; Sat, 07 Nov 2015 09:36:08 -0800 (PST) Reply-To: cem@FreeBSD.org Received: by 10.37.17.2 with HTTP; Sat, 7 Nov 2015 09:36:08 -0800 (PST) In-Reply-To: <201511071233.tA7CXUKP032030@repo.freebsd.org> References: <201511071233.tA7CXUKP032030@repo.freebsd.org> Date: Sat, 7 Nov 2015 09:36:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r290493 - head/sys/sys From: Conrad Meyer To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 18:00:33 -0000 Missed that instance of intptr_t, sorry. Thanks for fixing it. I think we should also s/intptr_t/intmax_t/ in SYSCTL_HANDLER_ARGS. Thanks, Conrad On Sat, Nov 7, 2015 at 4:33 AM, Konstantin Belousov wrote: > Author: kib > Date: Sat Nov 7 12:33:30 2015 > New Revision: 290493 > URL: https://svnweb.freebsd.org/changeset/base/290493 > > Log: > Correct the argument type in the sysctl_add_oid(9) prototype. On > ILP32 machines, intptr_t and intmax_t are different types. > > Submitted by: skra > > Modified: > head/sys/sys/sysctl.h > > Modified: head/sys/sys/sysctl.h > ============================================================================== > --- head/sys/sys/sysctl.h Sat Nov 7 12:30:43 2015 (r290492) > +++ head/sys/sys/sysctl.h Sat Nov 7 12:33:30 2015 (r290493) > @@ -949,7 +949,7 @@ extern char kern_ident[]; > /* Dynamic oid handling */ > struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, > struct sysctl_oid_list *parent, int nbr, const char *name, int kind, > - void *arg1, intptr_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > + void *arg1, intmax_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > const char *fmt, const char *descr); > int sysctl_remove_name(struct sysctl_oid *parent, const char *name, int del, > int recurse); >