From nobody Thu Jun 3 15:21:54 2021 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 00327BFF554 for ; Thu, 3 Jun 2021 15:22:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FwqPp65LSz3kRJ for ; Thu, 3 Jun 2021 15:22:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id m13so4584900qtk.13 for ; Thu, 03 Jun 2021 08:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zbK/+5S2t7gAYhifnVipGag9kUhkOGJxeNLo6tmzeTI=; b=CjXxjnfOkrd3slLE5IncxYeXmE4LAM3zlbfIsBkFBelS/UD5IZfM0V9Ofqb25NtgB+ UAZKwVfrzR+feTzrfAGhQzOHkOkNSOqNfYk6Q1jCpyHzB6abNdLsG3clLPDl07QvenPO aO7cwA+63y7RgK6FN6g5tO1xI7aEIWzCCp5Q1GjgJOCTjosNc3DwOcFcx+9yFLs4kovy VJMOa6fW8fMeQzaoUSKLMNGwOUbfLdcO9HryolaCM4dLcfMIeJpuyLC0rkpN3hb3nyz1 YlJOArritsvSZ5Br6I6cr0WeNjNysfJzR3dCMbdJfk9mBRj1Qa7m6AkSWNZ4Q/3rz6Fq sY0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zbK/+5S2t7gAYhifnVipGag9kUhkOGJxeNLo6tmzeTI=; b=mS6A+BrgRNGXQefLViEaJ9Qvp9nQBOITOLTvt6/ahK3LG5xu3f3EPyfW4Jaz4f59R6 3CuR740dG1B+G9C58tD8i7qKQKmBYWNau45dh0LfcIx35ByTLkEvj1XxWPWfVryVP9pQ whprJ2O6PbY7YPpQh8Nxfk1ZqQ2DDbuiGic1lccLkT+nQ/ThIDb5mL3+elTQGjAERuCY 87CQK7L3bkBA0XkB1pNx1Kq0TDmJv1SyI0V5Ue3mEGq/Bhkj42vh4Wnu/mB2ZHB8ihmH lvXcBPenFkg+Hp22u9Re49JUcfMEq+h6skaHFGsN13Zizb2xm2bKx42yQ5XYt/Nb6aMc tB/Q== X-Gm-Message-State: AOAM530FECKnmTph/c+v56mhSn5dEjCxEcDsje8ZVjdxnnuxiiGYX6kA c0qqamhsc2x1/+wkeRbpgt6mtxwTFUcV6cRaWiEozA== X-Google-Smtp-Source: ABdhPJwdg6GcOzqsSQRe0RzcNya/XWJCnYVjPiEc6ilidDcy/wbdzLJ9kS2yCAUYeGafd1TU8IW+gkN02g78Wbk9EzQ= X-Received: by 2002:ac8:5986:: with SMTP id e6mr29798qte.101.1622733725648; Thu, 03 Jun 2021 08:22:05 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <20210519153757.4e00e96f@bsd64.grem.de> <20210519193243.3fd82d19@bsd64.grem.de> <20210528183714.7xbmuouxlxxy3n6j@aching.in.mat.cc> <20210528205052.1c464a8f@bsd64.grem.de> <20210603160433.14371bea@bsd64.grem.de> In-Reply-To: <20210603160433.14371bea@bsd64.grem.de> From: Warner Losh Date: Thu, 3 Jun 2021 09:21:54 -0600 Message-ID: Subject: Re: zpool upgrade and bootcode on 13-RELEASE To: Michael Gmelin Cc: Mathieu Arnold , Kurt Jaeger , FreeBSD Current Content-Type: multipart/alternative; boundary="00000000000048636a05c3de2330" X-Rspamd-Queue-Id: 4FwqPp65LSz3kRJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: Y --00000000000048636a05c3de2330 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 3, 2021 at 8:05 AM Michael Gmelin wrote: > > > On Fri, 28 May 2021 20:50:52 +0200 > Michael Gmelin wrote: > > > On Fri, 28 May 2021 20:37:14 +0200 > > Mathieu Arnold wrote: > > > > > On Wed, May 19, 2021 at 07:32:43PM +0200, Michael Gmelin wrote: > > > > > > > > > > > > On Wed, 19 May 2021 19:09:06 +0200 > > > > Kurt Jaeger wrote: > > > > > > > > > Hi! > > > > > > > > > > > Does this mean, re-installing the bootcode isn't necessary > > > > > > anymore > > > > > > - or has the warning been removed by accident/as a side effect > > > > > > of merging with OpenZFS? > > > > > > > > > > On the contrary, because of the switch from FreeBSD ZFS to > > > > > OpenZFS, the bootcodes needs to be updated! It's unfortunate > > > > > that no message is displayed 8-( > > > > > > > > > > > > > That's too bad - maybe it would make sense to mention this in the > > > > release errata? > > > > > > > > > The problem is, finding out which bootcode needs to go where > > > > > etc. > > > > > > > > For the machines in question it was a straightforward legacy > > > > layout, so that was easy enough (they came back up just fine - > > > > *phew*). > > > > > > > > Do you think there is any chance to get the warning back in there? > > > > Maybe in a more generic way, like: > > > > > > > > In case you're booting from , please make sure to > > > > update the bootcode according to your partition layout. See `man > > > > zfsboot' for details. > > > > > > > > Fun fact: That man page already exists (I had no idea), but could > > > > use some love - e.g., add the EFI examples you gave. > > > > > > I have had a look at that man page, it gives ten different commands, > > > without saying which you need to use, if they are all needed, or > > > not, or when you actually have to used them. > > > > > > Fun fact is that I absolutely never ever used any of them. All I > > > ever did was run: > > > > > > gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 ada1 > > > > > > because `zpool upgrade` told me to. It would probably be great to > > > have that command in that man page. > > > > > > > Hi Mathieu, > > > > I opened a pull request upstream. It already has been reviewed and > > accepted, but is yet to be merged: > > https://github.com/openzfs/zfs/pull/12104 > > > > The bootcode warning is now only shown for pools that have bootfs set > > (which should be fine on most "normal" installations) and reads like > > this: > > > > Pool 'testpool8' has the bootfs property set, you might need to > > update the boot code. See gptzfsboot(8) and loader.efi(8) for details. > > > > I figured that these are the most relevant man pages for current > > systems. It would make sense to update these man pages to be more > > helpful (latest, when this change lands in FreeBSD, but earlier > > obviously won't hurt). > > The pull request has been merged upstream: > > https://github.com/openzfs/zfs/commit/65d9212aeeb531e9f987bb41a1ee11b526d2cdad > > I'll continue tracking the issue (backporting it to 13?) at our end: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256024 Great. To get into 13, it will need to be merged into their stable branch... The plan moving forward is to merge what's upstream based on the upstream branch. The last technical issue with git should be resolved soon to let that get unstuck. Warner --00000000000048636a05c3de2330--