From owner-cvs-all@FreeBSD.ORG Sun Sep 10 16:51:56 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C045E16A40F; Sun, 10 Sep 2006 16:51:56 +0000 (UTC) (envelope-from mbr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DD1943D46; Sun, 10 Sep 2006 16:51:56 +0000 (GMT) (envelope-from mbr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k8AGpu8Y069775; Sun, 10 Sep 2006 16:51:56 GMT (envelope-from mbr@repoman.freebsd.org) Received: (from mbr@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k8AGpuqm069774; Sun, 10 Sep 2006 16:51:56 GMT (envelope-from mbr) Message-Id: <200609101651.k8AGpuqm069774@repoman.freebsd.org> From: Martin Blapp Date: Sun, 10 Sep 2006 16:51:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern tty.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Sep 2006 16:51:56 -0000 mbr 2006-09-10 16:51:56 UTC FreeBSD src repository Modified files: sys/kern tty.c Log: Fix locking race in ttymodem(). The locking of the proctree happens too late and opens a small race window before tp->t_session->s_leader is accessed. In case tp->t_session has just been set to NULL elsewhere, we get a panic(). This fix is a bandaid until someone else fixes the whole locking in the tty subsystem. Definitly more work needs to be done. MFC after: 1 week Reviewed by: mlaier PR: kern/103101 Revision Changes Path 1.258 +2 -2 src/sys/kern/tty.c