From owner-freebsd-hackers@freebsd.org Mon Jun 3 22:54:51 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EFEA915C0587 for ; Mon, 3 Jun 2019 22:54:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A003732C8; Mon, 3 Jun 2019 22:54:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x53Msgh4077888 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 4 Jun 2019 01:54:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x53Msgh4077888 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x53MsgBj077884; Tue, 4 Jun 2019 01:54:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 4 Jun 2019 01:54:42 +0300 From: Konstantin Belousov To: Alan Somers Cc: FreeBSD Hackers Subject: Re: How to VOP_RECLAIM on demand? Message-ID: <20190603225442.GT75280@kib.kiev.ua> References: <20190603211533.GS75280@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 22:54:51 -0000 On Mon, Jun 03, 2019 at 04:27:26PM -0600, Alan Somers wrote: > On Mon, Jun 3, 2019 at 3:15 PM Konstantin Belousov wrote: > > > > On Mon, Jun 03, 2019 at 02:38:11PM -0600, Alan Somers wrote: > > > It would be useful if I could trigger VOP_RECLAIM on demand for a > > > certain file or pathname. There are some edge cases in fusefs that I > > > can't test otherwise. But I don't see any way to do it. Is such a > > > thing possible? Would it be worth adding a special syscall for this > > > purpose? It could be guarded with INVARIANTS so it wouldn't affect > > > production builds. > > > > Look at revoke(2) and VOP_REVOKE(). It is only implemented and used > > for devfs tty nodes. > > I don't understand how that would help. What does VOP_REVOKE have in > common with VOP_RECLAIM? Sane implementation of VOP_REVOKE for a filesystem that does not do tricks at files level (think devfs) is mostly {vgone(vp);}.