From owner-cvs-all@FreeBSD.ORG  Thu Mar 11 01:40:01 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4323716A4FA; Thu, 11 Mar 2004 01:40:01 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3B1CD43D41; Thu, 11 Mar 2004 01:40:01 -0800 (PST)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2B9e1Ge058394;
	Thu, 11 Mar 2004 01:40:01 -0800 (PST)
	(envelope-from wpaul@repoman.freebsd.org)
Received: (from wpaul@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2B9e0Mc058383;
	Thu, 11 Mar 2004 01:40:00 -0800 (PST)
	(envelope-from wpaul)
Message-Id: <200403110940.i2B9e0Mc058383@repoman.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Thu, 11 Mar 2004 01:40:00 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/compat/ndis subr_ndis.c src/sys/dev/if_ndis
 if_ndis.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2004 09:40:01 -0000

wpaul       2004/03/11 01:40:00 PST

  FreeBSD src repository

  Modified files:
    sys/compat/ndis      subr_ndis.c 
    sys/dev/if_ndis      if_ndis.c 
  Log:
  Fix the problem with the Cisco Aironet 340 PCMCIA card. Most newer drivers
  for Windows are deserialized miniports. Such drivers maintain their own
  queues and do their own locking. This particular driver is not deserialized
  though, and we need special support to handle it correctly.
  
  Typically, in the ndis_rxeof() handler, we pass all incoming packets
  directly to (*ifp->if_input)(). This in turn may cause another thread
  to run and preempt us, and the packet may actually be processed and
  then released before we even exit the ndis_rxeof() routine. The
  problem with this is that releasing a packet calls the ndis_return_packet()
  function, which hands the packet and its buffers back to the driver.
  Calling ndis_return_packet() before ndis_rxeof() returns will screw
  up the driver's internal queues since, not being deserialized,
  it does no locking.
  
  To avoid this problem, if we detect a serialized driver (by checking
  the attribute flags passed to NdisSetAttributesEx(), we use an alternate
  ndis_rxeof() handler, ndis_rxeof_serial(), which puts the call to
  (*ifp->if_input)() on the NDIS SWI work queue. This guarantees the
  packet won't be processed until after ndis_rxeof_serial() returns.
  
  Note that another approach is to always copy the packet data into
  another mbuf and just let the driver retain ownership of the ndis_packet
  structure (ndis_return_packet() never needs to be called in this
  case). I'm not sure which method is faster.
  
  Revision  Changes    Path
  1.51      +1 -0      src/sys/compat/ndis/subr_ndis.c
  1.44      +123 -0    src/sys/dev/if_ndis/if_ndis.c