From nobody Fri Feb 14 10:41:01 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YvT9T5gR5z5p7w6; Fri, 14 Feb 2025 10:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YvT9T3s9bz453v; Fri, 14 Feb 2025 10:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739529661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TeYT9k3IO87DMmb5XkOWLzOKYw4jD8dOYHv+Xbxy88E=; b=GlA4rwOskdALpJt8LhTogTA0VS8CHl1wi8NqOBMO48InZMXScsdYAXEMpE+2YdsvCqFesT LqSud/mUOC3qH4YpkHF2PbxDNnWQWv4VE1wnaNgjXZdrce7iDQem6xvkI3baw//3hdLH1H JPXjP0D1QahpCK6AVSpM90ddJKPHgVe/1GAhouEFGFwHJ0/PloIN+kcrW5g0oGu6a2ZbNi bsBW7X1lc9p11YINA/aFF0OgSbmYB4lNnpIYv3OMiAoNKsXNdCa18Bnlgoe18ZKA2co3ca flzacnxJTmFRdHqERf01JM08QIu8qmir2ni70F6KFKSnAkDDBPybZ32vI4+7rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739529661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TeYT9k3IO87DMmb5XkOWLzOKYw4jD8dOYHv+Xbxy88E=; b=W7MMYcTb6lWpJoChUgLLzLq8cLyMovsSVpCnM6pB0Mi92eAkxadG/Shrl5C+5wtGNW9juk R17q5peapUS7G3loOLie9zb7ENlr6DZF/uf8BT3Tx4Gh41WLg9y/ufNHyO1f3JTMQaMMI3 FtM+5b6z3encsfbm2GVVTkUwVIhqEH2/G6FcyT4J0C3qMIaEHj6h5HS4nPiy77ktui+RP8 wkwojWhl8Q0hAVuxhr3iyqhIBECyve5TYyI6yJboknnJc6a9WpJQWc//s1IB4OPOeV5/Cm pgoBlM2huDTPcIOXN3Sq+DxKBuW4rLiBieyScDahO8lLM5/gr2K5ttq0H2OOrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739529661; a=rsa-sha256; cv=none; b=qrdF27QeJ/+bQCY7r98YiI6wk7JdkM9ydD6braYIgjqYhNdwKZUopWAPKIPlI8LLfreaZ6 z3Wa88oiSeWmW2OkI+t0quqxcOgydxHRqONStEF0tOB8JZzmZwpmSGDaShvzERzQ5maKSl K1Oj5qhigPIOIJKyHh/TbcKHqOvDradqFxskhyEnXKPkTdlxlkSKqqbwTqqV0V5/NLs2LQ aor8iIXEBLJ+CDnbxqaiWXLQfltAAkMs8rwRcxhkGVOFpxI7c2R3YJUiF90xIbJQmHTtYJ v5JPalY46nWHzOuusvKvgFgnqWCIwSNUmWgAlbDRvfRrGbVet3iEjJQERcj5Dw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YvT9T35gTzBJl; Fri, 14 Feb 2025 10:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51EAf1gO061215; Fri, 14 Feb 2025 10:41:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51EAf1vr061212; Fri, 14 Feb 2025 10:41:01 GMT (envelope-from git) Date: Fri, 14 Feb 2025 10:41:01 GMT Message-Id: <202502141041.51EAf1vr061212@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 91bae242bc54 - main - bnxt_en: Improve sysctl handler bnxt_dcb_list_app() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 91bae242bc54856c560557b5ba245df94d570e95 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=91bae242bc54856c560557b5ba245df94d570e95 commit 91bae242bc54856c560557b5ba245df94d570e95 Author: Zhenlei Huang AuthorDate: 2025-02-14 10:38:30 +0000 Commit: Zhenlei Huang CommitDate: 2025-02-14 10:38:30 +0000 bnxt_en: Improve sysctl handler bnxt_dcb_list_app() Prefer sbuf_new_for_sysctl() over error-prone manually managed buffer. No functional change intended. Reviewed by: markj Tested by: Daniel Porsch MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D48496 --- sys/dev/bnxt/bnxt_en/bnxt_sysctl.c | 44 +++++++++++++++----------------------- 1 file changed, 17 insertions(+), 27 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c index 9c2d5bebbce7..6ed7c5e8f42f 100644 --- a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c +++ b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c @@ -1871,7 +1871,7 @@ bnxt_pfc_get_string(struct bnxt_softc *softc, char *buf, struct bnxt_ieee_pfc *p buf += sprintf(buf, "none"); } -static char *bnxt_get_tlv_selector_str(uint8_t selector) +static const char *bnxt_get_tlv_selector_str(uint8_t selector) { switch (selector) { case BNXT_IEEE_8021QAZ_APP_SEL_ETHERTYPE: @@ -1886,24 +1886,23 @@ static char *bnxt_get_tlv_selector_str(uint8_t selector) } static void -bnxt_app_tlv_get_string(struct bnxt_softc *softc, char *buf, - struct bnxt_dcb_app *app, int num) +bnxt_app_tlv_get_string(struct sbuf *sb, struct bnxt_dcb_app *app, int num) { - uint32_t i; + int i; - if (!num) { - buf += sprintf(buf, " None"); + if (num == 0) { + sbuf_printf(sb, " None"); return; } - buf += sprintf(buf, "\n"); + sbuf_putc(sb, '\n'); for (i = 0; i < num; i++) { - buf += sprintf(buf, "\tAPP#%0d:\tpri: %d,\tSel: %d,\t%s: %d\n", - i, - app[i].priority, - app[i].selector, - bnxt_get_tlv_selector_str(app[i].selector), - app[i].protocol); + sbuf_printf(sb, "\tAPP#%0d:\tpri: %d,\tSel: %d,\t%s: %d\n", + i, + app[i].priority, + app[i].selector, + bnxt_get_tlv_selector_str(app[i].selector), + app[i].protocol); } } @@ -1936,25 +1935,16 @@ bnxt_ets_get_string(struct bnxt_softc *softc, char *buf) static int bnxt_dcb_list_app(SYSCTL_HANDLER_ARGS) { + struct sbuf sb; struct bnxt_dcb_app app[128] = {0}; struct bnxt_softc *softc = arg1; int rc, num_inputs = 0; - char *buf; - -#define BNXT_APP_TLV_STR_LEN 4096 - buf = malloc(BNXT_APP_TLV_STR_LEN, M_DEVBUF, M_NOWAIT | M_ZERO); - if (!buf) - return ENOMEM; + sbuf_new_for_sysctl(&sb, NULL, 128, req); bnxt_dcb_ieee_listapp(softc, app, nitems(app), &num_inputs); - bnxt_app_tlv_get_string(softc, buf, app, num_inputs); - - rc = sysctl_handle_string(oidp, buf, BNXT_APP_TLV_STR_LEN, req); - if (rc || req->newptr == NULL) - goto end; - -end: - free(buf, M_DEVBUF); + bnxt_app_tlv_get_string(&sb, app, num_inputs); + rc = sbuf_finish(&sb); + sbuf_delete(&sb); return rc; }