From owner-p4-projects Fri Aug 23 8:34:35 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 786AE37B4EB; Fri, 23 Aug 2002 08:34:29 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB77637B432 for ; Fri, 23 Aug 2002 08:34:20 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E80243E65 for ; Fri, 23 Aug 2002 08:34:19 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 23841 invoked from network); 23 Aug 2002 15:34:19 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 23 Aug 2002 15:34:19 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g7NFYHBQ024949; Fri, 23 Aug 2002 11:34:17 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200208231405.g7NE5dOK067653@freefall.freebsd.org> Date: Fri, 23 Aug 2002 11:34:21 -0400 (EDT) From: John Baldwin To: Brian Feldman Subject: RE: PERFORCE change 16462 for review Cc: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-Aug-2002 Brian Feldman wrote: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=16462 > > Change 16462 by green@green_laptop_2 on 2002/08/23 07:04:41 > > * Don't grab Giant implicitly in mac_cred_mmapped_drop_perms(9). > * Select a good default label (read: "equal") for tty devices. > * Don't crhold(9) before calling crcopy(9) due to undocumented > reference-count assertions. Eh, crcopy() doesn't change the reference count. However, since we have to bump reference counts on things like uidinfo's, etc. it needs to ensure that you only do a crcopy() onto a "blank" ucred. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message