Date: Mon, 2 Dec 2024 23:39:17 +0100 From: Mario Marietto <marietto2008@gmail.com> To: Mark Peek <mp@freebsd.org> Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= <c.koehne@beckhoff.com>, FreeBSD virtualization <freebsd-virtualization@freebsd.org> Subject: Re: Failed to emulate instruction sequence [ 41f646040874064c017d88eb144c89 ] at 0xbea5fcf9 Message-ID: <CA%2B1FSijkwMk_STP1wCyiX96VY7pn%2BmY-ad0_m1shFTBjQhd57Q@mail.gmail.com> In-Reply-To: <CAGGgMJd%2Box54CyDNk6SgQ29b=Rte=MzpRFbgzM%2BF=QWOV8nu=Q@mail.gmail.com> References: <CA%2B1FSijzwf6xHOv7-CfmdFPmxD46vFEdaJ4V6xy29G4BYEetWA@mail.gmail.com> <CAGGgMJemKNkEB87sHABECYrQT37tzPcF74o6dejAz4=nMApCBQ@mail.gmail.com> <CA%2B1FSigkus=xw6Y%2BQzD8hK9Dmkt6LR1hsY-U8V=yQ3yReTSL8g@mail.gmail.com> <CAGGgMJcVC33joaZ%2BdHsCBMHZ-hZPDt-9E8mL6Nvb=AdbVDQPqA@mail.gmail.com> <CA%2B1FSigZV6GXurd5KmBwVS6LdbOpP1fLK5wEB7-ROAp%2Bz1axsA@mail.gmail.com> <CAGGgMJd%2Box54CyDNk6SgQ29b=Rte=MzpRFbgzM%2BF=QWOV8nu=Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000035200e0628513a0e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
ok I've used this :
.op_flags =3D VIE_OP_F_IMM8
After the compilation is finished,I copied the compiled vmm.ko module
from /usr/obj/usr/src/amd64.amd64/sys/modules/vmm/vmm.ko
to /boot/kernel and to /boot/modules.
Regarding the bhyve executable,I'm using two custom versions of it,called
bhyve-lin and bhyve-win. When I upgrade the system,they cannot change. What
can change is bhyve,but I don't use it. In addition,to be sure,I copied
bhyve-lin and bhyve-win from the system where I don't have the error. With
this being said,the recompilation of vmm.ko didn't solve my issue.
On Mon, Dec 2, 2024 at 11:26=E2=80=AFPM Mark Peek <mp@freebsd.org> wrote:
> On Mon, Dec 2, 2024 at 1:35=E2=80=AFPM Mario Marietto <marietto2008@gmail=
.com>
> wrote:
>
>> Yes,I have also exchanged the bhyve binary. Now I'm trying to apply your
>> patch and then I will rebuild vmm.
>> I see that your code is :
>>
>> [0xF6] =3D {
>> /* XXX Group 3 extended opcode - not just TEST */
>> .op_byte =3D 0xF6,
>> .op_type =3D VIE_OP_TYPE_TEST,
>> .op_flags =3D VIE_OP_F_IMM,
>> },
>>
>> but it seems wrong. Shouldn't be .op_flags =3D VIE_OP_F_IMM8 ?
>>
>
> Yes, per the discussion in the bug report, that was the change I need to
> make before submitting it for review. Please make that change in your cop=
y.
>
> And per email after this one, yes, that compilation of vmm.ko looks fine.
>
> Mark
>
--=20
Mario.
--00000000000035200e0628513a0e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>ok I've used this :</div><div><br></div><div>.op_=
flags =3D VIE_OP_F_IMM8</div><div><br></div><div>After the compilation is f=
inished,I copied the compiled vmm.ko module from <tt style=3D"color:rgb(0,1=
22,0)">/usr/obj/usr/src/amd64.amd64/sys/modules/vmm/vmm.ko to /boot/kernel =
and to /boot/modules. <br></tt></div><div><tt style=3D"color:rgb(0,122,0)">=
<br></tt></div><div><tt style=3D"color:rgb(0,122,0)">Regarding the bhyve ex=
ecutable,I'm using two custom versions of it,called bhyve-lin and bhyve=
-win. When I upgrade the system,they cannot change. What can change is bhyv=
e,but I don't use it. In addition,to be sure,I copied bhyve-lin and bhy=
ve-win from the system where I don't have the error. With this being sa=
id,the recompilation of vmm.ko didn't solve my issue.<br></tt></div><di=
v><tt style=3D"color:rgb(0,122,0)">=C2=A0<br></tt></div></div><br><div clas=
s=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_att=
r">On Mon, Dec 2, 2024 at 11:26=E2=80=AFPM Mark Peek <<a href=3D"mailto:=
mp@freebsd.org">mp@freebsd.org</a>> wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">On Mon, Dec=
2, 2024 at 1:35=E2=80=AFPM Mario Marietto <<a href=3D"mailto:marietto20=
08@gmail.com" target=3D"_blank">marietto2008@gmail.com</a>> wrote:</div>=
<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr"><div>Yes,I have also exchanged the bhyve binary. Now I&#=
39;m trying to apply your patch and then I will rebuild vmm. <br></div><div=
>I see that your code is :<br></div><div><br></div><div>[0xF6] =3D {<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* XXX Group 3 extende=
d opcode - not just TEST */<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 .op_byte =3D 0xF6,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 .op_type =3D VIE_OP_TYPE_TEST,<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .op_flags =3D VIE_OP_F_IMM,<br>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 },</div><div><br></div><div>but it seems wrong. Should=
n't be .op_flags =3D VIE_OP_F_IMM8 ?</div></div></blockquote><div><br><=
/div><div>Yes, per the discussion in the bug report, that was the change I =
need to make before submitting it for review. Please make that change in yo=
ur copy.</div><div><br></div><div>And per email after this one, yes, that c=
ompilation of vmm.ko looks fine.</div><div><br></div><div>Mark</div></div><=
/div>
</blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature">Ma=
rio.<br></div>
--00000000000035200e0628513a0e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B1FSijkwMk_STP1wCyiX96VY7pn%2BmY-ad0_m1shFTBjQhd57Q>