From owner-freebsd-arch@FreeBSD.ORG Tue Sep 21 22:26:42 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE8DA16A4CE; Tue, 21 Sep 2004 22:26:42 +0000 (GMT) Received: from athena.softcardsystems.com (mail.softcardsystems.com [12.34.136.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E19643D39; Tue, 21 Sep 2004 22:26:42 +0000 (GMT) (envelope-from sah@softcardsystems.com) Received: from athena (athena [12.34.136.114])i8LNQASQ002989; Tue, 21 Sep 2004 18:26:10 -0500 Date: Tue, 21 Sep 2004 18:26:10 -0500 (EST) From: Sam X-X-Sender: sah@athena To: Julian Elischer In-Reply-To: <41508FEB.6030203@elischer.org> Message-ID: References: <415083CC.7C041DFD@freebsd.org><41508827.8010007@elischer.org> <41508FEB.6030203@elischer.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: Andre Oppermann cc: freebsd-arch@freebsd.org Subject: Re: AoE for 4.x X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 22:26:43 -0000 > Sam wrote: > >>> I'm sure you mentionned this before, but why ar eyou not doing it against >>> -current first? >>> >>> We generally don't allow changes to 4.x untill they have settled a bit in >>> -current. (or 5.x) >> >> >> I decided to write a 4.x driver thinking it would a) be easier to port >> forward than backward, and b) would give me experience in the old kernel >> to understand why certain changes were made for the new. >> >> [Thompson's Rule for First-Time Telescope Makers] >> It is faster to make a four-inch mirror and then a six-inch mirror than >> to make a six-inch mirror. > > > hmmmm it might be the other way around here... > >> >> >> As for the single patch, I'll cook one up shortly. I just figured it >> would be more of a pain to look through. > > > I guess we are used to it. > > I can't recommend enough the utility of having a cvs mirror and using cvs to > keep your > work trees sync'd against FreeBSD. It is also a goodd way of making sure that > you don't > forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up all the > changed files. > And I can't thank you enough. I forgot about a few other (rather) important file changes this picked up. A patchfile for aoe against today's 4.10 source tree is at: http://www.coraid.com/support/freebsd/aoe.patch A few notes: The file sys/dev/aoe/aoe4bsd.dd is basic documentation for the driver. All references to chr major 200 will have to be changed to whatever gets assigned, obviously. The netisr selected in sys/net/netisr.h was picked at random. Is it OK? The label typeunknown in sys/net/if_ethersubr.c is added to give netgraph a chance to get the packets if AoE is not loaded. Appropriate? I dinna know how to fill out the copyright/license comment in the headers, but i gave it a shot. Thoughts here would be appreciated. TIA to all the curious eyes that skim the driver for glaring flaws. Cheers, Sam