Date: Wed, 12 Aug 2020 07:09:25 -0600 From: Alan Somers <asomers@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r544720 - head/sysutils/openzfs-kmod Message-ID: <CAOtMX2h29F%2Bgdhtn2CjaNxJi5fwHZRiTdHwv5-Z8XgPEttebSQ@mail.gmail.com> In-Reply-To: <CACNAnaHOpd%2B0Wz36dXuj10nVO%2Bu=bT-QVyeDJTo3a0vAdVYtVw@mail.gmail.com> References: <202008112225.07BMPKiU025312@repo.freebsd.org> <CACNAnaHOpd%2B0Wz36dXuj10nVO%2Bu=bT-QVyeDJTo3a0vAdVYtVw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 12, 2020 at 6:54 AM Kyle Evans <kevans@freebsd.org> wrote: > On Tue, Aug 11, 2020 at 5:25 PM Alan Somers <asomers@freebsd.org> wrote: > > > > Author: asomers (src committer) > > Date: Tue Aug 11 22:25:20 2020 > > New Revision: 544720 > > URL: https://svnweb.freebsd.org/changeset/ports/544720 > > > > Log: > > sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE > > > > ports that need FreeBSD's src code should check $SRC_BASE rather than > assume > > /usr/src. For example, it should be possible to build openzfs-kmod > with a > > command like this: > > > > env SRC_BASE=$HOME/freebsd/base/head make > > > > Approved by: freqlabs (maintainer) > > MFH: 2020Q3 > > Sponsored by: Axcient > > Differential Revision: https://reviews.freebsd.org/D26033 > > > > For future reference, this actually needed additional approval for the > commit to ports, since neither you nor freqlabs are ports committers. > This commit looks fine to me and I don't reckon you need to do > anything with this information for now, though. > > Thanks, > > Kyle Evans > Sorry. brd previously told me that maintainer approval was sufficient for changes like this. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2h29F%2Bgdhtn2CjaNxJi5fwHZRiTdHwv5-Z8XgPEttebSQ>