From owner-svn-ports-all@freebsd.org Wed Aug 12 13:09:39 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 755CC37FBB3; Wed, 12 Aug 2020 13:09:39 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BRVR65P1hz3d53; Wed, 12 Aug 2020 13:09:38 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f51.google.com with SMTP id t7so1870816otp.0; Wed, 12 Aug 2020 06:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A3iKBD3WPWN/vn9f3DrhowYS5jMHAYw64iB/Ve5oMAE=; b=e6xbGGl8ABcrxUYpArRzOYWwhweS7q18HlOCBv561HUhu9tIuH2UcxHFv7oE4yUc/S Zv+1ehFQQZPNYdqg1t95ROu5HBPjZsO4OV0F6qTun/GDIDyBFFZGW/MglmcwawrUWG32 oICeF0C2KogkdRYcJk1yJspDnyWJJgk5FdLKH9l274ysluxDsUlRteGYkEL57LDlRwTh 5qyU9esBQ0VRWxmZ5m3Lf+tnU2fnYWTzx5Du2BmzUANhfFoF0o1TJ0s4KhApzmrgSTTp NY6xE5Ar/pKvck84ttYtEdF492v0W+HgPBXNM0GBLMSd5AQctR3lpaDT3IWE1cFDS9BK 0L6Q== X-Gm-Message-State: AOAM530B5RtnqDIq72xiXQEtCRt6AJsVnRHEG4SfjyzoFf636lsx+5Xv oBbtTJLCu76dPM++LQ+xvIUGLxJoU5MlyFmDlmOtVFv8 X-Google-Smtp-Source: ABdhPJy9WKrS921Gnci5I6ZFNBD3jkWZiXtBDpJlOl6w2gk+Vi5+sfONXVqObuIIb7Y/wLeWXGaYE4MgTqnt9ZTIIeY= X-Received: by 2002:a9d:7f0b:: with SMTP id j11mr8922344otq.291.1597237777024; Wed, 12 Aug 2020 06:09:37 -0700 (PDT) MIME-Version: 1.0 References: <202008112225.07BMPKiU025312@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Wed, 12 Aug 2020 07:09:25 -0600 Message-ID: Subject: Re: svn commit: r544720 - head/sysutils/openzfs-kmod To: Kyle Evans Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 4BRVR65P1hz3d53 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 13:09:39 -0000 On Wed, Aug 12, 2020 at 6:54 AM Kyle Evans wrote: > On Tue, Aug 11, 2020 at 5:25 PM Alan Somers wrote: > > > > Author: asomers (src committer) > > Date: Tue Aug 11 22:25:20 2020 > > New Revision: 544720 > > URL: https://svnweb.freebsd.org/changeset/ports/544720 > > > > Log: > > sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE > > > > ports that need FreeBSD's src code should check $SRC_BASE rather than > assume > > /usr/src. For example, it should be possible to build openzfs-kmod > with a > > command like this: > > > > env SRC_BASE=$HOME/freebsd/base/head make > > > > Approved by: freqlabs (maintainer) > > MFH: 2020Q3 > > Sponsored by: Axcient > > Differential Revision: https://reviews.freebsd.org/D26033 > > > > For future reference, this actually needed additional approval for the > commit to ports, since neither you nor freqlabs are ports committers. > This commit looks fine to me and I don't reckon you need to do > anything with this information for now, though. > > Thanks, > > Kyle Evans > Sorry. brd previously told me that maintainer approval was sufficient for changes like this. -Alan