From owner-freebsd-current@FreeBSD.ORG Thu Nov 20 19:19:33 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 192CD16A4CE; Thu, 20 Nov 2003 19:19:33 -0800 (PST) Received: from green.bikeshed.org (green@pcp04368313pcs.nrockv01.md.comcast.net [69.140.209.127]) by green.bikeshed.org (8.12.10/8.12.9) with ESMTP id hAL3JW6p001554; Thu, 20 Nov 2003 22:19:32 -0500 (EST) (envelope-from green@green.bikeshed.org) Received: from localhost (green@localhost)hAL3JWdX001551; Thu, 20 Nov 2003 22:19:32 -0500 (EST) Message-Id: <200311210319.hAL3JWdX001551@green.bikeshed.org> X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: current@FreeBSD.org In-Reply-To: Message from "Brian F. Feldman" of "Thu, 20 Nov 2003 22:09:33 EST." From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 20 Nov 2003 22:19:32 -0500 Sender: green@green.bikeshed.org cc: Josef Karthauser cc: Ian Dowse Subject: Re: kernel panic trying to utilize a da(4)/umass(4) device with ohci(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2003 03:19:33 -0000 "Brian F. Feldman" wrote: > Thanks for the patches to try! They unfortunately didn't fix the crash I > have, but I found out why it's occurring. > > See ohci.c:1389: > if (std->td.td_cbp != 0) > len -= le32toh(std->td.td_be) - > le32toh(std->td.td_cbp) + 1; > > In one of my transfers (look in my log for the 2560 byte one) that statement > actually adds 8192 to len, which is utterly bogus because you can see it > only allocates 2560 -- hence when it tries to finish the transfer it > memcpy()'s way too much memory and my kernel segfaults. If I #if 0 this out, > I'm left only with "umass0: BBB reset failed, STALLED" messages... which is > a lot better than before! I don't know under what situations that bit of > code makes sense, but it definitely needs more reviewing! > > Please check out my debugging messages and tell me if you see any hints as > to why the transfers are getting stalled. I should have looked at the > debugging messages long ago, I guess. Thanks! > > http://green.homeunix.org/~green/ohci-debugging.txt.gz BTW, replying to myself -- it seems to be something missing from the multi-allocation transfers (>8KB), because I can do up to 8KB transfers perfectly fine now, but 10KB ones, for example, like mdir(8) does are the ones that give me BBB stalls. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\