Date: Thu, 21 Jun 2012 21:43:54 GMT From: Devin Teske <dteske@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/169306: [Maintainer Update] Minor bug fixes to sysutils/bsdconfig Message-ID: <201206212143.q5LLhs09015458@red.freebsd.org> Resent-Message-ID: <201206212150.q5LLoCu4041456@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169306 >Category: ports >Synopsis: [Maintainer Update] Minor bug fixes to sysutils/bsdconfig >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jun 21 21:50:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Devin Teske >Release: FreeBSD 9.0-RELEASE i386 >Organization: FIS Global, Inc. >Environment: FreeBSD push900.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:15:25 UTC 2012 root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: When editing a user's password or account expiration property, choosing cancel or pressing ESC while editing the value manually would cause the value to be blanked rather than preserved. This has been fixed and pressing ESC (or choosing cancel) now preserves the value as expected. Executing "bsdconfig foo" when LANG is set to "EN_US.ISO8859-1" produces a non-i18n-compatible error message: "bsdconfig: foo: not found" (when it should produce: "bsdconfig: foo: NOT FOUND"). This has been fixed by adding the appropriate i18n messages and changing the code to use them. Executing "bsdconfig -h" when LANG is set to an unknown language (for which there are no bsdconfig localized language files), the output did not display appropriately. This has been fixed. Executing "bsdconfig timezone -h" (for example) when LANG is set to an unkown language had similar issues to the above. >How-To-Repeat: Execute "bsdconfig useredit" and select a user (e.g., "root"). Choose "Password Expires on: 0". Choose "Edit value manually". Press ESC. Choose "Edit value manually" (again). Before bugfix, value is changed from "0" to NULL; after bugfix, value remains unchanged. Execute "LANG=EN_US.ISO8859-1 bsdconfig foo" and see the error message is not cASE-rEVERSED (when LANG is set to EN_US.ISO8859-1, all text should be cASE-rEVERSED for i18n-testing). After bugfix, you should see "NOT FOUND" versus "not found" (indicating i18n-messages are working properly). Execute "LANG=foo bsdconfig -h". Before bugfix, the output was sparse/lacking commands and other information. After bugfix, should look like "bsdconfig -h" (no LANG or LC_ALL set or set to NULL; each). Similar test for "LANG=foo bsdconfig timezone -h" >Fix: All problems have been patched by code-changes in the distribution snapshot (referenced/pulled down by new port Makefile). Patch attached with submission follows: --- Makefile.orig 2012-06-20 19:43:43.000000000 -0700 +++ Makefile 2012-06-20 23:43:30.000000000 -0700 @@ -6,10 +6,10 @@ # PORTNAME= bsdconfig -PORTVERSION= 0.7.1 +PORTVERSION= 0.7.2 CATEGORIES= sysutils MASTER_SITES= http://druidbsd.sourceforge.net/download/bsdconfig/ -DISTNAME= ${PORTNAME}.120620 +DISTNAME= ${PORTNAME}.120621 EXTRACT_SUFX= .txz PATCH_SITES= ${MASTER_SITES} --- distinfo.orig 2012-06-20 19:43:43.000000000 -0700 +++ distinfo 2012-06-20 23:44:13.000000000 -0700 @@ -1,4 +1,4 @@ -SHA256 (bsdconfig.120620.txz) = 5bc4c60250a7d3c817239d8f7a0e567cfe8fbec1cd0abaa8ca8d9fdaa0d6b601 -SIZE (bsdconfig.120620.txz) = 87924 -SHA256 (bsdconfig.120620-0.7.1.diff.gz) = 9291ef7094069d7c34ff7647fbd05004f17dec4405f9e6e5acff024a2840245f -SIZE (bsdconfig.120620-0.7.1.diff.gz) = 451 +SHA256 (bsdconfig.120621.txz) = a8eec95affa4f01ca85a7206265776309c3ce103059948bc5174c4c5f5e454d1 +SIZE (bsdconfig.120621.txz) = 88032 +SHA256 (bsdconfig.120621-0.7.2.diff.gz) = 9291ef7094069d7c34ff7647fbd05004f17dec4405f9e6e5acff024a2840245f +SIZE (bsdconfig.120621-0.7.2.diff.gz) = 451 >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206212143.q5LLhs09015458>